aboutsummaryrefslogtreecommitdiff
path: root/sound/midiparser.cpp
diff options
context:
space:
mode:
authorFilippos Karapetis2010-11-27 17:23:24 +0000
committerFilippos Karapetis2010-11-27 17:23:24 +0000
commit0d4ef4854a381e0b206a966e8d0a081b44d2a1df (patch)
tree3bba6e9222ebf527a955bf765687b611e1fd574b /sound/midiparser.cpp
parent8b7c42f0b06a1b162164c16cbff0d457dcfacbde (diff)
downloadscummvm-rg350-0d4ef4854a381e0b206a966e8d0a081b44d2a1df.tar.gz
scummvm-rg350-0d4ef4854a381e0b206a966e8d0a081b44d2a1df.tar.bz2
scummvm-rg350-0d4ef4854a381e0b206a966e8d0a081b44d2a1df.zip
MidiParser: updated comment concerning note on events in jumpToTick()
svn-id: r54508
Diffstat (limited to 'sound/midiparser.cpp')
-rw-r--r--sound/midiparser.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/sound/midiparser.cpp b/sound/midiparser.cpp
index 6559e07468..465d4dedea 100644
--- a/sound/midiparser.cpp
+++ b/sound/midiparser.cpp
@@ -403,12 +403,12 @@ bool MidiParser::jumpToTick(uint32 tick, bool fireEvents, bool stopNotes, bool d
else
_driver->sysEx(info.ext.data, (uint16)info.length);
} else {
+ // The note on sending code is used by the SCUMM engine. Other engine using this code
+ // (such as SCI) have issues with this, as all the notes sent can be heard when a song
+ // is fast-forwarded. Thus, if the engine requests it, don't send note on events.
if (info.command() == 0x9 && dontSendNoteOn) {
// Don't send note on; doing so creates a "warble" with some instruments on the MT-32.
// Refer to patch #3117577
-
- // TODO: this is currently done by SCI only, but it seems sensible enough to do this
- // for all engines
} else {
sendToDriver(info.event, info.basic.param1, info.basic.param2);
}