aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-04-16SCI: Improve MidiParser_SCI robustness against bad sound resourcesColin Snover
1. KQ4 sound 104 has an extra 0xFC (MIDI Stop command/kEndOfTrack) at the end of the resource, which causes an out-of-bounds read because the filtering loop continues after the first 0xFC and unconditionally attempts to read 2 bytes (expecting there to always be a delta value + a command, whereas in this file there is only another kEndOfTrack command). This is corrected by exiting the filtering loop when a kEndOfTrack is encountered and there is not enough data remaining in the resource to continue reading. 2. KQ5 sound 699 is truncated, which causes the parser to attempt to read past the end of the resource. This is addressed by adding bounds checks that exit the mix loop early if there is no more data available to read. This allows truncated sounds to be played as far as possible (previously, trying to read truncated resources would result in a fatal error). 3. midiMixChannels allocates an arbitrary amount of raw memory for the mixed MIDI sequence, without performing any bounds checking when writing to this memory, potentially leading to a crash or silent corruption of adjacent memory. This is mitigated by using SciSpan instead of a raw pointer for the mixed data. Fixes Trac#9727.
2017-04-16TITANIC: Extra debugging info for starfield movementPaul Gilbert
2017-04-16TITANIC: Renamed CStarControlSub20 to CCameraMoverPaul Gilbert
2017-04-16NEWS: Mention improved handling of joysticksThierry Crozat
2017-04-16TITANIC: Fix GCC Unused Variable Warning.D G Turner
2017-04-15TITANIC: Renaming methods for setting camera movementPaul Gilbert
2017-04-15TITANIC: Renaming movement counter fieldsPaul Gilbert
2017-04-15TITANIC: Movement starting to work when star is clickedPaul Gilbert
2017-04-15TITANIC: Renaming and fixes for movers active flagPaul Gilbert
2017-04-15TITANIC: Remove hard-coded starfield positionPaul Gilbert
2017-04-15TITANIC: Fixes for setting up star closeup sphere dataPaul Gilbert
2017-04-14DIRECTOR: Lingo: Added stub for generic event handlersEugene Sandulenko
2017-04-14SCI: Fix speech in QfG IV on big endian platformsThierry Crozat
2017-04-13DIRECTOR: D5 Shared Cast loading.stevenhoefel
2017-04-12TITANIC: Fix centroid calculations in star drawing methodsPaul Gilbert
2017-04-12I18N: Update translation (Italian)Paolo Bossi
Currently translated at 100.0% (946 of 946 strings)
2017-04-12I18N: Update translation (Spanish)Eugene Sandulenko
Currently translated at 98.9% (936 of 946 strings)
2017-04-12I18N: Update translation (Spanish)pablobecerra
Currently translated at 98.9% (936 of 946 strings)
2017-04-10TITANIC: Further cleanup of CStarCloseup drawPaul Gilbert
2017-04-10TITANIC: Cleaning up CStarCloseup drawPaul Gilbert
2017-04-10TITANIC: If statement fix in CStarCloseUp drawPaul Gilbert
2017-04-10TITANIC: Formatting fixPaul Gilbert
2017-04-10TITANIC: Temporarily lock camera for testing star closeup renderingPaul Gilbert
2017-04-10I18N: Update translation (Italian)Paolo Bossi
Currently translated at 100.0% (946 of 946 strings)
2017-04-10I18N: Update translation (Hungarian)George Kormendi
Currently translated at 99.7% (944 of 946 strings)
2017-04-10BLADERUNNER: added Leon AI scriptPeter Kohaut
Happy incept day Leon!
2017-04-10I18N: Update translation (Dutch)Ben Castricum
Currently translated at 100.0% (946 of 946 strings)
2017-04-10I18N: Update translation (Russian)Eugene Sandulenko
Currently translated at 100.0% (946 of 946 strings)
2017-04-10I18N: Update translation (Ukrainian)Eugene Sandulenko
Currently translated at 100.0% (946 of 946 strings)
2017-04-10I18N: Regenerate translations data fileThierry Crozat
2017-04-09TITANIC: Fix CStarControlSub13 setPositionPaul Gilbert
2017-04-09TITANIC: Fix incorrect indexing in CStarCloseup setup2Paul Gilbert
2017-04-09TITANIC: Renaming of CStarCamera methodsPaul Gilbert
2017-04-09TITANIC: Rename CStarControlSub12 to CStarCameraPaul Gilbert
2017-04-09TITANIC: Rename CBaseStar to CBaseStarsPaul Gilbert
2017-04-09I18N: Update translation (French)Thierry Crozat
Currently translated at 100.0% (946 of 946 strings)
2017-04-09I18N: Update translation (French)Purple T
Currently translated at 99.6% (943 of 946 strings)
2017-04-09I18N: Update translation (Finnish)Timo Mikkolainen
Currently translated at 100.0% (946 of 946 strings)
2017-04-09I18N: Update translations templatesThierry Crozat
2017-04-09Merge pull request #921 from Joefish/PR_9711Thierry Crozat
GUI: Restore previous settings if GUI cannot be rendered
2017-04-09TITANIC: Rename CStarControlSub5 to CStarCloseupPaul Gilbert
2017-04-09TITANIC: Fix rendering of starfield pixelsPaul Gilbert
2017-04-08Merge pull request #936 from darkstar/xeen_detectionPaul Gilbert
Xeen: Add detection for the 2CD "talkie" version
2017-04-09DIRECTOR: Remove pointless comparison.Eugene Sandulenko
size is a byte, so it is always < 2048.
2017-04-07TITANIC: Shift vector returns from params to return valuesPaul Gilbert
2017-04-06TITANIC: Add missing initializer for CStarRef1Paul Gilbert
2017-04-06GUI: Restore settings if GUI cannot be renderedJoseph-Eugene Winzer
PR#921 changes the behavior of the client that if the GUI fails to be rendered the previously applied settings in the misc category are restored. Error messages were altered according to the changes. Bug: #9717 GUI: Indirectly changing 'GUI Language' can produce inconsistent behaviour when changing some options.
2017-04-06I18N: Update translations templatesThierry Crozat
2017-04-06GUI: Fix access to deleted widget after rebuilding a dialogThierry Crozat
The issue was with the focus or mouse widget as it may not be a direct child of the dialog (it may for example be a child of the tab widget in the options dialog) and removing a widget was not resetting the mouse of focus widget if that widget was not a direct child.
2017-04-06GUI: Add method to know if a widget contains a given widgetThierry Crozat