aboutsummaryrefslogtreecommitdiff
path: root/backends/graphics/null
AgeCommit message (Collapse)Author
2017-10-15BACKENDS: Fix up graphics manager ports with const & override where appropriateColin Snover
2017-10-15BACKENDS: Refactor OpenGL & SDL graphics backendsColin Snover
This patch refactors the OpenGL and SDL graphics backends, primarily to unify window scaling and mouse handling, and to fix coordinate mapping between the ScummVM window and the virtual game screen when they have different aspect ratios. Unified code for these two backends has been moved to a new header-only WindowedGraphicsManager class, so named because it contains code for managing graphics managers that interact with a windowing system and render virtual screens within a larger physical content window. The biggest behavioral change here is with the coordinate system mapping: Previously, mouse offsets were converted by mapping the whole space within the window as input to the virtual game screen without maintaining aspect ratio. This was done to prevent 'stickiness' when the mouse cursor was within the window but outside of the virtual game screen, but it caused noticeable distortion of mouse movement speed on the axis with blank space. Instead of introducing mouse speed distortion to prevent stickiness, this patch changes coordinate transformation to show the system cursor when the mouse moves outside of the virtual game screen when mouse grab is off, or by holding the mouse inside the virtual game screen (instead of the entire window) when mouse grab is on. This patch also improves some other properties of the GraphicsManager/PaletteManager interfaces: * Nullipotent operations (getWidth, getHeight, etc.) of the PaletteManager/GraphicsManager interfaces are now const * Methods marked `virtual` but not inherited by any subclass have been de-virtualized * Extra unnecessary calculations of hardware height in SurfaceSdlGraphicsManager have been removed * Methods have been renamed where appropriate for clarity (setWindowSize -> handleResize, etc.) * C++11 support improved with `override` specifier added on overridden virtual methods in subclasses (primarily to avoid myself accidentally creating new methods in the subclasses by changing types/names during refactoring) Additional refactoring can and should be done at some point to continue to deduplicate code between the OpenGL and SDL backends. Since the primary goal here was to improve the coordinate mapping, full refactoring of these backends was not completed here.
2014-02-18NULL: Make GPL headers consistent in themselves.Johannes Schickel
2012-06-16ALL: Let overlay related methods in OSystem take a void * and use a proper ↵Johannes Schickel
pitch values. This is a first step to get rid of OverlayColor, which is a requirement for proper 4Bpp overlay support.
2012-06-16BACKENDS: Make OSystem::setMouseCursor take a "const void *" buffer.Johannes Schickel
This is mainly for consistency with OSystem::copyRectToScreen.
2012-06-16BACKENDS: Let copyRectToScreen take a "const void *" instead of "const byte ↵Johannes Schickel
*" as buffer. This removes the need to convert the parameter to copyRectToScreen to "const byte *", which is commonly used in games, which use Graphics::Surface to store their graphics data.
2012-06-03ALL: Replace cursorTargetScale in OSystem API with a simple "do not scale" ↵Johannes Schickel
logic. All uses of the old target scale API actually wanted to disallow scaling of the mouse cursor. This commit adapts our API to this and thus simplifies backend implementations. Some backends, most notable the Wii and Android, did some implementation of the cursor target scale, which I didn't adapt yet. I added a TODO for the porters there.
2012-02-19NULL: Fix compiler errors when using the NullGraphicsManagerThierry Crozat
The errors fixed are inaccessible base class when trying to set the _graphicsManager and a pure virtual function when trying to create the NullGraphicsManager instance.
2011-06-04BACKENDS: Replace OSystem::disableCursorPalette by setFeatureState callsMax Horn
2011-05-12GIT: Clean up: Suppress SVN tags, now uselessstrangerke
2011-02-07BACKENDs: Fix const correctness in "null" graphics managerMax Horn
svn-id: r55807
2010-11-29NULL: Remove extra semicolons in null-graphics.hJohannes Schickel
svn-id: r54587
2010-06-15Adapted null backend to ModularBackend.Alejandro Marzini
svn-id: r49681
2010-06-15Renamed abstract Manager files.Alejandro Marzini
svn-id: r49677
2010-06-08Renamed and moved DefaultGraphicsManager to NullGraphicsManager. Added pure ↵Alejandro Marzini
virtual class GraphicsManager. svn-id: r49528