Age | Commit message (Collapse) | Author |
|
Previous patches that removed shifts of constant negative values
to eliminate UB were valid, but did not correct all places where
this engine was potentially bit shifting negative values. There is
no reason to not just use multiplication and division and let the
compiler make the right choice for optimisation for an
architecture, so that is what this patch does.
|
|
These shifted values are replaced with their literal equivalents
as would be calculated on an x86.
|
|
Although they're shown in our GUI, they were not supposed to be
translatable, rather extracted from the original executable
|
|
|
|
|
|
Ideally this shouldn't use a hardcoded constant at all...
Thanks to WindlePoons for debugging.
|
|
|
|
Coverity
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|