aboutsummaryrefslogtreecommitdiff
path: root/engines/cruise
AgeCommit message (Collapse)Author
2018-07-31CRUISE: Fix Possible Invalid Thumbnail Pointer Access.D G Turner
2018-05-05ALL: Use CLIP to clip volumesAdrian Frühwirth
2018-04-07ALL: Load savegame thumbnail only when necessaryAdrian Frühwirth
This commit introduces the following changes: 1. Graphics::loadThumbnail() Now returns a boolean and takes a new argument skipThumbnail which defaults to false. In case of true, loadThumbnail() reads past the thumbnail data in the input stream instead of actually loading the thumbnail. This simplifies savegame handling where, up until now, many engines always read the whole savegame metadata (including the thumbnail) and then threw away the thumbnail when not needed (which is in almost all cases, the most common exception being MetaEngine::querySaveMetaInfos() which is responsible for loading savegame metadata for displaying it in the GUI launcher. 2. readSavegameHeader() Engines which already implement such a method (name varies) now take a new argument skipThumbnail (default: true) which is passed through to loadThumbnail(). This means that the default case for readSavegameHeader() is now _not_ loading the thumbnail from a savegame and just reading past it. In those cases, e.g. querySaveMetaInfos(), where we actually are interested in loading the thumbnail readSavegameHeader() needs to explicitely be called with skipThumbnail == false. Engines whose readSavegameHeader() (name varies) already takes an argument loadThumbnail have been adapted to have a similar prototype and semantics. I.e. readSaveHeader(in, loadThumbnail, header) now is readSaveHeader(in, header, skipThumbnail). 3. Error handling Engines which previously did not check the return value of readSavegameHeader() (name varies) now do so ensuring that possibly broken savegames (be it a broken thumbnail or something else) don't make it into the GUI launcher list in the first place.
2017-11-10ALL: Fix misuse of comma operatorColin Snover
2017-10-07ENGINES: Remove default1x scaler flagColin Snover
This flag is removed for a few reasons: * Engines universally set this flag to true for widths > 320, which made it redundant everywhere; * This flag functioned primarily as a "force 1x scaler" flag, since its behaviour was almost completely undocumented and users would need to figure out that they'd need an explicit non-default scaler set to get a scaler to operate at widths > 320; * (Most importantly) engines should not be in the business of deciding how the backend may choose to render its virtual screen. The choice of rendering behaviour belongs to the user, and the backend, in that order. A nearby future commit restores the default1x scaler behaviour in the SDL backend code for the moment, but in the future it is my hope that there will be a better configuration UI to allow users to specify how they want scaling to work for high resolutions.
2017-08-06CRUISE: Add explicit fall through comments to switchPaul Gilbert
2017-08-06JANITORIAL: Silence more GCC 7 warningsTorbjörn Andersson
There were all flagged as intentional fall throughs. I simply changed the comments to something GCC would recognize.
2016-12-10CRUISE: Fix font space widthDaniel Plakhotich
2016-12-09CRUISE: font: Don't overwrite transparent pixelsDaniel Plakhotich
2016-05-17CINE: Remove useless code.Eugene Sandulenko
var_2 used to be always NULL after while() loop, thus, the first if() condition is always false.
2016-05-11CRUISE: Safer string manipulationEugene Sandulenko
2016-05-09CRUISE: Plug another memory leakEugene Sandulenko
2016-05-07CRUISE: Plug memory leakEugene Sandulenko
2016-04-14JANITORIAL: Reduce audio header dependenciesOri Avtalion
2016-03-08ENGINES: Make variable names of ADGameDescription conform to our guidelines.Johannes Schickel
gameid -> gameId guioptions -> guiOptions
2016-03-08ENGINES: Make variable names of AdvancedMetaEngine conform to our guidelines.Johannes Schickel
_singleid -> _singleId _gameids -> _gameIds _guioptions -> _guiOptions
2016-02-25CRUISE: Let listSaves return list sorted on slot numbers.Johannes Schickel
2016-01-26CRUISE: Only request actual save slots in listSaves.Johannes Schickel
2015-07-07AUDIO: Remove all AudioStream access to OPLMatthew Hoops
2015-07-07CRUISE: Use the built-in OPL timerMatthew Hoops
2015-07-07AUDIO: Remove the sample rate configuration from the OPL codeMatthew Hoops
2015-07-07AUDIO: Remove the legacy OPL APIMatthew Hoops
2014-06-15CRUISE: Add a safeguard to avoid a potential null pointer derefenreceStrangerke
2014-06-10CRUISE: Remove some useless variables, use a boolean for a variableStrangerke
2014-06-09CRUISE: Initialize some variablesStrangerke
2014-06-09CRUISE: some more renaming, remove another useless variableStrangerke
2014-06-09CRUISE: Remove a couple of useless variablesStrangerke
2014-06-09CRUISE: Initialize some variables in the contractor, change some variables ↵Strangerke
to boolean
2014-06-08CRUISE: Directly use assert.Johannes Schickel
This fixes an ASSERT macro redefinition when compiling the Symbian port. See bug #6622 "SYMBIAN: CRUISE: warning: `ASSERT' redefined".
2014-06-07CRUISE: Add a safeguard, some minor rework in BackgroundIncrustStrangerke
2014-06-07CRUISE: Add a couple of checks to avoid the use of negative indices in ↵Strangerke
arrays. Some minor rework in the data Loader
2014-06-07CRUISE: Some minor rework in script handlerStrangerke
2014-06-07CRUISE: Add some comments, remove some optional bracketsStrangerke
2014-06-07CRUISE: Fix a null pointer dereferenceStrangerke
2014-06-06CRUISE: Fix some more CppCheck warningsStrangerke
2014-06-06CRUISE: Reduce the scope of some more variablesStrangerke
2014-06-06CRUISE: Fix CppCheck warnings in gfxModuleStrangerke
2014-06-06CRUISE: Reduce the scope of several variables in processActorWalk()Strangerke
2014-06-06CRUISE: Disable a bit more efficiently some code in Op_Random() and Op_PlayFx()Strangerke
2014-06-06CRUISE: Reduce the scope of variables in fillpoly()Strangerke
2014-06-06CRUISE: disable more efficiently some codeStrangerke
2014-06-06CRUISE: Fix a couple of CppCheck warnings in VolumeStrangerke
2014-06-05CRUISE: Remove useless code in addAnimation()Strangerke
2014-06-05CRUISE: Remove logically dead code in SoundStrangerke
2014-06-01CRUISE: More rework and renaming on the decompilerStrangerke
2014-06-01CRUISE: Start renaming opcodes in the Decompiler, some reworkStrangerke
2014-06-01CRUISE: Fix a CppCheck error in decompilerStrangerke
2014-06-01CRUISE: Fix a bug in the decompilerStrangerke
2014-06-01CRUISE: Reduce the scope of a variable, remove a useless incrementStrangerke
2014-06-01CRUISE: Comment out some useless codeStrangerke