Age | Commit message (Collapse) | Author | |
---|---|---|---|
2017-11-21 | FULLPIPE: Fix big picture array indexing | Bastien Bouclet | |
Fixes #10322. | |||
2017-11-20 | FULLPIPE: Fix loading inventory items from saves | Bastien Bouclet | |
In C++ the function parameter evaluation order is undefined. The count property was being read first from the stream, instead of the itemId. Fixes #10324. | |||
2017-11-18 | FULLPIPE: Fix memory leaks restoring save games | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks of arcade keys | Colin Snover | |
Fixes Trac#9657. | |||
2017-11-18 | FULLPIPE: Remove manual memory management and fix in-game save/load | Colin Snover | |
2017-11-18 | FULLPIPE: Fix use-after-free in ModalMainMenu | Colin Snover | |
Pointers to objects which are invalidated when the scene gets unloaded may continue to be accessed if a mouse hover event is dispatched to the ModalMainMenu. | |||
2017-11-18 | FULLPIPE: Fix memory leaks of MessageQueues when clearing GlobalMessageQueueList | Colin Snover | |
2017-11-18 | FULLPIPE: Make list item ownership comments more consistent | Colin Snover | |
2017-11-18 | FULLPIPE: Fix leaks of ExCommands loaded from an archive | Colin Snover | |
Nearly every construction of an ExCommand in the engine sets flag 2 of _excFlags. It may even be that the remaining ones that don't are themselves bugs. This flag is needed in order for an ExCommand to be cleaned up when its parent MessageQueue is deleted. | |||
2017-11-18 | FULLPIPE: Remove unnecessary member array clear in destructor | Colin Snover | |
2017-11-18 | FULLPIPE: Fix leaks of MessageQueues | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks of Interactions | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks of PreloadItems | Colin Snover | |
2017-11-18 | FULLPIPE: Remove manual memory management of use list | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks of InventoryPoolItem | Colin Snover | |
2017-11-18 | FULLPIPE: Fix leaks of DynamicPhases | Colin Snover | |
I am not entirely sure this is a correct fix for these leaks; there is still the issue of the last member of _dynamicPhases being invalidated and not removed sometime before the destruction of Movement. Also, some of the items in this array are not actually owned by Movement so deleting them will cause double-frees or use-after-frees. It may be the case that a second list should be maintained instead containing only the objects that are created internally within Movement. Further testing will tell for sure. | |||
2017-11-18 | FULLPIPE: Fix memory leaks of MctlItems in MctlCompound | Colin Snover | |
2017-11-18 | FULLPIPE: Clarify ownership of DynamicPhase::_exCommand | Colin Snover | |
2017-11-18 | FULLPIPE: Clarify ownership of pointer arrays in StaticANIObject | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks in PictureObject, Background | Colin Snover | |
2017-11-18 | FULLPIPE: Use flag enum | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leak of graph nodes and lists | Colin Snover | |
2017-11-18 | FULLPIPE: Remove unnecessary constructors | Colin Snover | |
These appear to be default member-wise copy constructors or POD constructors that zero all members. I suspect that quite a few pointer-taking constructors are actually supposed to be copy-constructors but since they don't all just do default member-wise copies I do not feel confident in changing them without verifying that there are not separate copy constructors in the disassembly, and I don't have the database for this game. | |||
2017-11-18 | FULLPIPE: Fix memory leaks, ownership issues with various point lists | Colin Snover | |
2017-11-18 | FULLPIPE: Disable some unused code paths | Colin Snover | |
2017-11-18 | FULLPIPE: Annotate ownership rule of MfcArchive::readClass | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks and unnecessary indirect allocations in Motion ↵ | Colin Snover | |
and Sc2 | |||
2017-11-18 | FULLPIPE: Fix memory leak of global message queues | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks in ModalMainMenu | Colin Snover | |
2017-11-18 | FULLPIPE: Remove unnecessary and unsafe C-style casts | Colin Snover | |
2017-11-18 | FULLPIPE: Fix deleted queue leaks & clarify flags | Colin Snover | |
2017-11-18 | FULLPIPE: Reduce chance of Scene leaks, remove unused SceneTag member | Colin Snover | |
2017-11-18 | FULLPIPE: Remove unused gap data from EntranceInfo | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks and ownership problems with Behavior objects | Colin Snover | |
2017-11-18 | FULLPIPE: Correctly fix Bitmap leaks | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leak of MGMItem | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks of MovTable and remove unnecessary extra class | Colin Snover | |
2017-11-18 | FULLPIPE: Remove manual memory management of streams | Colin Snover | |
2017-11-18 | FULLPIPE: Use bool literals instead of ints for bool properties | Colin Snover | |
2017-11-18 | FULLPIPE: Take references instead of pointers for required arguments in ↵ | Colin Snover | |
statics, remove unnecessary Picture allocation | |||
2017-11-18 | FULLPIPE: Remove memory leaks and manual memory management in Scene | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks of SceneTag | Colin Snover | |
2017-11-18 | FULLPIPE: Remove unnecessary and illegal C-style casts | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leak of save game thumbnail | Colin Snover | |
2017-11-18 | FULLPIPE: Fix leaks and unnecessary extra allocations in FullpipeEngine | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leak & unnecessary heap allocation of Rects | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks of inventory icons and items | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks in ModalVideoPlayer | Colin Snover | |
2017-11-18 | FULLPIPE: Handle quit/RTL events correctly | Colin Snover | |
Fixes Trac#10316. | |||
2017-11-18 | FULLPIPE: Remove unnecessary extra allocation for RNG | Colin Snover | |