Age | Commit message (Collapse) | Author |
|
variables are signed. Otherwise the credits may hang on a slow system.
svn-id: r21986
|
|
svn-id: r21980
|
|
svn-id: r21937
|
|
new getActiveDomain method that returns a pointer to the actual active *domain*
- Added Engine::_targetName whose value is computed from the name of the active domain
- Removed GameDetector::_targetName, instead code now uses either Engine::_targetName or the name of the active domain
- This in turn allowed for removing usage of GameDetector in many places
svn-id: r21916
|
|
svn-id: r21867
|
|
svn-id: r21827
|
|
Fix a lot of debug/error statements that were using %d/%x
for the result of pointer arithmetic.
As C++ apparently has no format string for ptrdiff_t use
%lu/%lx as appropriate.
svn-id: r21824
|
|
StaticResource::loadPaletteTable (notice the difference between a pointer pointing to a pointer pointing to const memory, vs. a pointer pointing to a *constant* pointer pointing to const memory)
svn-id: r21708
|
|
EN_GRB should be used for games which have both variants. Currently it is
MM NES and BASS. All other are switched to EN_ANY.
svn-id: r21702
|
|
trailing semicolon (this helps certain tools to parse our code better)
svn-id: r21689
|
|
distinguish them)
svn-id: r21686
|
|
svn-id: r21608
|
|
it in several calls to avoid duplication!!11!
svn-id: r21607
|
|
from being unnecessary, the result of strcpy() on overlapping memory areas is
unpredictable.
svn-id: r21562
|
|
to ~250). Many greetings to eriktorbjorn, and have fun recompiling.
svn-id: r21500
|
|
svn-id: r21499
|
|
Adlib sfx") (created a wrapper class for two different sound drivers instead of adding a new variable to the KyraEngine class and chaning stuff there)
- Prevents to play track 0 for non mt-32 midi devices (got ugly sound output with windows midi)
svn-id: r21479
|
|
svn-id: r21472
|
|
Fixes bug with stopping pegasus music before the animation finished.
svn-id: r21469
|
|
it's intended to do now.
Renamed _unkOutputByte2 to _vibratoAndAMDepthBits. It's a pretty terrible name,
but that's what it is: the two most significant bits of the Adlib BD register.
Renamed _rhythmSection to _rhythmSectionBits for consistency: It's the five
least significant bits of the Adlib BD register.
(The remaining bit is the rhythm on/off bit. I don't think we store that one in
any variable.)
svn-id: r21463
|
|
channel's unsigned tempo. Rewrote the function to make this clearer, and
renamed it update_changeChannelTempo().
svn-id: r21448
|
|
unk11 -> durationRandomness
updateCallback12() -> update_setupNoteAndDuration()
updateCallback26() -> update_setupDuration()
updateCallback44() -> update_setDurationRandomness()
svn-id: r21447
|
|
in case some engine writer decide to do something unwise
- Removed used of ConfMan.getKey("path") in file-related cases, because
now File class handles that
- Fixed bug in ScummEngine_v80he::o80_getFileSize() where path delimiters
weren't translated
svn-id: r21443
|
|
svn-id: r21440
|
|
entering the castle. I hope this is a fair approximation of how the original
worked. Of course, this led to a couple of more renamings:
_unk5 -> _soundTrigger
updateCallback54() -> update_setSoundTrigger()
snd_setUnk5() -> snd_getSoundTrigger() (yes, "get")
At the moment, the only known sound triggers are the ones in the castle. If an
unknown trigger is set, the debugging messages will be really, really noisy. I
don't know if I should consider this a bug or an extremely annoying feature.
svn-id: r21396
|
|
svn-id: r21394
|
|
svn-id: r21392
|
|
svn-id: r21379
|
|
with a negative value in certain rooms
svn-id: r21378
|
|
Dialog of Death pops up. Also, mouse clicks are now registered on button up instead of button down, as in the original
svn-id: r21377
|
|
svn-id: r21367
|
|
#define conflicts
svn-id: r21366
|
|
- made some function parameters const (to work with new static res code)
svn-id: r21365
|
|
svn-id: r21358
|
|
drinks will be correct. Also fixes a bug where an animation
(Brandon ringing the bells) would play too quickly.
svn-id: r21354
|
|
svn-id: r21348
|
|
svn-id: r21347
|
|
catacombs")
- Fixes some sprite redraw bugs introduced with my last commits
- Fixes wsa drawing bug in the cave too
svn-id: r21346
|
|
flute sound, and probably other regressions as well.)
svn-id: r21345
|
|
directly. If they want a new data pointer, they have to use the dataptr
parameter. This fixes a subtle bug that would cause the wrong music to play
when getting the quill in Kyra 1.
svn-id: r21344
|
|
Added some comments on the strange but probably harmless things going on in
playSoundEffect()
svn-id: r21340
|
|
disassembly. I think they're correct now, and a bit easier to read. My old
comments were wrong, too.
I think they are for manipulating the Adlib rhythm section volumes. I'm not
sure the Kyra music ever uses the Adlib rhythm section.
svn-id: r21339
|
|
instrument. These are found using the lookup tables in _soundData on offsets 0
and 500 respectively. Added helper functions for that, which makes the code a
lot tidier. Particularly in update_setupRhythmSection(), where it's now much
clearer where it's getting all those "unk" values from.
Use the checkValue() function (which limits the "total level" to its valid
range) for the calculateOpLevel1() and 2() functions as well.
Renamed updateCallback16() to update_waitForEndOfProgram().
svn-id: r21337
|
|
callbackOutput() -> setupPrograms()
callbackProcess() -> executePrograms()
updateCallback3() -> update_setupProgram()
_unk4 -> _rhythmSection
updateCallback48() -> update_setupRhythmSection()
updateCallback49() -> update_playRhythmSection()
updateCallback50() -> update_removeRhythmSection()
svn-id: r21336
|
|
updateCallback3() would call unkOutput2(9) in at least one case. This is
obviously wrong because it a) reads outside _regOffsets[], and b) writes to
invalid Adlib registers.
Now unkOutput2() has the same safeguards as noteOff() already had, making
callbackOutput() and updateCallback3() even more similar.
svn-id: r21335
|
|
svn-id: r21334
|
|
just how similar callbackOutput() and updateCallback3() are.
svn-id: r21333
|
|
correct restored background)
- Fixes brandon width value after loading (removes gfx glitch while talking with the tree)
svn-id: r21332
|
|
- implements cmd_brandonToStoneSequence and cmd_pauseMusicSeconds
svn-id: r21320
|
|
pending events so that the it won't have to do a little dance, catching up,
every time you enter a room.
svn-id: r21316
|