| Age | Commit message (Collapse) | Author |
|---|
|
|
|
(open_door, close_door)
|
|
(show_position, set_position)
|
|
KYRA: Fix MIDI fade-out behaviour
|
|
|
|
|
|
|
|
There are two ways that the music volume may be set:
The setSourceVolume() specifies the current music volume, as
ScummVM sees it. This is stored in _sources[].volume.
The MIDI data itself can trigger volume events. These are handled
by send(), which stores the volume - usually (always?) 100 - in
_sources[_curSource].controllers[]. The volume is then adjusted
by _sources[].volume.
When music is faded out, setSourceVolume() is called repeatedly
with progressively smaller values for the volume. What it should
do, then, is to make sure that the volume is set to what was
previously set to in send(), adjusted to the fading volume.
At least, that's how I understand it.
|
|
|
|
gui_eob.cpp
|
|
|
|
|
|
possible out of bounds access)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
possible null ptr deref)
|
|
|
|
|
|
|
|
|
|
|
|
(KYRA2: Intro doesn't skip righ/Game won't start on first run)
|
|
|
|
(EOB1: Crash when moving in German version)
|
|
Since the music volume is set in playTrack(), it shouldn't be
necessary to set it back to the default level when a fade out has
been completed.
This change prevents the volume from spiking right before quitting
the game. I hope it doesn't cause regressions.
|
|
This is from bug #3608967 - "Lands of Lore - french version 1.20 MD5".
|
|
|
|
RFC: Allow use of override and nullptr. Also allow C++11 compilation.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
(let the FM-Towns version load up and run without errors/crashes)
|
|
|
|
|
|
|
|
|
|
|
|
Done with:
git ls-files "*.cpp" *".h" | xargs sed -i -e 's/0x\([0-9a-f]*\)/0x\U\1/g'
|
|
This was forgotten to adapt in e016e7dfc2b1e3cdb39c01d81c5a34eee66a277b.
|
|
Missile")
|
|
|
|
|
|
|
