aboutsummaryrefslogtreecommitdiff
path: root/engines/kyra
AgeCommit message (Collapse)Author
2016-05-17KYRA: Remove redundant code.Eugene Sandulenko
item variable value is less than 33, that is, 32 max. item+1 is never > 33. Thus, the clapping code is redundant.
2016-05-15KYRA: Simplify Kyra1 audio track filename handlingJohannes Schickel
2016-05-15Revert "KYRA: Plug memory leak"Johannes Schickel
This reverts commit 9909cc615d527bc8d43f930d8c88dc014974f2de. This will likely cause invalid memory reads because it frees the last output buffer which is used to keep files in memory. There is a possible memory leak here, when the input data is not well formed. However, fixing this takes some more effort than the solution in the reverted commit.
2016-05-15KYRA: Silence analysis tools about possible memory leaksJohannes Schickel
2016-05-15Revert "KYRA: Plug memory leak"Johannes Schickel
This reverts commit c22ca8ffb515b03712a0f0e36dd40c7e38c4b8ed. This revision caused invalid memory reads in Kyra1 DOS+FM-TOWNS.
2016-05-15KYRA: Plug memory leakEugene Sandulenko
2016-05-15KYRA: Plug memory leakEugene Sandulenko
2016-04-15KYRA: Initialize variable before usage.Johannes Schickel
Thanks to salty-horse for reporting.
2016-04-14JANITORIAL: Reduce audio header dependenciesOri Avtalion
2016-04-14JANITORIAL: Reduce GUI header dependenciesOri Avtalion
2016-04-03KYRA: (LOL) fix bug #7104 (LOL-CD: mixing sfx and voice mode does not work)athrxx
2016-03-13BACKENDS: Only expose one set of functions for AudioCDManagerMatthew Hoops
Engines should only have to call one set of functions and not decide between the two. In fact, the 'emulation' API was documented to just call the 'real CD' API.
2016-03-13KYRA: Ensure openCD() is calledMatthew Hoops
2016-02-27KYRA: Formatting fixes.Johannes Schickel
2016-02-27KYRA: Remove ADGF_TESTING from EoB 1+2.Johannes Schickel
2016-02-25KYRA: Let listSaves return list sorted on slot numbers.Johannes Schickel
2016-02-15JANITORIAL: Typos detected with lintian & grepAlexandre Detiste
2016-02-09KYRA: Run astyle on sound.cpp.Johannes Schickel
2016-01-26KYRA: Cleanup listing of actual save slots in GUI::updateSaveFileList.Johannes Schickel
2016-01-26KYRA: Only request actual save slots in listSaves.Johannes Schickel
2015-11-10KYRA: (LOK/PC-98) - add missing string resourceathrxx
2015-11-09AUDIO: (FM-TOWNS) - cleanup euphony codeathrxx
(rework parts of the code + improve naming of variables/functions)
2015-07-07AUDIO: Remove all AudioStream access to OPLMatthew Hoops
2015-07-07KYRA: Use the built-in OPL timerMatthew Hoops
2015-07-07AUDIO: Remove the sample rate configuration from the OPL codeMatthew Hoops
2015-07-07AUDIO: Remove the legacy OPL APIMatthew Hoops
2015-05-21KYRA: Update comment since the file it pointed to movedTorbjörn Andersson
Also, ScummVM does have a more modern FMOPL implementation now, so there's no need to bring up other implementations.
2014-10-28KYRA: Remove trailing whitespaceFilippos Karapetis
2014-10-11KYRA: (EOB) - add support for Italian fan translation of EOB Iathrxx
2014-10-04KYRA: Update list of files that contain translatable stringsThierry Crozat
2014-09-07KYRA (LOL): Fix bug #6727 due to incorrect assertion range.D G Turner
This was the bug with "Engine assertion at various dialogues if no items in inventory".
2014-08-24KYRA: Slight cleanup.Johannes Schickel
2014-08-24KYRA: Constify base type for some pointers in AdLibDriver.Johannes Schickel
2014-08-24KYRA: Add safety checks for getProgram/getInstrument return values.Johannes Schickel
This fixes a crash in Hand of Fate when scaring off the rat by using the swampsnake potion on Zanthia. This crash is timing sensitive since the game is stopping the offending sound resource at this point. If it still gets to the instruction setting up an invalid instrument, it will crash ScummVM with in invalid read.
2014-08-24KYRA: Extend safety check inside AdLibDriver::getProgram.Johannes Schickel
This also removes an TODO and replaces it with a comment explaining this safety check.
2014-05-27KYRA: Adpot debugger command function naming to match our guidelines.Johannes Schickel
2014-05-27ALL: Make Debugger command function names conform to our guidelines.Johannes Schickel
2014-05-27ALL: Rename Debugger::DCmd_Register to Debugger::registerCmd.Johannes Schickel
2014-05-27ALL: Rename Debugger::DebugPrintf to Debugger::debugPrintf.Johannes Schickel
2014-04-18KYRA: Extend HACK to select CD audio for Kyra2 TOWNS.Johannes Schickel
Formerly we only checked track1.$EXT but we also support track01.$EXT. Guess this is a good example why we need to reconsider how we will handle detection of presense of CD audio tracks in general...
2014-03-17KYRA: (LOL) - fix LoLEngine::updateCompass()athrxx
2014-03-17KYRA: fix static resources in Russian fan translationathrxx
(some messed up strings)
2014-02-24KYRA: Slight constant name cleanup.Johannes Schickel
2014-02-18KYRA: Make GPL headers consistent in themselves.Johannes Schickel
2014-02-07KYRA: Fix monster idle animation in EoB 1+2. (bug #6523)Johannes Schickel
The bug mentioned is called "EOB1: Monster idle animation broken".
2014-02-05KYRA: Fix scrolling credits in HoF.Johannes Schickel
2014-01-18KYRA: Slight formatting fix.Johannes Schickel
2014-01-18KYRA: Make pointers to VQAHeader constTorbjörn Andersson
This is just to enforce the idea that VQADecoder owns the VQAHeader and that the audio/video tracks are only allowed to look at it, not change it.
2014-01-18KYRA: Restructure the VQA decoder, as suggested by clone2727Torbjörn Andersson
Untangled the audio and video track from each other, and the parsing of the stream from the decoding of its data. Also fixed a memory leak as it turns out deleting a Surface doesn't free its data. You have to call free() in it. I have only checked the intro, not every cutscene, but that seems to work fine at least.
2014-01-18KYRA: Let the VQA decoder draw directly to the backendTorbjörn Andersson
As an alternative to using the Screen class's functions, we can let the VQA decoder draw directly to the backend. This won't work if the game uses "hi-res mode", but I don't think that's ever the case for Malcolm's Revenge. I believe the KyraEngine_MR::playVQA() function ensures that the screen is properly updated after the movie has finished. This almost limits the VQA rewrite to vqa.cpp and vqa.h. Whether it's better this way than changing the Screen functions to take a 'pitch' parameter...? I don't know. But it's an alternative.