aboutsummaryrefslogtreecommitdiff
path: root/engines/sci/engine
AgeCommit message (Collapse)Author
2017-09-27SCI: Add uninitialized read workaround for shoplifting in SQ4CDDavid Fioramonti
When in Galaxy Galleria, going into the software store and trying to shoplift the SQ4 Hintbook will crash the game after you leave and are electrocuted. Fixes Trac#10229. Closes gh-1031.
2017-09-24SCI32: Dummy kPlayVMDSetFrameRateColin Snover
This subop is used only by RAMA. The VMD objects in RAMA's game code contain a frame rate field, which is usually -1, but occasionally is not. In the cases where it is not -1, it appears to be either set for a video with sound (so the value doesn't do anything to that video), or it is just resetting back to the baked-in frame rate of the video file (so it doesn't need to exist, except to fix videos broken by earlier played videos with explicit frame rates). Since this is a global state flag that does not get reset in SSCI, the ultimate effect of kPlayVMDSetFrameRate in RAMA is that it does nothing to any of the videos where the explicit frame rate is set, but it does inadvertently cause *other* videos with no sound and no explicit frame rate to have a different frame rate depending upon what was played earlier in the game (and whether or not the engine was restarted in the meantime). This bad transferring of frame rates is most noticeable with the exit-video of the vidmail player, which is played when you back out after selecting a vidmail. Its nominal framerate is 10fps, but it will play at whatever frame rate was last set by some other video that happened to have an explicit frame rate, even if that frame rate was bogus. So, just ignore all calls to this subop, as it is fatally buggy.
2017-09-24SCI32: Remove unnecessary negative assertion check on unsigned integerColin Snover
Fixes CID 1381416.
2017-09-24SCI32: Disable all SCI32 Mac codeColin Snover
This code is currently untestable and is almost certainly at least partly based on guesswork & not actual reverse-engineering (as was the case for all other pre-2015 SCI32 code), so future developers interested in adding SCI32 Mac support should use it only as an intermediate reference rather than as known good code.
2017-09-24SCI: Remove Mac SCI32 code from SCI16 codeColin Snover
2017-09-24SCI32: Add workarounds for uninitialized reads in RAMAColin Snover
2017-09-24SCI32: Allow invalid references to be passed to kFileIOColin Snover
Near the end of the game, RAMA will start trying to store some invalid references. This does not affect the save game negatively in any way, but it was causing the kernel to assert a signature failure.
2017-09-24SCI32: Fix RAMA auto-save gameColin Snover
Despite what game script disassembly lead me to believe, the game seems to create only one auto-save, which ends up being saved as 911.sg (not autorama.sg). This save file is created just before entering the underground Avian Lair in New York, and seems to be designed as some emergency backup since entering the Avian Lair is a one-way trip.
2017-09-24SCI32: Implement per-channel audio panningColin Snover
Used by RAMA, in various places, starting with the refrigerator at base camp after the cable car at the beginning of the game.
2017-09-24SCI: Add SQ4CD script patch to add audio for universal remote controlMartin Kiewitz
for Hk So Good store catalog. Implements enhancement #10227
2017-09-24SCI: Fix generation of save gamesColin Snover
2017-09-23SCI32: Flush stub RAMA save game to diskColin Snover
If this is not done and the file is buffered, it will not show up in the list of save games, and the new save will fail.
2017-09-23SCI32: Fix bad data cube text priority calculation in RAMAColin Snover
2017-09-23SCI32: Fix relocation of locals in SCI3Colin Snover
Somehow, up until trying to view an encrypted data cube in RAMA, the missing relocation of locals did not seem to cause any trouble in any of the other SCI3 games.
2017-09-23Revert "SCI: Fix Warnings about Copy Constructor Failing to Call Base Class."Colin Snover
This reverts commit d2dd942ad79df0c4ac9d841fb5b0919d260bb79c. The Serializable class is an interface class and has only the empty default copy constructor. There is no reason to call this explicitly. Whatever is warning about this should be fixed to stop warning about it, rather than adding such unnecessary calls to the engine code.
2017-09-23SCI32: Fix handling of array copiesColin Snover
kArrayCopy would perform an unnecessary memory copy of the source array, the treatment of the count value as unsigned was clearly not correct since it was being sign-extended and checked against -1.
2017-09-23SCI32: Fix bad default text scaling in RAMAColin Snover
2017-09-23SCI32: Fix infinite reload in RAMA when loading from launcherColin Snover
2017-09-23SCI32: Add guest additions save/restore support for RAMAColin Snover
2017-09-23SCI32: Remove unnecessary use of strncmpColin Snover
One of the strings is a static string of the same size as the size passed to strncmp so there is no point in not just using strcmp.
2017-09-23SCI32: Replace magic number with kAutoSaveId in QFG4 save codeColin Snover
2017-09-23SCI32: Support RAMA's custom save games through kFileIOColin Snover
2017-09-23SCI: Split save game metadata writing to separate functionColin Snover
RAMA has its own custom save game format that game scripts write, but we still want to be able to use these save game files from the ScummVM launcher, so the metadata has to be able to be written separately from the rest of the game saving.
2017-09-23SCI: Use reference instead of pointer for required out-data in metadata save ↵Colin Snover
function
2017-09-23SCI: Clean-ups to file handling codeColin Snover
Preparations for adding support for RAMA's custom save game format.
2017-09-23SCI32: Remove unused shrink-to-fit function for string arraysColin Snover
2017-09-23SCI32: Fix size for dereferencing non-raw SCI32 arraysColin Snover
The maxSize given when generating a SegmentRef is supposed to be the maximum size of raw data that can be held inside the offset- part of a reg_t, not the entire size including the segment. This fixes a buffer overflow in "Inside the Chest", which still does not work, but at least doesn't cause heap overflows anymore with this change.
2017-09-19SCI32: Fix inconsistent patch instruction commentsColin Snover
I missed these lines when going through things earlier.
2017-09-19SCI32: Put superclass address in r_acc for SCI3 super callsColin Snover
This fixes a problem in Lighthouse 2.0a where the mini-sub would fail to start playing the animation of the shipwreck when clicking on the throttle. In SSCI, in SCI3 only, r_acc was (inadvertently?) set to the superclass object ID whenever a super call was made. This happened because OP_super would call to get the superclass object ID, the calling conventions of the compiler put this return value into EAX, and then the PMachine message processing code put whatever was in EAX into r_acc before each message was processed. In the game code, there are a sequence of steps that look like this: * First, throttle::doVerb is called when throttle is clicked on; * Which calls getRobot::doit to tell the shipwreck robot to start playing; * Which calls wreckBot::init to reset the Robot for the animation; * Which calls Hiliter::hotVerbs(0) to remove cursor hotspots; * Which calls Hiliter::dispose to clean up since it is not used; * Which causes Hiliter::verbList to get set to 0. * Later, verbList is loaded into r_acc, and it is still 0; * Then, Hiliter::dispose makes a super call to Obj::dispose; * Then, Obj::dispose does nothing except call kDisposeClone, which does not mutate r_acc, so r_acc is still 0 from verbList; * Then we return back through 5 calls to throttle::doVerb; * Then throttle::doVerb checks that r_acc is non-zero, and if so, adds wreckBot to theDoits global, allowing the animation to occur. In ScummVM, without setting r_acc in the super call, the non-zero check failed and the wreckBot didn't get put into theDoits, so the entire sequence fell apart. In SSCI, the non-zero check happened to succeed because the Obj::dispose super call put the Obj class into the accumulator. So now we do that too, and now Lighthouse 2.0a works here. Earlier versions of SSCI used EAX for other things in between the OP_super call and the message processing, so would set r_acc from different data, so this change does not apply to those versions.
2017-09-19SCI32: Remove never-read default valuesColin Snover
2017-09-19SCI32: Hide warning about CD-ROM speed setting in kGetSierraProfileIntColin Snover
In the DOS interpreters, this function is a no-op. Lighthouse calls it regardless of platform, so dummy it out for non-Windows platforms. This is not known to address any particular issue, and is really just to eliminate the warning about an unknown configuration setting when starting Lighthouse in a manner that is compatible with the original interpreter.
2017-09-19SCI: Stop EngineState::wait mutating r_accColin Snover
This wait function is used by kernel calls other than kWait, and those other functions do not mutate r_acc in SSCI.
2017-09-17SCI32: Heap patch for Phantasmagoria 2 to fix DocuStore placementsMartin Kiewitz
This fixes placement of "File", "Note", "From" and "Subject" content. See bug #10034
2017-09-17SCI32: GK1CD: script for vine swing issue bug #9820Martin Kiewitz
Gabriel's "I can't believe I'm doing this..." line was cut off. This script patch stops that from happening.
2017-09-17SCI32: Clean-up pass on GK1,GK2,KQ7,PQ4,QfG4,Torin script patchesMartin Kiewitz
comments only
2017-09-16SCI: Remove unused selector from script patcher selectors listColin Snover
2017-09-16SCI32: Clean-up pass on Torin script patchesColin Snover
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR
2017-09-16SCI32: Clean-up pass on GK1 script patchesColin Snover
* Make alignment of operation comments consistent * Make patch descriptions consistent
2017-09-16SCI32: Clean-up pass on Shivers script patchesColin Snover
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR * Wrap comments at 80 columns * Rewrite comments for clarity and brevity * Make identifier suffixes, patch descriptions, and patch table ordering consistent
2017-09-16SCI32: Clean-up pass on Rama script patchesColin Snover
* Make alignment of operation comments consistent
2017-09-16SCI32: Clean-up pass on QFG4 script patchesColin Snover
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR * Make identifier suffixes and patch descriptions consistent
2017-09-16SCI32: Clean-up pass on PQ4 script patchesColin Snover
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR * Convert word-size numeric literals to SIG_UINT16/PATCH_UINT16 * Wrap comments at 80 columns * Rewrite comments for clarity and brevity * Make alignment of operation comments consistent * Make identifier suffixes, patch descriptions, and patch table ordering consistent
2017-09-16SCI32: Clean-up pass on PQ:SWAT script patchesColin Snover
* Make patch descriptions consistent
2017-09-16SCI32: Clean-up pass on Phant2 script patchesColin Snover
* Minor clarity fixes to comments * Make patch descriptions and patch table ordering consistent
2017-09-16SCI32: Clean-up pass on Phant1 script patchesColin Snover
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR * Make identifier suffixes, patch descriptions, and patch table ordering consistent
2017-09-16SCI32: Clean-up pass on MGDX script patchesColin Snover
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR * Fix a patch to use jmp instead of waste bytes * Make identifier suffixes and patch descriptions consistent
2017-09-16SCI32: Clean-up pass on LSL7 script patchesColin Snover
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR * Convert word-size numeric literals to SIG_UINT16/PATCH_UINT16 * Wrap comments at 80 columns * Rewrite comments for clarity and brevity * Make alignment of operation comments consistent * Make identifier suffixes and patch descriptions consistent
2017-09-16SCI32: Clean-up pass on LSL6hires script patchesColin Snover
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR * Make identifier suffixes and patch descriptions consistent
2017-09-16SCI32: Clean-up pass on Lighthouse script patchesColin Snover
* Make patch descriptions consistent
2017-09-16SCI32: Clean-up pass on KQ7 script patchesColin Snover
* Convert selector literals to SIG_SELECTOR/PATCH_SELECTOR * Convert word-size numeric literals to SIG_UINT16/PATCH_UINT16 * Wrap comments at 80 columns * Rewrite comments for clarity and brevity * Make alignment of operation comments consistent * Make identifier suffixes and patch descriptions consistent
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-29 05:43:12 +0000