aboutsummaryrefslogtreecommitdiff
path: root/engines/sci/engine
AgeCommit message (Collapse)Author
2016-12-21SCI: Fix kq6 CD audio+subtitle script patchMartin Kiewitz
Original patch caused a text window to be shown at the cliffs (copy protection), even when audio-only mode was active.
2016-12-19SCI32: Add support for alternate graphics selectorsColin Snover
Used by at least Phantasmagoria 2.
2016-12-19SCI32: Undefine macro for SciBitmap when it is done being usedColin Snover
2016-12-19SCI32: Generalize Phant1 kArraySetElements workaroundColin Snover
This bug exists in a system script that is called from many, many rooms, so it is simpler to just make the workaround apply to all rooms.
2016-12-19SCI32: Fix nitpicky output errors in SCI32 bitmap debuggingColin Snover
2016-12-19SCI32: Add segment table debugging info for SCI32 arraysColin Snover
2016-12-18SCI32: Fix handling of rewritable files opened with mode 1Colin Snover
In SSCI, all files opened through kFileIO are writable. Most of the time this does not matter and the engine can get away with using read-only streams, but when chase.dat is opened by Phant1 from the retry dialogue during the chase, it needs to be writable because game code puts a '98' marker in the chase data. If this write does not occur, the game gets stuck in a loop looking for the marker.
2016-12-18SCI: Fail gracefully when attempting to write to a read-only fdColin Snover
2016-12-18SCI: Remove restriction on backwards seekingColin Snover
SaveFileRewriteStream enables backwards seeking, which is necessary for the chase.dat in Phant1 to be parsed correctly by the game.
2016-12-18SCI: Remove unused second parameter to SegManager::getStringColin Snover
2016-12-18SCI32: Simplify workaround commentColin Snover
It is not necessary to explain what is happening, just how to reproduce it.
2016-12-18SCI32: Add workaround for bad kArraySetElements call at end of Phant1Colin Snover
2016-12-18SCI32: Fix overwriting of file content when opened in append modeColin Snover
Fixes Trac#9586, Trac#9587.
2016-12-17SCI32: Improve SciBitmap segment table debugging outputColin Snover
2016-12-12SCI32: Adjust transition timingsColin Snover
Transition timings were originally chosen largely by feel in SQ6, as there was little other evidence to determine the correct speed. As additional games started being playable in ScummVM, it became apparent that these speeds were not quite right. Additional adjustments may be needed in the future, but these new timings seem to be somewhat closer to expectations than before.
2016-12-12SCI32: Add workaround for hearts game in Hoyle5Colin Snover
2016-12-12SCI: Ensure bytecode/BWT for "file" op is also printedColin Snover
Learning the bytecode for file op is necessary when creating workaround signatures, as the signature-finding mechanism does not currently ignore line/file instructions.
2016-12-11SCI32: Add workarounds for Hoyle5 Crazy EightsColin Snover
2016-12-11SCI32: Implement List sortColin Snover
Used by Hoyle5. Also includes a tiny amount of cleanup in kAddAfter for consistency with kAddBefore.
2016-12-11SCI32: Add workaround for Hoyle5 startup call to kPlatformColin Snover
Fixes Trac#9665.
2016-12-11SCI32: Add a workaround for kDoSoundPlay for KQ7 demoOmer Mor
2016-12-03SCI: Remove unnecessary duplicate shadowing variableColin Snover
2016-12-03SCI: Remove unnecessary lock in SegManagerColin Snover
2016-12-03SCI: Deduplicate text-reading code in kGetFarTextColin Snover
2016-12-03SCI: Clean up some commentsColin Snover
2016-12-03SCI32: Fix LSL6hires text speed sliderColin Snover
For whatever reason, this game uses a different global for specifying the text speed.
2016-11-20SCI32: Add recursion code to kListFirstTrue and kListAllTrueColin Snover
This change ensures that these kernel calls operate in the same manner that they did in SSCI.
2016-11-20SCI: Improve disassembly outputColin Snover
1. pushi opcode now displays decimal value and selector value (if one exists) in-line 2. lofsa, lofss, and super opcodes now display resolved object/class names 3. Opcode arguments are visually aligned
2016-11-20SCI: Add code-address breakpoints to debuggerColin Snover
2016-11-19SCI32: Add script patch for Shivers room 35170Colin Snover
2016-11-19SCI: Warn more loudly about uninitialised parameter readsColin Snover
Silently returning zero values can cause games to break. e.g. Shivers 1 room 35170 has a script bug where vJoystick::handleEvent makes a super call which causes doVerb to be called a second time with no arguments. In the original game this happened to work because the value already on the stack happened to be 1. In ScummVM this silently (unless VM debug messages were enabled) failed because the uninitialised read value was forced to 0.
2016-11-19SCI32: Add missing updateInfoFlagViewVisible callWillem Jan Palenstijn
I missed the one for varselector sends handled by the secondary loop in op_ret. This fixes #9641.
2016-11-10SCI32: Fix incomplete workaround commentColin Snover
2016-11-10SCI32: Fix GK1 crash when erasing letters in St Louis CemeteryColin Snover
Fixes Trac#9642.
2016-11-04SCI32: Implement kPlayVMDIgnorePalettesColin Snover
Used in Shivers room 35170 when pressing the play button.
2016-11-04SCI32: Stop digital audio when VMDs open in some SCI2.1 gamesColin Snover
2016-11-04SCI32: Allow format strings with missing argumentsColin Snover
SSCI created a fake va_list and passed it to vsprintf, so extra placeholders would just silently end up reading garbage memory.
2016-11-04SCI32: Treat %d as unsigned in kStringColin Snover
At least Shivers has VMDs with resource IDs above 2^15; treating %d as signed means that the wrong filename gets created.
2016-11-02SCI32: Fix missing digital audio playback on save game restoreColin Snover
Fixes Trac#9581.
2016-11-02SCI32: Automate kNumCels workaroundColin Snover
2016-10-27SCI32: Read byte/string array values as signed in SCI2.1early-Colin Snover
KQ7 1.51 writes int16s from the save game catalogue into a Str object, then retrieves byte 0 from the string and compares it to -1. This happens to work out because (1) characters were treated as signed in SCI2.1early and earlier, and (2) int16s in the save game catalogue were little-endian. In SCI2.1mid and later, this trick no longer works because characters are treated as unsigned and get zero-extended instead. Fixes Trac#9632.
2016-10-27SCI32: Fix typosColin Snover
Thanks @OmerMor.
2016-10-27SCI32: Fix LSL6hires script bugColin Snover
Fixes Trac#9612.
2016-10-26SCI: Rename hexDigitToInt to indicate it's intentionally brokenWillem Jan Palenstijn
2016-10-25SCI: Implement SSCI bug in hexadecimal escape sequencesColin Snover
In SSCI, strchr is called against a hex string with a duplicate 0 ("01234567890abcdef") to determine the decimal value of hex digits, which means the values A-F are incorrectly interpreted as 11-16 instead of 10-15. All versions of SSCI with support for hexadecimal escape sequences in messages (starting somewhere around Feb 1993) are buggy. The native save/load dialog of SCI32 relies on this defect to render the up and down arrows of the game selector. Fixes Trac#9582.
2016-10-20SCI32: Fix wrong value passed to updateInfoFlagViewVisibleColin Snover
updateInfoFlagViewVisible accepts a property index, not a selector ID. Fixes Trac#9583.
2016-10-20SCI32: Split out detection of features that cross SSCI versionsColin Snover
2016-10-20SCI32: Fix zero-offset exportsColin Snover
Exports with a zero offset are supposed to point to the start of the code block in the script hunk, but they were being ignored. This may also apply to SCI1.1 games, but until that can be verified, this fixes the zero-offset in only SCI32 games for now.
2016-10-16SCI32: Fix crash when clicking around the arterial blockage in SQ6Colin Snover
Thanks @hpvb for the report. Fixes Trac#9615. Closes #850.
2016-10-16SCI32: Fix workaround commentColin Snover