aboutsummaryrefslogtreecommitdiff
path: root/engines/sci/graphics/animate.cpp
AgeCommit message (Collapse)Author
2018-12-03SCI: fix full view remap effect (#1432)Kawa
2018-04-22SCI: Change workaround for PalVary / Animate race conditionWillem Jan Palenstijn
The new approach is to delay kAnimate briefly (with an 68ms timeout) while there is a zero-tick PalVary running, so that it has time to trigger. The previous workaround would immediately process a zero-tick PalVaryInit/PalVaryReverse. This caused problems in QfG3 (bug #10304) where it interfered with PalVaryPause. The previous workaround could also be modified to handle pause/resume, but this new approach should be closer to SSCI's behaviour, which used a timer for a zero-tick PalVary too. This fixes bug #10304, and keeps #5298 fixed too.
2017-03-27SCI: Implement bounds-checked reads of game resourcesColin Snover
2016-09-29SCI: Add prefix to global variable constantsColin Snover
2016-09-29SCI: Replace magic numbers for globals with named constantsColin Snover
2016-02-23SCI: Improve kAnimate fastcast detection, Remove EQ1 hackMartin Kiewitz
- Add "kAnimate fast cast state" to "version" debug command - Make it possible for script patcher signatures to get fully used outside of the regular script patcher - Remove previous fastcast detections and replace them with a signature heuristic - Remove object name checking, when fastcast global is set - Heuristic detects "fast cast" support incorrectly for multilingual KQ5, but it seems the game never sets the global, so it won't matter. KQ5 CD (also SCI1 late) has fastcast support. - Remove hack in GfxView::draw - Add lots of comments to ScriptPatcher class This fixes EcoQuest 1 Floppy showing the anemone on top of the message box (see bug #5170)
2016-02-15JANITORIAL: Typos detected with lintian & grepAlexandre Detiste
2014-05-27ALL: Rename Debugger::DebugPrintf to Debugger::debugPrintf.Johannes Schickel
2014-02-18SCI: Make GPL headers consistent in themselves.Johannes Schickel
2013-04-27SCI: Change wording for bug/further info referencesFilippos Karapetis
2012-06-18SCI: Add setter/getter methods to reg_t'sFilippos Karapetis
No functionality change has been made with this commit. This avoids setting and getting the reg_t members directly, and is the basis of any future work on large SCI3 scripts (larger than 64KB)
2011-10-19SCI: Merged all the code to get/set the NS rectFilippos Karapetis
2011-06-20ALL: Remove trailing whitespacesMax Horn
This tries to make our code a bit more compliant with our code formatting conventions. For future use, this is the command I used: git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
2011-05-25ALL: behaviour -> behaviorMatthew Hoops
2011-05-12GIT: Clean up: Suppress SVN tags, now uselessstrangerke
2011-03-20SCI: Added a new console command, "animate_list" or "al"md5
This shows the current animation list, along with object properties, positions and the scripts they belong to
2011-03-02SCI: Change workaround for hoyle3-demo's rendering orderWillem Jan Palenstijn
This behaviour much more closely matches SSCI.
2011-02-27SCI: Renamed SCI_VERSION_1_EGA to SCI_VERSION_1_EGA_ONLYmd5
This renaming allows us to better distinguish that this version is for games that only had an EGA version, and avoid confusion with newer SCI1 game releases with EGA graphics (e.g. KQ5 EGA). The only game with this SCI version is QFG2, a SCI1 EGA game with a parser. Also, added some games for each SCI version.
2011-02-26SCI: Slight cleanup in the animate codemd5
2011-02-23SCI: Don't name a variable the same as its functionMatthew Hoops
Silences a gcc warning
2011-02-23SCI: Added a workaround for bug #3036763 - "HOYLE3 Demo: Bad Dialog Priorities"md5
2011-02-23SCI: Cleaned up and segmented the animate code in order to make it a bit ↵md5
more readable
2010-12-26SCI: A more efficient solution for bug #3037874 (SCI high CPU usage), which ↵Filippos Karapetis
will hopefully not clash with the speed throttler. This is a more proper fix for bug #3058865, and a partial fix for bug #3127824 svn-id: r55046
2010-10-26SCI: removing unneeded callMartin Kiewitz
was a left-over from debugging svn-id: r53857
2010-10-26SCI: fix gfx issues when giving out cards hoyle4Martin Kiewitz
bit 2 actually triggers special drawing of cels in sierra sci svn-id: r53855
2010-10-26SCI: kAnimate bit 2 is hoyle 4 exclusiveMartin Kiewitz
adjusted comments about that and also renamed the bit, also added additional TODO, because hoyle 4 has special code that gets into action, when bit 0 is not set, but bit 2 is svn-id: r53853
2010-10-26SCI: little cleanup kAnimateMartin Kiewitz
svn-id: r53852
2010-10-26SCI: fixing bug #3091767 by reverting r52820Martin Kiewitz
interpreters should get checked for that hoyle 4 code, comment added svn-id: r53851
2010-10-25SCI: fix comment in kAddToPicMartin Kiewitz
svn-id: r53828
2010-10-24SCI: fixing obvious kAddToPic regressionMartin Kiewitz
caused by r53068, triggered bug #3092840 (SQ5 genetix lab scaled incorrectly when laying course) - thx to digitall for bisect svn-id: r53775
2010-10-10SCI: Fix warning about uninitialized variableMax Horn
svn-id: r53140
2010-10-08SCI: add global scaling again to kAddToPicMartin Kiewitz
fixes regression of r52887 - lb2 actors not scaled correctly bug #3083577 needs to get backported svn-id: r53068
2010-09-25SCI: little optimization in kAddToPicMartin Kiewitz
definitely save to backport, belongs to r52887 svn-id: r52888
2010-09-25SCI: changes to kAddToPicMartin Kiewitz
kAddToPic doesnt do loop/cel fixups, it also doesnt support global scaling and will only set nsRect on scaled Cels, not reusing fill() of kAnimate anymore, but doing those things separately fixes kq6 - 2nd window shown instead of peppermint bush (bug #3070465) should be save to backport svn-id: r52887
2010-09-20Make r52818 general on trunkLars Skovlund
svn-id: r52820
2010-09-20SCI: Handle bit 2 of scaleSignal by not updating nsRect values whenLars Skovlund
it's set. Currently game-specific for Hoyle4; fixes bug #3038424. But other SCI1.1 games should be tested with a general version of this to see whether it fixes relevant bugs. svn-id: r52818
2010-09-05SCI: dont do global scaling on non-scaleable viewsMartin Kiewitz
lb2floppy: scripts get confused in the rat scene, when scaleX/Y are set with applied global scaling. This results in kInitBresen to get called almost endlessly, which results in ego slowing down to a crawl and not being able to reach the upper right exit - fixes bug #3050606 svn-id: r52559
2010-08-29SCI: Throttle the invocations of Engine::shouldQuit()Filippos Karapetis
SCI constantly invoked Engine::shouldQuit(), which in turn called 2 virtual functions. This added a significant overhead, as this was called constantly without any throttling whatsoever. Now, the invocation of shouldQuit() is throttled to be on each frame update (i.e. at a rate of 60fps). Thanks to wjp for profiling this. svn-id: r52431
2010-08-25SCI: adding detection for freddy pharkas "fred"Martin Kiewitz
fixes blop not appearing during intro song, because game thought we were too slow (bug #3051514) svn-id: r52392
2010-08-11SCI: properly doing kAnimate loop/cel fixingMartin Kiewitz
really weird, but it works now. Bug #3037578 (kq5 trunk), bug #3043286 (lb1 knight) svn-id: r52007
2010-08-11SCI: revert r51969Martin Kiewitz
broke laura bow 1, need to figure out whats exactly wrong svn-id: r52004
2010-08-11SCI: kAddToPic only wrote nsRect in sci1.1Martin Kiewitz
fixes regression of r51952 and bug #3042957 svn-id: r51971
2010-08-11SCI: kAnimate invalid loop/cels now correctly fixedMartin Kiewitz
fixes kq5 trunk getting closed again during intro - is actually a script bug that sets cel to some really high number - bug #3037578, may also fix other similar issues svn-id: r51969
2010-08-10SCI: kAddToPic(list) set fixed priority flagMartin Kiewitz
svn-id: r51954
2010-08-10SCI: add scaling support to kAddToPicMartin Kiewitz
fixes laurabow2 bug #3041226 svn-id: r51952
2010-08-10SCI: adding workaround for kq5Martin Kiewitz
when giving the tambourine to the monster - bug #3041262 svn-id: r51950
2010-08-03SCI: adding jones/talkie speed throttler viewMartin Kiewitz
fixes bug #3038989, regression of r51544 svn-id: r51714
2010-08-02SCI: adding non-scaleable view capabilityMartin Kiewitz
fixes laura bow 2 (especially floppy but CD is also affected somewhat by this) svn-id: r51660
2010-07-31SCI: adding detection for benchmark viewsMartin Kiewitz
and enable speed throttler when just one regular cel was drawn, fixes eco quest 2 ego getting light-speed fast in village (bug #3036805) =this could cause regressions like disabled animations in games= svn-id: r51544
2010-07-31SCI: kAnimate - limit update of nsRect when scaledMartin Kiewitz
only set nsRect when being drawn later (scaled only), fixes sq5 instant-death in elevator shaft svn-id: r51534