aboutsummaryrefslogtreecommitdiff
path: root/engines/sci/sound
AgeCommit message (Collapse)Author
2013-09-22SCI: revert fix music start codeMartin Kiewitz
add workaround for eq2 the issue is known, but can't be properly fixed without rewriting the midiparser into a channel specific parser previous commit caused issues in kq5/french and others
2013-09-22SCI: fix music start code fixes eq2 bug #3037267Martin Kiewitz
we start at offset 10 for sound SCI1 games. This is hardcoded in the interpreter. Also removing not handling signals on tick 0. This fixes Eco Quest 2 / Gonzales dancing in room 530. Thanks to wjp for the help.
2013-09-21Merge branch 'master' into sci_midiparserWillem Jan Palenstijn
Conflicts: engines/sci/sound/midiparser_sci.cpp
2013-09-21SCI: fix dataInc signalling fixes bug #3035159m-kiewitz
we set signal in parseNextEvent on dataInc events, which then effectively triggered 2 cues through kDoSoundUpdateCues instead of one. Fixes Freddy Pharkas Ballad intro on floppy + demos
2013-09-21SCI: Handle !fireEvents in processEventWillem Jan Palenstijn
2013-09-21SCI: abbrev. ffs to FE and priority check fixm-kiewitz
2013-09-21SCI: sfx/music priority int16 fixes bug #3615038m-kiewitz
it seems that sound system up till SCI0_LATE uses int16, afterwards it seems they changed to byte main music object (conMusic) in Laura Bow 1 uses -1 as priority. This was truncated to 255 till now, which resulted in many sound effects not getting played, because those used priority 0
2013-09-21AUDIO: Simplify SCI inFastForward flag by moving it to MidiParserWillem Jan Palenstijn
2013-09-21SCI: Move MIDI event processing out of parseNextEventWillem Jan Palenstijn
2013-09-19SCI: Fix too strict assert triggering in LSL5Willem Jan Palenstijn
2013-09-16SCI: longbow intro night rider fix (with help of wjp) - seems to fix bug 3489094m-kiewitz
2013-09-15SCI: fix tabs in last commitm-kiewitz
2013-09-15SCI: disable signals when resuming music, so that debugger will work ↵m-kiewitz
properly for longbow intro
2013-07-19SCI: Add FIXMEWillem Jan Palenstijn
2013-07-08SCI: Rewrite the song loop comments in commit 6fa668e to make more senseFilippos Karapetis
2013-07-08SCI: Add some comments a possible TODO regarding song loopingFilippos Karapetis
2013-07-07SCI: Fix bug #3614566 - "LSL6: ScummVM locks up at Electro-Shock room"Filippos Karapetis
We now do the jumpToTick() for hold events after waiting for the delta of the current event, like we do for the signal set events. This keeps the fixes for the hold timings in QFG3, while not breaking LSL6. Many thanks to wjp for pinpointing the actual cause of the issue.
2013-06-19SCI: Implement the 4-param version of kDoSoundSendMidi - bug #3614447Filippos Karapetis
Many thanks to wjp for his help with disassembly
2013-06-18SCI: Add note about LSL1vga DoSoundSendMidiWillem Jan Palenstijn
2013-05-01SCI: Silence some false positive warnings - CID 1003539, 1003540, 1003541, ↵Filippos Karapetis
1003542
2013-04-28SCI: Change wording for a function referenceFilippos Karapetis
2013-04-27SCI: Change wording for bug/further info referencesFilippos Karapetis
2013-04-20SCI: Report sound stream loading errorsWillem Jan Palenstijn
2013-04-19SCI: Replace workaround for bug #3605269 by script patchWillem Jan Palenstijn
2013-04-17SCI: Fix confusing use of strncpyWillem Jan Palenstijn
2013-04-16SCI: Don't suppress loop delta in SCI1 midiWillem Jan Palenstijn
This fixes bug #3293354.
2013-04-16SCI: Don't suppress end-of-track delta in SCI0 midiWillem Jan Palenstijn
This fixes the main part of bug #3487090. This seems to be a conversion error from SCI1's channel mixing to SCI0's channel filtering code.
2013-04-07SCI: Add signal/fade related CHECKMEWillem Jan Palenstijn
2013-04-06SCI: Minor cleanupWillem Jan Palenstijn
(Thanks waltervn)
2013-04-06SCI: Further clarify commentWillem Jan Palenstijn
2013-04-06SCI: Clarify commentWillem Jan Palenstijn
2013-04-06SCI: Revert "Fixed fading-related bugs #3267956 and #3041738"Willem Jan Palenstijn
This reverts commit bfef0f5a6fabdef5bb42cffd8b078d4511cf2a80.
2013-04-06SCI: Re-initialize more of MusicEntry on playWillem Jan Palenstijn
This fixes bug #3267956.
2013-04-06SCI: Notify scripts of completed fade when aborting itWillem Jan Palenstijn
This tweaks a fix/workaround (commit 96540686) for bugs #3266480 and #3041738. Also add CHECKME to verify the accuracy of this workaround further. This fixes the regressions #3291115, #3555404, #3596335 and #3610063.
2013-04-06SCI: Revert "Added a more specific workaround for bug #3267956.[...]"Willem Jan Palenstijn
This reverts commit 5654e1257551bf176c7fd06c756612bec3d79033. Conflicts: engines/sci/sound/soundcmd.cpp
2013-04-06SCI: Revert "Clarify comment from rev 5654e12 further"Willem Jan Palenstijn
This reverts commit 9f74a6eda2355bb09b9b963be41509ed67016a6c.
2013-04-06SCI: Revert "Fix script bug #3555404 - "SCI: KQ6 Spider Scene Game Freeze""Willem Jan Palenstijn
This reverts commit 8524ebd699254a6786033f0e41b9a45c563feb11.
2013-04-06SCI: Revert "Properly fix bugs #3267956 and #3605377"Willem Jan Palenstijn
This reverts commit 17ca8d14b1e0d1960485029878c728ef4d6d6132, except for a minor unrelated change to the workaround for bug #3605269 Conflicts: engines/sci/sound/soundcmd.cpp
2013-04-06SCI: Revert "Add a hack to fix bug #3596335"Willem Jan Palenstijn
This reverts commit f019d5a4881c8ee42fa36ef0613d9e82b3b36297.
2013-04-05SCI: Revert "Add a more generic solution for the problem found in bug #3605269"Willem Jan Palenstijn
This reverts commit c6320a28e483e52b489cae8e86774008e030492b. SSCI does not interpret signals on other channels than 15. Conflicts: engines/sci/sound/soundcmd.cpp
2013-04-04SCI: Add a hack to fix bug #3596335Filippos Karapetis
Game scripts are waiting indefinitely for a song, thus we change its dataInc selector to prevent that from happening
2013-04-04Properly fix bugs #3267956 and #3605377Filippos Karapetis
SCI: Only stop after fading, if the song to be faded is faded down. Also, reset the song signal when fading starts. It was set to -1 when fading started in bug #3267956, thus it stopped immediately.
2013-04-02SCI: Add a more generic solution for the problem found in bug #3605269Filippos Karapetis
We now accept signals from all channels if channel 15 is missing. This is a very rare edge case, but our behavior is now somewhat closer to what the original interpreter seems to be doing. Mordack's appearance animation is now synced properly. The more generic workaround works for songs 1840 and 1843, but not for 1849, which is still problematic and we still resort to manually changing its dataInc selector
2013-04-01SCI: Set the song's sound queue signal to -1 when stopping a sound, like ↵Filippos Karapetis
SSCI does Previously, we set the signal of the sound objects themselves to -1, but set the sound queue's signal to 0. This now matches the original behavior.
2013-04-01SCI: Fix bug #3605269 - "SCI: KQ5 Windows CD - Game Hangs Before Final Battle"Filippos Karapetis
This is caused because songs 1840, 1843 and 1849 are all missing their special SCI signaling channel (channel 15), so the game scripts wait indefinitely for signals which are never set
2013-03-29SCI: Stop and clear sounds that have no data. Fixes an issue in KQ6 MacFilippos Karapetis
Thanks to waltervn and clone2727 for the original patch. Tested LSL5 with this change, and the problematic sound in the mud wrestling scene is handled correctly
2013-03-27SCI: Remove some useless checks in the MIDI driverFilippos Karapetis
2013-01-29SCI: Use correct priority selector in SoundCmdWillem Jan Palenstijn
It was using 'pri' instead of 'priority', apparently due to a selector number->name translation error from 544daa5c31. Thanks to waltervn for spotting this.
2012-10-22SCI: Fix bug #3578335 - "SCI: Mixed-Up Mother Goose EGA - crash upon ↵Filippos Karapetis
choosing kid" In several SCI0 games, the parameter to kDoSoundFade can be null. We handle that case, instead of adding individual workarounds per game
2012-09-26JANITORIAL: Remove trailing whitespaces.Johannes Schickel
Powered by: git ls-files "*.cpp" "*.h" "*.m" "*.mm" | xargs sed -i -e 's/[ \t]*$//'