aboutsummaryrefslogtreecommitdiff
path: root/engines/sci
AgeCommit message (Collapse)Author
2014-01-15ALL: Remove optimization unstable code on checking for null after new.D G Turner
These issues were identified by the STACK tool. By default, the C++ new operator will throw an exception on allocation failure, rather than returning a null pointer. The result is that testing the returned pointer for null is redundant and _may_ be removed by the compiler. This is thus optimization unstable and may result in incorrect behaviour at runtime. However, we do not use exceptions as they are not supported by all compilers and may be disabled. To make this stable without removing the null check, you could qualify the new operator call with std::nothrow to indicate that this should return a null, rather than throwing an exception. However, using (std::nothrow) was not desirable due to the Symbian toolchain lacking a <new> header. A global solution to this was also not easy by redefining "new" as "new (std::nothrow)" due to custom constructors in NDS toolchain and various common classes. Also, this would then need explicit checks for OOM adding to all new usages as per C malloc which is untidy. For now to remove this optimisation unstable code is best as it is likely to not be present anyway, and OOM will cause a system library exception instead, even without exceptions enabled in the application code.
2014-01-06SCI: Fix memory leakWillem Jan Palenstijn
Thanks to digitall for testing.
2013-12-31SCI: Remove no longer necessary hackWillem Jan Palenstijn
2013-12-31SCI: Rewrite MIDI channel remappingWillem Jan Palenstijn
This adds MIDI state tracking to allow channels to be temporarily unmapped and later re-mapped when there are free device channels available again.
2013-12-31SCI: Reduce indentation depthWillem Jan Palenstijn
2013-12-26SCI: remove undither option for SCI1early+ gamesMartin Kiewitz
2013-12-26SCI: fix sci1early+ ega picture issuesMartin Kiewitz
also remove hacks for kq5ega + sq4ega
2013-12-26SCI: floodfill reverted, was sci1early differenceMartin Kiewitz
fixes sq4 floppy properly
2013-12-24SCI: portraits cleanup + show base picture at endMartin Kiewitz
2013-12-24SCI: injecting "dual" view into King's Quest 6 CDMartin Kiewitz
for dual mode (text+speech at the same time)
2013-12-24SCI: injecting "dual" view into Laura Bow 2 CDMartin Kiewitz
for dual mode (text+speech at the same time)
2013-12-24SCI: workarounds / new bug ids in commentsMartin Kiewitz
2013-12-24SCI: change floodfill fix for sq4Martin Kiewitz
behaviour wasn't changed in SCI1, instead it seems that SSCI draws overlays to separate memory and then copies them over. Previous commit caused regression in qfg1vga (funny room)
2013-12-23SCI: change floodfill to fix sq4 ship taking offMartin Kiewitz
fixes bug #6446
2013-12-22SCI: readded kq6 stepmother patch for dual modeMartin Kiewitz
2013-12-22SCI: LB2CD patch: remove audio mode reset codeMartin Kiewitz
on init/reset the game resets the audio mode to "speech", which would make it impossible to watch the intro using "dual mode"
2013-12-22SCI: improved lb2+kq6 patches (new speech state)Martin Kiewitz
adds a third button state to the game menu this state is "dual mode" (audio+text at the same time) currently uses the "speech" graphic CD versions of Laura Bow 2 + King's Quest 6 will now always get patched
2013-12-21SCI: improved one of the kq6 audio+text patchesMartin Kiewitz
KQPrint windows now get closed automatically when in audio+text mode
2013-12-20SCI: final script patcher cleanupMartin Kiewitz
2013-12-20SCI: another kq6 patch for text+audioMartin Kiewitz
fixes cassima textboxes during the ending
2013-12-20SCI: script patcher comment adjustMartin Kiewitz
2013-12-20SCI: even more script patcher cleanupMartin Kiewitz
2013-12-20SCI: script patcher cleanupMartin Kiewitz
2013-12-19SCI: kq6 script patch to fix "drink me" bottleMartin Kiewitz
fixes bug #5252
2013-12-18SCI: debug code to print out kq6 raw lipsync dataMartin Kiewitz
2013-12-18SCI: another kq6 patch for audio+text supportMartin Kiewitz
fixes dialog of man in robe complaining about mints in pawn shop
2013-12-15SCI: patch SQ4 bug with throwing at sequel policeMartin Kiewitz
SQ4 floppy only, Sierra's official patch didn't fix it properly
2013-12-15SCI: pq1vga script patch to fix map restore bugMartin Kiewitz
fixes bug #5016
2013-12-14SCI: Make second pass when loading objectsWillem Jan Palenstijn
This is because objects may be loaded before their base objects, which causes initBaseObject to fail for SCI0. Script::initializeObjectsSci0 already did this, but SegManager::saveLoadWithSerializer did not when calling initBaseObject after loading a savegame.
2013-12-11SCI: Add detection for Torin MacMatthew Hoops
2013-12-11SCI: rave support (KQ6 hires portrait lip sync)Martin Kiewitz
Thanks to wjp and [md5] for helping
2013-12-10SCI: Add handling for the RAVE resource type, found in KQ6CDFilippos Karapetis
This contains the sync data in the Windows version of KQ6CD. Note that currently the sync36 resource is 2 bytes bigger (it contains 2 bytes from the RAVE resource). Some test code has also been added to dump the RAVE sync resources
2013-12-08SCI: Revert "+xx" to "+ xx" changes in 6f2e88136b20fb02d38cd594611c865f44fe8e1a.Johannes Schickel
After discussing with m_kiewitz that these have been intentional.
2013-12-08SCI: Fix formatting in engine/script_patches.cpp.Johannes Schickel
Powered by astyle and some manual work to avoid breaking multiple statement lines into multiple lines consisting of single statements.
2013-12-08SCI: Make all script patch related global data static.Johannes Schickel
2013-12-08SCI: Constify selectorNameTable.Johannes Schickel
2013-12-08SCI: Make all global script patch signatures const.Johannes Schickel
2013-12-08SCI: improve kq6 audio+text patch to include guard2Martin Kiewitz
2013-12-08SCI: only apply audio+text patch to KQ6 CD+LB2 CDMartin Kiewitz
2013-12-08SCI: sci.cpp updated b/c KQ6 audio+text supportMartin Kiewitz
2013-12-08SCI: another script patch for KQ6 text+audio supportMartin Kiewitz
fixes hires issues
2013-12-07SCI: more patches for KQ6 audio+text supportMartin Kiewitz
2013-12-07SCI: added kq6 patch for audio+text, not 100% doneMartin Kiewitz
2013-12-04Merge branch 'master' of github.com:scummvm/scummvmMartin Kiewitz
2013-12-04SCI: script patcher is now a separate classMartin Kiewitz
2013-11-24BUILD: Remove need for engine.mk in each engine directory.D G Turner
Each engine now only has to provide a single configure.engine file adding the engine into the configure script, which then produces the required other files automatically.
2013-11-24BUILD: Remove need for engine-plugin.h in engines.D G Turner
This is now generated automatically by the configure script from the engine directory names.
2013-11-24BUILD: Split engines/plugins_table header down to a file per engine.D G Turner
This is the third and final commit enabling fully pluggable engines. Now providing an engine folder contains a configure.engine, engine.mk and engine-plugin.h file, it will be picked up automatically by the configure script.
2013-11-24BUILD: Split engines.mk down to a single file per engine.D G Turner
This is the second part of allowing engines to be added dynamically. Each folder in engines/ which must contain a file named "engine.mk" containing the make definitions for that engine.
2013-11-24BUILD: Split configure.engines down to a single file per engine.D G Turner
This is the first part of allowing engines to be added dynamically. They are placed into a folder in engines/ which must contain a file named "configure.engine" to add the engine, which is pulled into the top level configure script automatically.