Age | Commit message (Collapse) | Author |
|
|
|
These are regressions from c05cb7f3bbcf4d64d4a938e0eb42065d8f3d3038. They were
caused by VirtualScreen::getPixels differing from Surface::getBasePtr and I
accidently used the former in some cases in the conversion.
I also fixed a bug in debugger.cpp which exchanged x and y.
|
|
|
|
|
|
Powered by:
git ls-files "*.cpp" "*.h" "*.m" "*.mm" | xargs sed -i -e 's/[ \t]*$//'
|
|
|
|
(LOOM mouse cursor was broken in b1cb88ddc25da64772bbba253bd2210678189ace)
|
|
This should fix incorrect text colors in some scenes.
|
|
|
|
(as discussed with LordHoto this should rather be handled in the engine)
|
|
|
|
Also move font rom loader to graphics/sjis and make the necessary changes there.
|
|
|
|
drawChar is overloaded in FontSJIS. One takes a "Surface &" as first
parameter another one "void *", they furthermore have the exact same
number of required parameters. The one "void *" just had a few extra
parameters with default values. This resulted in a bug in SCUMM, where
"VirtScreen *" (a subclass of Surface) was passed instead of "VirtScreen &"
and thus the method taking "void *" was incorrectly used.
To make it easier to spot such bugs in the future I just removed the default
values and thus disallow such calls.
|
|
This tries to make our code a bit more compliant with our code formatting
conventions. For future use, this is the command I used:
git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
|
|
(Wrong character height for non-SJIS chars which messed up the inventory scrolling arrows)
|
|
(another attempt to fix SCUMM FM-TOWNS for ANDROID)
|
|
|
|
|
|
|
|
Uglify more code to fix compilation for DS
Only compile-tested
|
|
svn-id: r55268
|
|
(could cause invalid memory access in MI1)
svn-id: r54079
|
|
svn-id: r53725
|
|
(fixes MI1 character talk text)
svn-id: r53704
|
|
svn-id: r53617
|
|
(used in the MI1 circus scene after Guybrush gets shot out of the cannon)
svn-id: r53616
|
|
(improves MI1 intro)
svn-id: r53597
|
|
(MI1 intro is still not right)
svn-id: r53558
|
|
- made use of LordHotos graphics/sjis code to reduce code duplication
- japanese mode for version 3 and 5 works fine now with few exceptions (some line spacing glitches in MI1 intro etc.)
svn-id: r53554
|
|
svn-id: r53523
|
|
svn-id: r53519
|
|
svn-id: r53518
|
|
svn-id: r53510
|
|
svn-id: r53196
|
|
svn-id: r53113
|
|
svn-id: r53033
|
|
This commit should fix at least the following bugs/feature requests: #1032859, #1252088, #1055391, #1315968, #1315938, #1742106, #812891.
The FM-Towns version of Scumm games use a mixed graphics mode with 2 layers (one with 32767 colors and one with 16 colors). Among other things I have added a screen output class which emulates this dual layer approach which allows specific hardware effects like enabling and disabling layers (e.g. in the voodoo priestess scene in MI1).
Old savegames (saved before this update) will load, but you’ll encounter palette glitches in the verb/inventory screen, since the 16 color palette for layer 2 is not contained in your savegame. This will be true at least for version 5 games. Certain scene change actions (which require the verb/inventory part to be redrawn) might correct this (e.g. try looking at the treasure map in MI1 and closing it). Version 3 games should be okay, since they use a static text palette which is never changed and which will be reset after loading a savegame.
This update requires a USE_RGB_COLORS setting for proper operation. 8 bit users will get a warning that they’ll have to expect palette glitches . Apart from that the engine in 8 bit mode should not only still work okay, but also benefit from some of the other (non palette related) improvements (e.g. bug #1032859 should be fixed even in 8 bit mode).
Japanese font drawing hasn’t been improved much yet. This will be a separate task.
svn-id: r52966
|
|
svn-id: r50375
|
|
svn-id: r49191
|
|
In this case, it was always a break after a return in a switch case. There are
similar cases which cppcheck didn't detect, and a couple of cases where we have
a break after a continue in a switch case (where the continue refers to an
outer loop), but I didn't touch those. Not yet, at least.
svn-id: r48218
|
|
svn-id: r47541
|
|
svn-id: r46805
|
|
svn-id: r46796
|
|
svn-id: r46771
|
|
present to get to the correct font data.
svn-id: r46100
|
|
svn-id: r46080
|
|
svn-id: r46079
|
|
svn-id: r46076
|
|
svn-id: r46064
|