Age | Commit message (Collapse) | Author |
|
|
|
|
|
It's much better now and hopefully quite close to the original when it comes
to the music part. The intro music of Loom and Monkey Island 1 EGA sounds fine
to me now at least.
|
|
The game scripts detected Yellow or Red variants based on what binary was present. That could potentially cause problems with a Mac dump in case someone dumped into MacBinary format.
|
|
|
|
We handle command 0x80 incorrectly, which results in sound effects never
looping. This is the cause for bug #2027877 for example. I add this FIXME
since it is (probably) non-trivial to fix and so it won't be forgotten.
|
|
Add support for Bink video to SCUMM HE
|
|
Formerly we tried to play back a ROL resource on AdLib in this case, since the
game does not contain a ADL resource for the sound the game tries to play here.
The original does not exhibit this behavior, thus I changed it to behave the
same now.
Big thanks to eriktorbjorn for noticing and finding the cause of this problem.
Also thanks to Kirben for checking how the original behaved and _athrxx for
checking the FM-Towns version of Indy4.
|
|
|
|
iMuse instrument.
|
|
|
|
|
|
|
|
|
|
Based on a patch presented in the bugreport. Fixes several bugs
connected with calcualting IQ points in Amiga versions of Indy3.
|
|
|
|
Discussion can be found here: https://github.com/scummvm/scummvm/pull/54
|
|
|
|
|
|
|
|
Formerly we ever only used the lower 4 bit of the priority setting for a new
part. The original used a full 8 bit setting though (based on the Indy4 PC
Speaker output driver). This fixes missing notes in the Indy4 intro with PC
Speaker output.
This might affect other outputs too! And could cause regressions in case other
outputs implemented priority settings differently.
|
|
Now we only output a new frequency if a new channel was selected or a new
output frequency has to be send. This makes the sound much more like in
DOSBox. This is not present in the original, but since our timings are
different this should make up for that.
|
|
Thanks to eriktorbjorn for catching this.
|
|
|
|
Albeit the code is marked as a hack inside the source, the original behaved
exaclty the same. If the code is removed the PC Speaker output will miss notes,
since unlike the original we only output to parts, which have an instrument set
up.
|
|
This fixes the melody in Indy4's intro with the PC Speaker output.
|
|
|
|
(as discussed with LordHoto this should rather be handled in the engine)
|
|
|
|
Also move font rom loader to graphics/sjis and make the necessary changes there.
|
|
|
|
This is *not* complete yet.
|
|
|
|
(static array were not reset to NULL after being freed and therefore didn't get reallocated on restart)
|
|
|
|
|
|
Fixes Smacker videos in Blue's Birthday
|
|
|
|
drawChar is overloaded in FontSJIS. One takes a "Surface &" as first
parameter another one "void *", they furthermore have the exact same
number of required parameters. The one "void *" just had a few extra
parameters with default values. This resulted in a bug in SCUMM, where
"VirtScreen *" (a subclass of Surface) was passed instead of "VirtScreen &"
and thus the method taking "void *" was incorrectly used.
To make it easier to spot such bugs in the future I just removed the default
values and thus disallow such calls.
|
|
This fixes a potential problem with passing char values that would be sign-extended and yield unexpected results.
See http://msdn.microsoft.com/en-us/library/ms245348.aspx
|
|
The enum is only used inside the SCUMM engine so it is rather pointless to
keep it in common/util.h right now. Also if we really want it in some common
place it should probably be better in graphics/ too.
|
|
This tries to make our code a bit more compliant with our code formatting
conventions. For future use, this is the command I used:
git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
|
|
(Wrong character height for non-SJIS chars which messed up the inventory scrolling arrows)
|
|
(this avoids isssues when using savegames from different ports with different 16bit color modes)
|
|
(regression from 068b4a5351a5574dbfac6acff5776a0071f3f2dd)
|
|
(fixes possible issue in LOOM PCE)
|
|
(changed behavior of USE_ARM_GFX_ASM define)
|
|
|
|
(another attempt to fix SCUMM FM-TOWNS for ANDROID)
|
|
|