aboutsummaryrefslogtreecommitdiff
path: root/engines
AgeCommit message (Collapse)Author
2018-10-16LASTEXPRESS: dynamic adjusting of sound volumeEvgeny Grechnikov
Now it works just like in the original game, including fading where it is applicable (e.g. in a passengers list if closing the list while a sound is playing). By the way, p2s sequence is known as http://oeis.org/A000265 , p1s is 4 - A007814, and p2s[i]/2**p1s[i] is just i/16. It is time to get rid of these arrays.
2018-10-16LASTEXPRESS: support for delay-activated soundsEvgeny Grechnikov
Not very obvious, but noticeable e.g. when knocking on harem doors. I suppose this is the problem that wiki describes as "improper triggering of actions on sound end".
2018-10-16LASTEXPRESS: Remove Engine Specific All Debug Level.D G Turner
This is replaced by the global "all" option for debugflags and defining this triggers a warning about the conflict at runtime.
2018-10-16LASTEXPRESS: Fix Compiler Warning in Sound Code.D G Turner
The SoundFlag type is an enumeration which have a default underlying type of unsigned int in most case. Thus comparing this to -1 causes a compiler warning. Since the default entity sound flag type is 0xFFFF... which is equivalent to -1, then replacing this with the correct enum symbol fixes the issue and should result in the correct behaviour. Examination of the resulting code line seems to confirm that this is the correct expected logic.
2018-10-16LASTEXPRESS: drop sound threadEvgeny Grechnikov
The backend runs its own sound thread anyway, with the corresponding bookkeeping that we use. We don't need yet another sound thread, and it is always nice to not have something that could change our structures from underneath us.
2018-10-16LASTEXPRESS: fix race condition in sound codeEvgeny Grechnikov
SoundEntry::play() calls StreamedSound::setFilterId(), StreamSound::setFilterId() requires the underlying reference to be alive. SoundQueue::handleTimer() checks that the stream is still alive by calling SoundEntry::isFinished(). However, if the stream is finalized just between calls to SoundEntry::isFinished() and SoundEntry::play(), the sound mixer frees the stream leading to use-after-free in setFilterId(). Turn off the automatical disposing, delete the stream in SoundEntry::~SoundEntry().
2018-10-15SCI: Fix LB2 back rub east entrance bug #10729sluicebox
Fixes a lockup in the original game
2018-10-14LASTEXPRESS: Fix compilation with some compilersThierry Crozat
2018-10-14LASTEXPRESS: refactor sound flagsEvgeny Grechnikov
Merge SoundFlag and SoundStatus into a single enum; SoundEntry::setupStatus just casts one to another. Keep only definitions of bits in SoundFlag; drop compound flags like kFlagSteam = kSoundTypeAmbient | kSoundFlagLooped | kVolume7, use ORed simple flags in calls; change the signature of SoundManager::playSoundWithSubtitles to use uint32 instead of SoundFlag to avoid excess casting. Add meaningful names to flags; add some comments. Get rid of endian-unsafe SoundStatusUnion. Fixes an issue with big-endian hosts. No changes in behaviour on little-endian hosts.
2018-10-14SCI: Fix LB2 'Bugs With Meat' lockup, bug #10730sluicebox
Fixes a lockup in the original game
2018-10-14LASTEXPRESS: fix constants in sound serializerEvgeny Grechnikov
Wrong enum member used: (status & 0x7000000) should be checked against 0x3000000, not against 3 (this is a check of sound type to skip menu sounds in savefiles). Activate delay should not be compared with sound volume; comparison with 0x8000000 is just a sanity check against overflow.
2018-10-12PINK: removed unnecessary G keyAndrei Prykhodko
2018-10-12PINK: added missing sequencer update in Moving stateAndrei Prykhodko
2018-10-11AGI: Add Detection Entry for AGI Combat (Beta).D G Turner
This fixes bug Trac #10739.
2018-10-11AGI: Add Detection Entry for Sarien Test Demo.D G Turner
This fixes bug Trac #10740.
2018-10-11AGI: Clamp Graphics Blit into Screen Area.D G Turner
Some games, especially fangames appear to blit to co-ordinates outside the screen area, which caused an assertion in the graphics backend. To prevent this and allow further debugging in these cases, we clamp this to the screen area. Note that there are several other locations which do backend graphics calls, so this may need to be applied elsewhere in the general case. This fixes bug Trac #10736.
2018-10-10AGI: Fix ScummVM Quit if Return To Launcher from AGI Quit Dialog.D G Turner
This is bug Trac #10735.
2018-10-09CGE2: Allow Triggering of Carpet Workaround from Debug Console.D G Turner
This allows the recovery of saved games with the dead-end condition from bug Trac #6842.
2018-10-09CGE2: Add Script Workaround for Clothes Horse Carpet Bug.D G Turner
This now allows the Carpet to be placed and removed from the Clothes Horse repeatedly, thus avoiding the dead-end when you do not beat the Carpet with the Racket on first attempt. This is bug Trac #6842.
2018-10-08SCI: Add Detection Entry for Hoyles Classic Games for Laptops.D G Turner
This is basically Hoyle 5, but may be missing the main menu so might require separate entries for each game i.e. cfg files. This is from bug Trac #10676.
2018-10-08SCI: Fix LB2CD Yvette/Tut murderless messagesluicebox
Fixes wrong message in cd versions, bug #10724
2018-10-08SCI: Fix LB2 Yvette/Tut premature murder messagesluicebox
Fixes wrong message in floppy versions, bug #10723
2018-10-07MOHAWK: Show the closed gate on the 3rd channelwood levelBastien Bouclet
The original game scripts are missing a delay. Fixes #10727.
2018-10-06SCI: Add Detection Entry for Space Quest 3 Variant.D G Turner
2018-10-05SCI: Add Detection Entry for Codename ICEMAN Variant.D G Turner
This is from bug Trac #10678.
2018-10-05MOHAWK: Add Detection Entries For Two LB Game Variants.D G Turner
These are from bug Trac #6745 "MOHAWK: Two unknown Living Book game variants..."
2018-10-04MOHAWK: Add Detection Entry for Spanish Variant of Arthurs Birthday.D G Turner
This is from Bug Trac #10705.
2018-10-03COMPOSER: Add Detection Entry For Darby French Mac Variant.D G Turner
This is from Trac #10399.
2018-10-02SCUMM: MONKEY2: Skip extra code on FMTOWNS, fixes bug #2223Ben Castricum
2018-10-02SCI: Script patch for LB2 act 4 init, bug #10716sluicebox
Fixes a lockup in the original game
2018-10-02GOB: Add Detection Entry for PCGames Ween Demo.D G Turner
This is from Trac #10725, and the demo appears to be multilingual at least in terms of English and German, so adding two entries.
2018-09-29SCI: Script patch for LB2 armor inset, bug #10709sluicebox
Fixes missing messages in floppy version
2018-09-26FULLPIPE: Fix For Memory Leak When Exiting Through Game Menu.D G Turner
This fixes bug #10398 ("FULLPIPE: memory leak when exiting via in-game menu (not gmm)").
2018-09-26STARTREK: Add Detection Entry for English Demo.D G Turner
This can be found at: https://archive.org/details/StarTrek25thAnniversaryDemo
2018-09-25STARTREK: Add Detection Entry For German Version of Judgement Rites.D G Turner
2018-09-24LASTEXPRESS: Fix GCC Enum Comparison Mismatch Warning.D G Turner
This was previously comparing the Object Model to the Object Enum. This has been corrected, but should have no functional change as the underlying enum value of 1 is identical for both symbols.
2018-09-24LASTEXPRESS: Fix GCC WarningsD G Turner
These were for missing parentheses to clarify logical expressions.
2018-09-24LASTEXPRESS: more fixes in NPC logicEvgeny Grechnikov
2018-09-21SCI: Script patch for LB2 desk lamp, bug #10706sluicebox
Fixes a broken message in floppy version
2018-09-16WINTERMUTE: Flush ConfMan to disk on every change (#1314)lolbot-iichan
* WINTERMUTE: Flush ConfMan to disk
2018-09-16SCI: Script patch for LB2 crate room bug #10701sluicebox
Fixes a lockup in the original game
2018-09-15GOB: Correct build breakage for DS/PSP2 from previous commit.D G Turner
2018-09-15GOB: fixed missing member initializationMartin Gerhardy
2018-09-14LASTEXPRESS: Add Missing End Markers to Detection Entry File Lists.D G Turner
This omission might have caused detection issues, but unlikely to cause crashes.
2018-09-14LASTEXPRESS: added detection entry for gog releaseMartin Gerhardy
2018-09-13DIRECTOR: fixed warning with gcc 8.2Martin Gerhardy
engines/director/lingo/lingo-funcs.cpp: In member function ‘void Director::Lingo::func_goto(Director::Datum&, Director::Datum&)’: engines/director/lingo/lingo-funcs.cpp:194:39: warning: type qualifiers ignored on cast result type [-Wignored-qualifiers] cleanedFilename += (const char) *p;
2018-09-13SWORD2: fixed compiler warning with gcc 8.2Martin Gerhardy
engines/sword2/screen.cpp: In member function ‘void Sword2::Screen::rollCredits()’: engines/sword2/screen.cpp:1121:102: warning: cast from type ‘const char*’ to type ‘byte*’ {aka ‘unsigned char*’} casts away qualifiers [-Wcast-qual] creditsLines[i]->sprite = _vm->_fontRenderer->makeTextSprite((byte *)creditsLines[i]->str.c_str(), 600, 14, _vm->_speechFontId, 0);
2018-09-13LASTEXPRESS: fixed warnings with gcc 8.2Martin Gerhardy
engines/lastexpress/entities/alexei.cpp: In member function ‘void LastExpress::Alexei::standingAtWindow(const LastExpress::SavePoint&)’: engines/lastexpress/entities/alexei.cpp:772:49: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ engines/lastexpress/entities/chapters.o engines/lastexpress/entities/august.cpp: In member function ‘void LastExpress::August::function21(const LastExpress::SavePoint&)’: engines/lastexpress/entities/august.cpp:672:4: warning: this statement may fall through [-Wimplicit-fallthrough=] switch(params->param5) { ^~~~~~ engines/lastexpress/entities/august.cpp:694:3: note: here case 9: ^~~~
2018-09-11LASTEXPRESS: more fixes in NPC logicEvgeny Grechnikov
2018-09-09MOHAWK: RIVEN: Don't allow saving from the GMM if no game is startedBastien Bouclet