aboutsummaryrefslogtreecommitdiff
path: root/engines
AgeCommit message (Collapse)Author
2017-12-04XEEN: Fix ground tile rendering in automap dialogPaul Gilbert
2017-12-03XEEN: Fix Coverity warningsPaul Gilbert
2017-12-03XEEN: Fix empty patch in automap dialog contentsPaul Gilbert
2017-12-03ALL: Remove obsolete register keywordColin Snover
The register keyword was deprecated from the C++11 standard, <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4193.html#809>, and removed from the C++17 standard, <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2015/n4340>, so cannot exist in a well-formed C++17 program. It has never done anything in GCC <https://gcc.gnu.org/ml/gcc/2010-05/msg00113.html> and because of the way it is specified in the standard, it is “as meaningful as whitespace” <http://www.drdobbs.com/keywords-that-arent-or-comments-by-anoth/184403859>. The one remaining use of the register keyword is in the DS backend, where it is used to create a local register variable using the non-standard GCC Extended Asm feature. Closes gh-1079.
2017-12-03BASE: Remove bad casts between incompatible Plugin typesColin Snover
Previously, a C-style cast was used to convert a Common::Array<Plugin *>, populated with pointers to StaticPlugin and DynamicPlugin instances, to a Common::Array<PluginSubclass<T> *>, but PluginSubclass<T> is a *sibling* class to StaticPlugin/DynamicPlugin, so this cast was invalid and the results undefined. The methods for retrieving subclasses of plugins can't be easily changed to just generate an array of temporary wrapper objects that expose an identical API which dereferences to the preferred PluginObject subclass because pointers to these objects are retained by other parts of ScummVM, so the wrappers would needed to be persisted or they would need to just re-expose the underlying Plugin object again. This indicated that a way to solve this problem is to have the callers receive Plugin objects and get the PluginObject from the Plugin by explicitly stating their desired type, in a similar manner to std::get(std::variant), so that the pattern used by this patch to solve the problem. Closes gh-1051.
2017-12-03XEEN: Fix drawing outer frame for automap dialogPaul Gilbert
2017-12-03XEEN: Cleanup of window opening & closingPaul Gilbert
2017-12-03FULLPIPE: Renames in ExCommandEugene Sandulenko
2017-12-03FULLPIPE: Added more debug output to the class loadingEugene Sandulenko
2017-12-03SCI: Avoid buffer overflow in amigamac sound driverWillem Jan Palenstijn
By default, frac_t is interpreted as signed. The resulting range isn't large enough to store offsets, so we interpret it as unsigned here instead. Fixes a crash in QfG1/Mac where instrument->loop_size is 49457.
2017-12-01SCUMM: Fix array overflow writing var when no current script is setColin Snover
This situation is triggered normally when _currentScript is 0xFF, but it could potentially also happen if _currentScript is some other number >= NUM_SCRIPT_SLOT, so the check is a bit more conservative than it might appear to need to be.
2017-12-01SCUMM: Fix signed integer overflow reading default v70HE cursorColin Snover
2017-12-01SCUMM: Fix buffer overflow reading default v70HE cursorColin Snover
2017-12-01SCUMM: Fix possible return of garbage valuesColin Snover
2017-12-01SCUMM: Fix UB shifting negative integers in ActorColin Snover
2017-12-01SCUMM HE: Fix UB shifting negative integersColin Snover
2017-12-01SCI: Partially clean up SCI16 video playback codeColin Snover
2017-12-02FULLPIPE: Fix bug #10317: Save game metadata is missingEugene Sandulenko
2017-12-01FULLPIPE: Fix bug #10325: New game does not put back already picked up itemsEugene Sandulenko
2017-12-01FULLPIPE: Fix bug #9673: Unable to move after loading a save from the title ↵Eugene Sandulenko
screen
2017-12-01FULLPIPE: Fix bug #9672: "Several inventory items highlighted at the same time"Eugene Sandulenko
2017-11-30XEEN: Added enum for consumable types and party/bank usePaul Gilbert
2017-11-29XEEN: Refactor FontSurface as ancestors of Window, not ScreenPaul Gilbert
This refactoring allowed Screen to now simply derive from Graphics::Screen, and several duplicated methods could be removed.
2017-11-29XEEN: Create Windows class to hold the windows arrayPaul Gilbert
2017-11-29XEEN: Split Window class into it's own filePaul Gilbert
2017-11-28SCI32: Fix crash starting KQ7 demoColin Snover
Fixes Trac#10343.
2017-11-27FULLPIPE: Properly cleanup menu after quittingEugene Sandulenko
2017-11-27FULLPIPE: Attempt to crash when calling paletteless scenesEugene Sandulenko
2017-11-27SCUMM: Revert skipping of MM C64 demo original save screen display attemptEugene Sandulenko
As per discussion in bug #10116.
2017-11-26XEEN: Fixes to selection of mirror destinationsPaul Gilbert
2017-11-26MOHAWK: RIVEN: Ignore key repeat eventsBastien Bouclet
This fixes keyboard book page turning being too fast when holding keys
2017-11-26MOHAWK: RIVEN: Allow turning book pages more quicklyBastien Bouclet
Fixes #10075
2017-11-26NEVERHOOD: fix late game notes crash in DRIvan Avdeev
After player gets to the castle using a robot, Willie's notes become red "Windows'" (in DR Russian version) notes. One of the notes requires patching.
2017-11-26JANITORIAL: Remove trailing whitespacesEugene Sandulenko
2017-11-26COMPOSER: Properly strip down the relative pathsEugene Sandulenko
2017-11-26FULLPIPE: Fix out of bounds string accessBastien Bouclet
abe1c65d626a8f3 changed _trackName from a char * to a Common::String, but still tried to access the null terminator byte.
2017-11-26FULLPIPE: Fix handleInteraction for non static ani objectsBastien Bouclet
cce851d1af introduced a check to allow only static ani objects. However after this change, only part of the pipes for vertical movement were interactive. This change aims to restore functionality for the other object types while still preventing the invalid casts.
2017-11-26SCUMM: Do not do anything for real with original save screen in MM C64 demoEugene Sandulenko
2017-11-26PLUMBERS: Remove unstable flag and enable by defaultThierry Crozat
2017-11-25XEEN: Add animated cursor for text inputPaul Gilbert
2017-11-25XEEN: Fix prompt text for teleport mirrorPaul Gilbert
2017-11-25SCUMM: Do not try to show original save/load screen in C64 demoEugene Sandulenko
Fixes bug #10116
2017-11-25XEEN: Fix 'No items available' getting repeated multiple timesPaul Gilbert
2017-11-25XEEN: Fix for Items dialog item glyphs and crash exiting dialogPaul Gilbert
2017-11-24XEEN: Fixes for blacksmith wares initialization and renderingPaul Gilbert
2017-11-24XEEN: Toggle UI buttons properly within items dialogPaul Gilbert
2017-11-24XEEN: Toggle UI buttons when hotkey is pressedPaul Gilbert
2017-11-24XEEN: Fix hotkeys when Caps Lock is turned onPaul Gilbert
2017-11-24XEEN: Fix crash exiting game whilst town actions are activePaul Gilbert
2017-11-24XEEN: Fixes for calculating weapon costsPaul Gilbert