aboutsummaryrefslogtreecommitdiff
path: root/gui/EventRecorder.cpp
AgeCommit message (Collapse)Author
2017-12-03BASE: Remove bad casts between incompatible Plugin typesColin Snover
Previously, a C-style cast was used to convert a Common::Array<Plugin *>, populated with pointers to StaticPlugin and DynamicPlugin instances, to a Common::Array<PluginSubclass<T> *>, but PluginSubclass<T> is a *sibling* class to StaticPlugin/DynamicPlugin, so this cast was invalid and the results undefined. The methods for retrieving subclasses of plugins can't be easily changed to just generate an array of temporary wrapper objects that expose an identical API which dereferences to the preferred PluginObject subclass because pointers to these objects are retained by other parts of ScummVM, so the wrappers would needed to be persisted or they would need to just re-expose the underlying Plugin object again. This indicated that a way to solve this problem is to have the callers receive Plugin objects and get the PluginObject from the Plugin by explicitly stating their desired type, in a similar manner to std::get(std::variant), so that the pattern used by this patch to solve the problem. Closes gh-1051.
2017-11-19EVENTS: Rename synthetic to kbdRepeatBastien Bouclet
2017-07-10Revert "COMMON: Change way the Singleton instances are instantiated"Eugene Sandulenko
This reverts commit eefa72afa1978a9dea10f5b1833fcc8f58a3468e. With this patch ConfigManager is broken.
2017-07-10COMMON: Change way the Singleton instances are instantiatedThierry Crozat
This fixes tons of warnings with clang from a recent xcode version on macOS (and possibly other systems) complaining that an instantiation of _singleton is required but no definition is available.
2016-03-25EVENTRECORDER: Fix incorrect check which prevented records from replayEugene Sandulenko
2014-12-05GUI: remove not used constPawel Kolodziejski
2014-02-18GUI: Make GPL headers consistent in themselves.Johannes Schickel
2013-09-09RECORDER: Fix warningEugene Sandulenko
2013-08-08GUI: Use Domain::const_iterator in EventRecorder code when possible.Johannes Schickel
2013-08-03GUI: Take advantage of Surface::getPixels.Johannes Schickel
2013-08-03GUI: Prefer getBasePtr instead of direct Surface::pixels access.Johannes Schickel
2013-07-18Merge pull request #353 from clone2727/eventrec_timer_fixEugene Sandulenko
ALL: Don't use EventRecorder at all when not compiled in
2013-07-14JANITORIAL: Remove trailing whitespaceSven Hesse
2013-07-14RECORDER: Fix CID 1046888. Wrong check.Eugene Sandulenko
2013-07-14RECORDER: Rename class variable in accoudance with our code style.Eugene Sandulenko
2013-07-14RECORDER: Fix CID 1046884. Uninitialized class variables.Eugene Sandulenko
2013-07-06ALL: Don't use EventRecorder at all when not compiled inMatthew Hoops
2013-07-04GUI: Cleanup EventRecorder::getSurface.Johannes Schickel
Formerly the function created a SDL_Surface by hand. Instead now it uses SDL_CreateRGBSurface (which is used in the SDL backend anyway and yields the same results). This should fix PS3 port compilation.
2013-05-17RECORDER: Implement Events RecorderEugene Sandulenko