Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
Updating the list reset the selection in the list widget, however if
a save had previously been selected and the Choose button was enabled,
it remained enabled despite no save being selected. Trying to load
the game resulted in a crash. This was particularly an issue with
cloud enabled as if you are unlucky you could have tried to load a
save just as the cloud sync finished, which updated the list and
unselected the save. This change fixes bug #9766: Assert in
SaveLoadChooser dialog.
In addition to adding a sanity check on the selected index for the
Choose command, this commit also preserves the selection when
updating the list as I think this would be the expected behaviour
in this dialog.
|
|
Instead of shrinking the rect based on how many labels aren't there,
expand the rect based on how many labels are there.
Closes gh-958
|
|
The Save/Load screen has a preview area with labels for date and time.
The bottom label was drawing past the bottom of the rect.
|
|
|
|
|
|
The cloud manager registers itself as an event source as a mean to be polled
periodically by the GUI or engine code. The periodical polling is used to
update the OSD icon indicating background sync activity.
Also move the cloud icon from ConnectionManager to CloudManager,
allowing to decouple icon handling from network connections updates.
|
|
|
|
Added it into hasFeature() of all engines which returned `true` in
simpleSaveNames() before.
As mentioned in #788, SCI is not always using simple names, so it
doesn't have such feature now.
|
|
|
|
I knew there were some, but I wanted to fix them once, instead of doing
it all the time.
|
|
In most cases that's the right one to check. USE_CLOUD is defined when
either USE_LIBCURL or USE_SDL_NET are, which means if there is no curl,
USE_CLOUD still could be defined and linking errors would appear.
|
|
Linking was failing when disabling curl support.
|
|
It was SavesSyncRequest's target even when closed.
|
|
During saves sync slots of MetaEngines with simpleSaveNames() == false
would not be available at all. User would have to wait for sync to
complete.
|
|
Engines with "simple" savenames would support "Run in background" in
save/load dialog and gradual save slots unlocking. Other engines
save/load feature would be locked until save sync is over.
|
|
* disabled progress bar;
* removed syncTarget segfault;
* fixed grid slots disabling for "locked" slots.
|
|
ScummVM would probably crash when using a theme without
SaveLoadCloudSyncProgress dialog described.
|
|
So now it's centered, includes a progress bar and two labels instead of
one. Works fine in 320x200.
|
|
|
|
It's common for Save/Load dialogs and SavesSyncRequest.
|
|
MetaEngines don't get "locked" files in the list, so won't try to open
these.
Save/Load dialog updates save list every time SavesSyncRequest tells it
to.
|
|
|
|
It's closing itself a bit later now.
|
|
It's shown by SaveLoadChooserDialog when files are downloaded and some
save slots are locked. One can hide that dialog to interact with
non-locked slots or cancel saves sync completely. Dialog's label shows
current sync progress.
Dialog automatically hides itself when all files are downloaded.
WARNING: right now that results in a crash!
|
|
It also shows a "sync disabled" icon in case it has a savepath override.
|
|
|
|
This fixes overwriting of, for example, autosaves in the grid based save load
dialog when using "New Save".
|
|
Makes it consistant throughout the GUI
|
|
|
|
All of these are for handling kCloseCmd.
|
|
|
|
chooser.
|
|
Powered by:
git ls-files "*.cpp" "*.h" "*.m" "*.mm" | xargs sed -i -e 's/[ \t]*$//'
|
|
This avoids a off by one error in some cases.
|
|
This should give a better user experience, since the user will not have to
scroll back to where he was when he used the dialog last.
Thanks to wjp for suggesting this.
|
|
This allows opening the dialog on (nearly) the same page again as when it was
closed. Sadly due to the different number of entries in the save and load
version this is not always exactly the same page as before. Same goes for
resolution changes.
Thanks to wjp for suggesting this.
|
|
|
|
|
|
|
|
New save/load chooser
Conflicts:
gui/saveload.cpp
|
|
|
|
DISABLE_SAVELOADCHOOSER_GRID.
|
|
|
|
|
|
|
|
one isn't available.
|
|
|