Force both manual and automatic frameskipping to be at or above 2. Resets the default value for all games which previously had this value configured.

1 files changed, 20 insertions, 2 deletions

diff --git a/source/nds/gui.h b/source/nds/gui.h
index e8302eb..b390b69 100644
--- a/source/nds/gui.h
+++ b/source/nds/gui.h
@@ -50,7 +50,24 @@ struct _GAME_CONFIG
 {
 	u32 clock_speed_number;
 	u32  Reserved0;
-	u32 frameskip_value;
+	/*
+	 * PreviouslyUsed_20130205_1 was formerly known as 'frameskip_value';
+	 * its values were in [0, 10]. 0 was automatic frameskipping and
+	 * [1, 10] were mapped to skip 0 to 9 frames respectively.
+	 * Version 1.29 changes the value range for 'frameskip_value' to
+	 * [0, 8], with 0 as automatic frameskipping and [1, 10] to skip 2 to
+	 * 9 frames.
+	 * Change rationale: Frame skip values under 2 cause too much
+	 * communication between the DSTwo and the DS, therefore the DS cannot
+	 * timely send controller information.
+	 * If this variable were to be used as is, the meaning of the option
+	 * would be changed for values in [1, 8], and values in [9, 10] would
+	 * cause undefined behavior, including crashes.
+	 * THIS VALUE IS NOT GUARANTEED TO BE RESERVED AND SET TO 0.
+	 * DO NOT USE THIS VALUE FOR ANY PURPOSE OTHER THAN EXACTLY THE ONE
+	 * FOR WHICH IT WAS INTENDED.
+	 */
+	u32 PreviouslyUsed_20130205_1;
 	u32 graphic;
 	u32 enable_audio;
 	u32 Reserved1;
@@ -60,7 +77,8 @@ struct _GAME_CONFIG
 	u32 HotkeyTemporaryFastForward;
 	u32 HotkeyToggleSound;
 	u32 SoundSync;
-	u32  Reserved2[44];
+	u32 frameskip_value;
+	u32  Reserved2[43];
 };
 
 typedef enum