diff options
| author | Simon Howard | 2014-04-01 20:43:45 -0400 |
|---|---|---|
| committer | Simon Howard | 2014-04-01 20:43:45 -0400 |
| commit | 8eb3200286d523379295143ce3f44d77ce036d4b (patch) | |
| tree | ac0edb56027f285425d896e12a1b14d78ad294b9 /src/hexen/sc_man.c | |
| parent | 565a1f08566520147a5abff5744dbcc256e5030c (diff) | |
| download | chocolate-doom-8eb3200286d523379295143ce3f44d77ce036d4b.tar.gz chocolate-doom-8eb3200286d523379295143ce3f44d77ce036d4b.tar.bz2 chocolate-doom-8eb3200286d523379295143ce3f44d77ce036d4b.zip | |
Replace all snprintf() calls with M_snprintf().
The Windows API has an _snprintf function that is not the same as
Unix's snprintf(): if the string is truncated then no trailing NUL
character is appended. This makes the function unsafe. Define a
replacement/wrapper called M_snprintf that works the same but always
appends a trailing NUL, for safety on Windows and other OSes that
behave like this.
Do the same thing for vsnprintf(), and update HACKING to list
snprintf/vsnprintf as forbidden functions. This fixes #375;
thanks to Quasar for pointing out the different behavior of these
functions.
Diffstat (limited to 'src/hexen/sc_man.c')
| -rw-r--r-- | src/hexen/sc_man.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/hexen/sc_man.c b/src/hexen/sc_man.c index 35f5ec0b..bf3574c3 100644 --- a/src/hexen/sc_man.c +++ b/src/hexen/sc_man.c @@ -88,7 +88,7 @@ void SC_Open(char *name) if (sc_FileScripts == true) { - snprintf(fileName, sizeof(fileName), "%s%s.txt", sc_ScriptsDir, name); + M_snprintf(fileName, sizeof(fileName), "%s%s.txt", sc_ScriptsDir, name); SC_OpenFile(fileName); } else |