aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMax Horn2006-10-21 11:14:41 +0000
committerMax Horn2006-10-21 11:14:41 +0000
commit772affc7dbb75faad85b69c00b381d12340f809d (patch)
tree4da9e83bade400fb361f911c6f4b118abe4c74ca
parenta15885656db00a5013c01381f4f61cc8a442977b (diff)
downloadscummvm-rg350-772affc7dbb75faad85b69c00b381d12340f809d.tar.gz
scummvm-rg350-772affc7dbb75faad85b69c00b381d12340f809d.tar.bz2
scummvm-rg350-772affc7dbb75faad85b69c00b381d12340f809d.zip
Yuck, mark abuse of OSystem::setSoundCallback
svn-id: r24404
-rw-r--r--sound/mods/protracker.cpp7
1 files changed, 7 insertions, 0 deletions
diff --git a/sound/mods/protracker.cpp b/sound/mods/protracker.cpp
index 8948ae4c20..591c0276ac 100644
--- a/sound/mods/protracker.cpp
+++ b/sound/mods/protracker.cpp
@@ -35,6 +35,13 @@ void ProtrackerPlayer::init(OSystem *system) {
_buf = new SoundBuffer();
+// FIXME BROKEN: You must NOT use OSystem::setSoundCallback(),
+// ever! The only piece of code allowed to use it is the mixer.
+// And soon the call might be removed completely, too.
+// The proper way to do this is to create a AudioStream
+// subclass and hook that with the mixer. See also the
+// code used by other softsynths (sound/softsynth/emumidi.h).
+
_system->setSoundCallback(&audioCallback, this);
}