diff options
| author | Filippos Karapetis | 2018-12-02 23:58:44 +0200 |
|---|---|---|
| committer | Filippos Karapetis | 2018-12-02 23:58:44 +0200 |
| commit | 8d4330a217200f646a7402c41ea1fd5d28667de9 (patch) | |
| tree | 9e79d0bf8603d72f32722ad84d9bc03c5ade8ed0 | |
| parent | a8bae85d0368ec9aff0357a65fdb16f3b526a36c (diff) | |
| download | scummvm-rg350-8d4330a217200f646a7402c41ea1fd5d28667de9.tar.gz scummvm-rg350-8d4330a217200f646a7402c41ea1fd5d28667de9.tar.bz2 scummvm-rg350-8d4330a217200f646a7402c41ea1fd5d28667de9.zip | |
SCI: Add some TODOs for better handling of wrong / missing resources
| -rw-r--r-- | engines/sci/engine/message.cpp | 3 | ||||
| -rw-r--r-- | engines/sci/resource_audio.cpp | 2 |
2 files changed, 5 insertions, 0 deletions
diff --git a/engines/sci/engine/message.cpp b/engines/sci/engine/message.cpp index 3130abbb7d..aa961c9a85 100644 --- a/engines/sci/engine/message.cpp +++ b/engines/sci/engine/message.cpp @@ -228,6 +228,9 @@ bool MessageState::getRecord(CursorStack &stack, bool recurse, MessageRecord &re MessageTuple &t = stack.top(); // Fix known incorrect message tuples + // TODO: Add a more generic mechanism, like the one we have for + // script workarounds, for cases with incorrect sync resources, + // like the ones below. if (g_sci->getGameId() == GID_QFG1VGA && stack.getModule() == 322 && t.noun == 14 && t.verb == 1 && t.cond == 19 && t.seq == 1) { // Talking to Kaspar the shopkeeper - bug #3604944 diff --git a/engines/sci/resource_audio.cpp b/engines/sci/resource_audio.cpp index 2e885666b6..2f713e424b 100644 --- a/engines/sci/resource_audio.cpp +++ b/engines/sci/resource_audio.cpp @@ -476,6 +476,8 @@ int ResourceManager::readAudioMapSCI11(IntMapResourceSource *map) { // FIXME: The sync36 resource seems to be two bytes too big in KQ6CD // (bytes taken from the RAVE resource right after it) if (syncSize > 0) { + // TODO: Add a mechanism to handle cases with missing resources like the ones below + // // LB2CD is missing the sync resource for message 1885 1 6 30 2 but it's a duplicate // of 1885 1 6 16 2 which does have a sync resource so use that for both. bug #9956 if (g_sci->getGameId() == GID_LAURABOW2 && map->_mapNumber == 1885 && n == 0x01061002) { |