diff options
| author | Max Horn | 2007-02-08 22:54:09 +0000 |
|---|---|---|
| committer | Max Horn | 2007-02-08 22:54:09 +0000 |
| commit | 2232047695d8d26542c2f57d1c1daed7bfe4f5c5 (patch) | |
| tree | 279d0ec8fedee35ec75cedfbb9fc8767de52ba89 /backends/platform/PalmOS/Src | |
| parent | af8cba43acedb53a7caa711f743f8d5e0bcc07e6 (diff) | |
| download | scummvm-rg350-2232047695d8d26542c2f57d1c1daed7bfe4f5c5.tar.gz scummvm-rg350-2232047695d8d26542c2f57d1c1daed7bfe4f5c5.tar.bz2 scummvm-rg350-2232047695d8d26542c2f57d1c1daed7bfe4f5c5.zip | |
The restriction on 'small' mouse cursors has been lifted quite some time ago; PalmOS and WinCE port should be extended accordingly (in particular, the PalmOS port would silently overwrite its memory when big cursors are used)
svn-id: r25431
Diffstat (limited to 'backends/platform/PalmOS/Src')
| -rw-r--r-- | backends/platform/PalmOS/Src/os5_mouse.cpp | 9 |
1 files changed, 9 insertions, 0 deletions
diff --git a/backends/platform/PalmOS/Src/os5_mouse.cpp b/backends/platform/PalmOS/Src/os5_mouse.cpp index 375dc125ce..20e725694c 100644 --- a/backends/platform/PalmOS/Src/os5_mouse.cpp +++ b/backends/platform/PalmOS/Src/os5_mouse.cpp @@ -41,6 +41,15 @@ void OSystem_PalmOS5::setMouseCursor(const byte *buf, uint w, uint h, int hotspo if (w == 0 || h == 0) return; +FIXME: The restriction on MAX_MOUSE_H / MAX_MOUSE_W is obsolete; +in particular, BS2 might use bigger cursors these days. +See also bug #1609058. 1607180 +Hence this code now might overwrite memory unchecked; at the +very least an assert should be inserted to cause a controlled +crash, but of course it would be better to remove the restriction +on "small" cursors. + + _mouseCurState.w = w; _mouseCurState.h = h; |