added my thoughts on our command line options (please feel free to comment and tell me what you thinkg about it!); fixed program exit code for -z

svn-id: r10717

1 files changed, 12 insertions, 1 deletions

diff --git a/base/gameDetector.cpp b/base/gameDetector.cpp
index 476b14870b..d1f340d706 100644
--- a/base/gameDetector.cpp
+++ b/base/gameDetector.cpp
@@ -48,6 +48,17 @@
                             current_option = NULL
 
 // DONT FIXME: DO NOT ORDER ALPHABETICALY, THIS IS ORDERED BY IMPORTANCE/CATEGORY! :)
+// FIXME: Reconsider and reevaluate our command line options. I propose some changes:
+// * add long alternatives for (almost?) all options. There should be some generic way
+//   to specify this, in order to avoid code duplication and to simplify the code
+// * some more obscure options which currently have a single-letter options assigned
+//   really don't need it. E.g. the "-t<NUM>" option probably is rarely used, and anybody
+//   who needs it should still be happy with "--tempo=NUM"
+//   This will make room in the ranks of single-letter options for other more useful options
+//   (for example, "-t" could stand for "List (T)argets")
+// * -y, -t, -c, -j all are candidates for this, IMHO: their settings are rather obscure,
+//   and anybody who needs them always should put them into the config file anyway
+//
 #ifdef __PALM_OS__
 static const char USAGE_STRING[] = "NoUsageString"; // save more data segment space
 #else
@@ -427,7 +438,7 @@ void GameDetector::parseCommandLine(int argc, char **argv) {
 			case 'z':
 				CHECK_OPTION();
 				list_games();
-				exit(1);
+				exit(0);
 			case '-':
 				// Long options. Let the fun begin!
 				if (!strncmp(s, "platform=", 9)) {