diff options
author | Filippos Karapetis | 2010-06-18 14:36:22 +0000 |
---|---|---|
committer | Filippos Karapetis | 2010-06-18 14:36:22 +0000 |
commit | b152f6d68ff00290b475df35df180e95f84af6d3 (patch) | |
tree | 2aa231bfb37e7d118e2d2f90705786cf45e4c6c9 /engines/sci | |
parent | 562f8a9463a23e7dfac01d81b6e11c13b4c66600 (diff) | |
download | scummvm-rg350-b152f6d68ff00290b475df35df180e95f84af6d3.tar.gz scummvm-rg350-b152f6d68ff00290b475df35df180e95f84af6d3.tar.bz2 scummvm-rg350-b152f6d68ff00290b475df35df180e95f84af6d3.zip |
Added an explanation about the invalid instruments used when using the Adlib driver in PQ2
svn-id: r50019
Diffstat (limited to 'engines/sci')
-rw-r--r-- | engines/sci/sound/drivers/adlib.cpp | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/engines/sci/sound/drivers/adlib.cpp b/engines/sci/sound/drivers/adlib.cpp index 44e52cf768..2e56b023e0 100644 --- a/engines/sci/sound/drivers/adlib.cpp +++ b/engines/sci/sound/drivers/adlib.cpp @@ -703,8 +703,15 @@ void MidiDriver_AdLib::setVelocityReg(int regOffset, int velocity, int kbScaleLe void MidiDriver_AdLib::setPatch(int voice, int patch) { if ((patch < 0) || ((uint)patch >= _patches.size())) { - // This happens a lot at least in pq2, seems to me as if it's meant for mt32 actually - warning("ADLIB: Invalid patch %i requested", patch); + // This happens a lot at least in PQ2. This game has a small patch.003 (1344 bytes), + // containing 48 instruments. However it has several songs which use instruments + // not specified in that patch (namely, songs 1, 3, 5, 9, 15, 16, 17, 23, 25, 27, + // 29, 32, 36, 38, 44, 45, 46 all use instruments not specified in patch.003). + // These were probably written for MT32. These warnings in PQ2 can probably go away + // if a bigger patch.003 file is used (one that contains all the instruments used + // by the songs, i.e. 5382 bytes) + warning("ADLIB: Invalid patch %i requested (patch.003 contains %d instruments)", + patch, _patches.size()); patch = 0; } |