diff options
| author | Max Horn | 2010-11-16 09:53:55 +0000 |
|---|---|---|
| committer | Max Horn | 2010-11-16 09:53:55 +0000 |
| commit | 1dbf8d73d56052654522cf4076490090a41f336b (patch) | |
| tree | 4ec9fd566c75859793a1fe72b78d025a87ac03d0 /engines/tinsel/play.cpp | |
| parent | ada9c9af608f1af9d00289f4aa2b7be868e2944f (diff) | |
| download | scummvm-rg350-1dbf8d73d56052654522cf4076490090a41f336b.tar.gz scummvm-rg350-1dbf8d73d56052654522cf4076490090a41f336b.tar.bz2 scummvm-rg350-1dbf8d73d56052654522cf4076490090a41f336b.zip | |
TINSEL: Mark all (?) global vars with a FIXME comment
Use of global vars is what prevents RTL from working in Tinsel (and
probably in other engines). More specifically, the fact that many
global vars are not explicitly inited when the engine is (re)launched.
svn-id: r54262
Diffstat (limited to 'engines/tinsel/play.cpp')
| -rw-r--r-- | engines/tinsel/play.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/engines/tinsel/play.cpp b/engines/tinsel/play.cpp index 103b8f42ad..145634b9dd 100644 --- a/engines/tinsel/play.cpp +++ b/engines/tinsel/play.cpp @@ -63,6 +63,8 @@ struct PPINIT { //----------------- LOCAL GLOBAL DATA -------------------- +// FIXME: Avoid non-const global vars + static SOUNDREELS soundReels[MAX_SOUNDREELS]; static int soundReelNumbers[MAX_SOUNDREELS]; @@ -432,6 +434,7 @@ static void t1PlayReel(CORO_PARAM, const PPINIT *ppi) { int tmpX, tmpY; CORO_END_CONTEXT(_ctx); + // FIXME: Avoid non-const global vars static int firstColZ = 0; // Z-position of column zero static int32 fColZfactor = 0; // Z-factor of column zero's actor @@ -818,6 +821,7 @@ static void t2PlayReel(CORO_PARAM, int x, int y, bool bRestore, int speed, SCNHA SoundReelWaitCheck(); } else { + // FIXME: Avoid non-const global vars static int baseZposn; // Z-position of column zero static uint32 baseZfact; // Z-factor of column zero's actor |