aboutsummaryrefslogtreecommitdiff
path: root/graphics
diff options
context:
space:
mode:
authorMax Horn2009-09-01 13:03:12 +0000
committerMax Horn2009-09-01 13:03:12 +0000
commit11a16fa30e8ea8dd5559d694cb9be660668d7842 (patch)
tree4af45de5a78ec03b19f9ea1ea42bde2b3d461354 /graphics
parent8e28469f1f8aa1c3b7ade6bcba9bef1d6dec3b8c (diff)
downloadscummvm-rg350-11a16fa30e8ea8dd5559d694cb9be660668d7842.tar.gz
scummvm-rg350-11a16fa30e8ea8dd5559d694cb9be660668d7842.tar.bz2
scummvm-rg350-11a16fa30e8ea8dd5559d694cb9be660668d7842.zip
Coding best practice: Whenever possible, pass objects by reference instead of by value. Also make variables or data table which are only used locally "static".
svn-id: r43882
Diffstat (limited to 'graphics')
-rw-r--r--graphics/jpeg.cpp2
-rw-r--r--graphics/jpeg.h3
2 files changed, 1 insertions, 4 deletions
diff --git a/graphics/jpeg.cpp b/graphics/jpeg.cpp
index 0ad2cf7699..bccffd254e 100644
--- a/graphics/jpeg.cpp
+++ b/graphics/jpeg.cpp
@@ -31,7 +31,7 @@
namespace Graphics {
// Order used to traverse the quantization tables
-uint8 JPEG::_zigZagOrder[64] = {
+static const uint8 _zigZagOrder[64] = {
0, 1, 8, 16, 9, 2, 3, 10,
17, 24, 32, 25, 18, 11, 4, 5,
12, 19, 26, 33, 40, 48, 41, 34,
diff --git a/graphics/jpeg.h b/graphics/jpeg.h
index f4743a5e83..9bf314de49 100644
--- a/graphics/jpeg.h
+++ b/graphics/jpeg.h
@@ -75,9 +75,6 @@ private:
uint8 _maxFactorV;
uint8 _maxFactorH;
- // Zig-Zag order
- static uint8 _zigZagOrder[64];
-
// Quantization tables
uint16 *_quant[JPEG_MAX_QUANT_TABLES];