aboutsummaryrefslogtreecommitdiff
path: root/gui
diff options
context:
space:
mode:
authorWillem Jan Palenstijn2006-05-27 14:41:15 +0000
committerWillem Jan Palenstijn2006-05-27 14:41:15 +0000
commitdfce3faabd81d434f06e6654eaca9cf992379935 (patch)
treef67427c2059c8d171b0ce9e5130e5e164e193b76 /gui
parent72403d1336574d0e9b49b662022dcec88b8610a7 (diff)
downloadscummvm-rg350-dfce3faabd81d434f06e6654eaca9cf992379935.tar.gz
scummvm-rg350-dfce3faabd81d434f06e6654eaca9cf992379935.tar.bz2
scummvm-rg350-dfce3faabd81d434f06e6654eaca9cf992379935.zip
add fixme about scrolling in about dialog
svn-id: r22685
Diffstat (limited to 'gui')
-rw-r--r--gui/about.cpp5
1 files changed, 5 insertions, 0 deletions
diff --git a/gui/about.cpp b/gui/about.cpp
index 90f7eb3600..1dc55b985d 100644
--- a/gui/about.cpp
+++ b/gui/about.cpp
@@ -191,6 +191,11 @@ void AboutDialog::drawDialog() {
// in the right way. Should be even faster...
const int firstLine = _scrollPos / _lineHeight;
const int lastLine = MIN((_scrollPos + _h) / _lineHeight + 1, (uint32)_lines.size());
+ // FIXME: There's some confusion here about the meaning of 'yOff'.
+ // The setDrawArea call above makes it possible to render text
+ // vertically from _y to _y+_h, while the line below assumes text
+ // is drawn from _y+yOff down. This causes leftover pixels
+ // the top while scrolling.
int y = _y + yOff - (_scrollPos % _lineHeight);
for (int line = firstLine; line < lastLine; line++) {