aboutsummaryrefslogtreecommitdiff
path: root/engines/sci/sfx
diff options
context:
space:
mode:
Diffstat (limited to 'engines/sci/sfx')
-rw-r--r--engines/sci/sfx/core.cpp6
-rw-r--r--engines/sci/sfx/iterator.cpp18
-rw-r--r--engines/sci/sfx/softseq/adlib.cpp2
-rw-r--r--engines/sci/sfx/test-iterator.cpp6
4 files changed, 16 insertions, 16 deletions
diff --git a/engines/sci/sfx/core.cpp b/engines/sci/sfx/core.cpp
index 803e7c5687..d21e244aab 100644
--- a/engines/sci/sfx/core.cpp
+++ b/engines/sci/sfx/core.cpp
@@ -561,7 +561,7 @@ void SfxState::updateMultiSong() {
oldseeker->next_playing = &not_playing_anymore;
if (oldseeker == oldseeker->next_playing) {
- error("updateMultiSong() failed. Breakpoint in %s, line %d\n", __FILE__, __LINE__);
+ error("updateMultiSong() failed. Breakpoint in %s, line %d", __FILE__, __LINE__);
}
}
@@ -572,7 +572,7 @@ void SfxState::updateMultiSong() {
= song_lib_find_next_active(_songlib, newseeker);
if (newseeker == newseeker->next_playing) {
- error("updateMultiSong() failed. Breakpoint in %s, line %d\n", __FILE__, __LINE__);
+ error("updateMultiSong() failed. Breakpoint in %s, line %d", __FILE__, __LINE__);
}
}
/* We now need to update the currently playing song list, because we're
@@ -947,7 +947,7 @@ Common::Error SfxState::sfx_send_midi(song_handle_t handle, int channel,
if (command == 0xb0 &&
arg1 == SCI_MIDI_CHANNEL_MUTE) {
- warning("TODO: channel mute (channel %d %s)!", channel, channel_state[arg2]);
+ warning("TODO: channel mute (channel %d %s)", channel, channel_state[arg2]);
/* We need to have a GET_PLAYMASK interface to use
here. SET_PLAYMASK we've got.
*/
diff --git a/engines/sci/sfx/iterator.cpp b/engines/sci/sfx/iterator.cpp
index 8192e4c75b..1743b787fc 100644
--- a/engines/sci/sfx/iterator.cpp
+++ b/engines/sci/sfx/iterator.cpp
@@ -69,14 +69,14 @@ BaseSongIterator::BaseSongIterator(byte *data, uint size, songit_id_t id)
#define CHECK_FOR_END_ABSOLUTE(offset) \
if (offset > self->_data.size()) { \
- warning("Reached end of song without terminator (%x/%x) at %d!", offset, self->_data.size(), __LINE__); \
+ warning("Reached end of song without terminator (%x/%x) at %d", offset, self->_data.size(), __LINE__); \
return SI_FINISHED; \
}
#define CHECK_FOR_END(offset_augment) \
if ((channel->offset + (offset_augment)) > channel->end) { \
channel->state = SI_STATE_FINISHED; \
- warning("Reached end of track %d without terminator (%x+%x/%x) at %d!", channel->id, channel->offset, offset_augment, channel->end, __LINE__); \
+ warning("Reached end of track %d without terminator (%x+%x/%x) at %d", channel->id, channel->offset, offset_augment, channel->end, __LINE__); \
return SI_FINISHED; \
}
@@ -384,7 +384,7 @@ static int _sci_midi_process_state(BaseSongIterator *self, byte *buf, int *resul
}
case SI_STATE_UNINITIALISED:
- warning("Attempt to read command from uninitialized iterator!");
+ warning("Attempt to read command from uninitialized iterator");
self->init();
return self->nextCommand(buf, result);
@@ -440,8 +440,8 @@ static int _sci_midi_process_state(BaseSongIterator *self, byte *buf, int *resul
}
default:
- warning("Invalid iterator state %d!", channel->state);
- error("Breakpoint in %s, line %d\n", __FILE__, __LINE__);
+ warning("Invalid iterator state %d", channel->state);
+ error("Breakpoint in %s, line %d", __FILE__, __LINE__);
return SI_FINISHED;
}
}
@@ -487,7 +487,7 @@ static int _sci0_get_pcm_data(Sci0SongIterator *self,
Common::Array<byte>::iterator iter = Common::find(self->_data.begin() + offset, self->_data.end(), SCI0_END_OF_SONG);
if (iter == self->_data.end()) {
- warning("Playing unterminated song!");
+ warning("Playing unterminated song");
return 1;
}
@@ -520,7 +520,7 @@ static int _sci0_get_pcm_data(Sci0SongIterator *self,
int d = offset + SCI0_PCM_DATA_OFFSET + size - self->_data.size();
warning("PCM advertizes %d bytes of data, but %d"
- " bytes are trailing in the resource!",
+ " bytes are trailing in the resource",
size, self->_data.size() - (offset + SCI0_PCM_DATA_OFFSET));
if (d > 0)
@@ -1290,7 +1290,7 @@ static void songit_tee_death_notification(TeeSongIterator *self, SongIterator *c
self->_status &= ~TEE_RIGHT_ACTIVE;
self->_children[TEE_RIGHT].it = NULL;
} else {
- error("songit_tee_death_notification() failed: Breakpoint in %s, line %d\n", __FILE__, __LINE__);
+ error("songit_tee_death_notification() failed: Breakpoint in %s, line %d", __FILE__, __LINE__);
}
}
@@ -1580,7 +1580,7 @@ int songit_next(SongIterator **it, byte *buf, int *result, int mask) {
if (retval == SI_MORPH) {
fprintf(stderr, " Morphing %p (stored at %p)\n", (void *)*it, (void *)it);
if (!SIMSG_SEND((*it), SIMSG_ACK_MORPH)) {
- error("SI_MORPH failed. Breakpoint in %s, line %d\n", __FILE__, __LINE__);
+ error("SI_MORPH failed. Breakpoint in %s, line %d", __FILE__, __LINE__);
} else
fprintf(stderr, "SI_MORPH successful\n");
}
diff --git a/engines/sci/sfx/softseq/adlib.cpp b/engines/sci/sfx/softseq/adlib.cpp
index 1b3180d9ea..d5debdd995 100644
--- a/engines/sci/sfx/softseq/adlib.cpp
+++ b/engines/sci/sfx/softseq/adlib.cpp
@@ -184,7 +184,7 @@ void MidiDriver_Adlib::send(uint32 b) {
// Aftertouch in the OPL thing?
break;
default:
- warning("ADLIB: Unknown event %02x\n", command);
+ warning("ADLIB: Unknown event %02x", command);
}
}
diff --git a/engines/sci/sfx/test-iterator.cpp b/engines/sci/sfx/test-iterator.cpp
index a2dce5d088..0d603a89fd 100644
--- a/engines/sci/sfx/test-iterator.cpp
+++ b/engines/sci/sfx/test-iterator.cpp
@@ -30,7 +30,7 @@
using namespace Sci;
-#define ASSERT_S(x) if (!(x)) { error("Failed assertion in L%d: " #x "\n", __LINE__); return; }
+#define ASSERT_S(x) if (!(x)) { error("Failed assertion in L%d: " #x, __LINE__); return; }
#define ASSERT(x) ASSERT_S(x)
/* Tests the song iterators */
@@ -104,7 +104,7 @@ int simple_it_next(SongIterator *_self, unsigned char *buf, int *result) {
}
Audio::AudioStream *simple_it_pcm_feed(SongIterator *_self) {
- error("No PCM feed!\n");
+ error("No PCM feed");
return NULL;
}
@@ -418,6 +418,6 @@ int main(int argc, char **argv) {
test_iterator_sci0_loop();
test_iterator_sci0_mark_loop();
if (errors != 0)
- warning("[ERROR] %d errors total.", errors);
+ warning("[ERROR] %d errors total", errors);
return (errors != 0);
}