Age | Commit message (Collapse) | Author | |
---|---|---|---|
2014-03-15 | CGE: Remove a useless structure member, reduce a variable scope | Strangerke | |
2014-03-15 | CGE: Remove a useless variable, remove some associated dead code | Strangerke | |
2014-03-02 | CGE: Move hero shadow check inside hero check in sceneUp() | Strangerke | |
2014-02-18 | CGE: Make GPL headers consistent in themselves. | Johannes Schickel | |
2014-02-09 | CGE: Reduce the scope of some variables | Strangerke | |
2014-01-15 | ALL: Remove optimization unstable code on checking for null after new. | D G Turner | |
These issues were identified by the STACK tool. By default, the C++ new operator will throw an exception on allocation failure, rather than returning a null pointer. The result is that testing the returned pointer for null is redundant and _may_ be removed by the compiler. This is thus optimization unstable and may result in incorrect behaviour at runtime. However, we do not use exceptions as they are not supported by all compilers and may be disabled. To make this stable without removing the null check, you could qualify the new operator call with std::nothrow to indicate that this should return a null, rather than throwing an exception. However, using (std::nothrow) was not desirable due to the Symbian toolchain lacking a <new> header. A global solution to this was also not easy by redefining "new" as "new (std::nothrow)" due to custom constructors in NDS toolchain and various common classes. Also, this would then need explicit checks for OOM adding to all new usages as per C malloc which is untidy. For now to remove this optimisation unstable code is best as it is likely to not be present anyway, and OOM will cause a system library exception instead, even without exceptions enabled in the application code. | |||
2013-11-10 | CGE: Ensure string copy don't overrun. Fix CID 1003674 to 1003678 | Strangerke | |
2013-08-03 | CGE: Take advantage of Surface::getPixels. | Johannes Schickel | |
2013-08-03 | CGE: Prefer getBasePtr over direct Surface::pixels access. | Johannes Schickel | |
2012-09-26 | JANITORIAL: Remove trailing whitespaces. | Johannes Schickel | |
Powered by: git ls-files "*.cpp" "*.h" "*.m" "*.mm" | xargs sed -i -e 's/[ \t]*$//' | |||
2012-09-05 | CGE: Fix bug #3557904 - Shadow at wrong position | Strangerke | |
2012-08-05 | CGE: Keep Soltys' position when saving | Strangerke | |
2012-08-04 | CGE: Fix bug #3547274 - missing travel buttons after save | Strangerke | |
2012-07-05 | CGE: Remove hack used to store keycode in CGEEvent | Strangerke | |
2012-06-28 | CGE: Remove unused Demo text id | Strangerke | |
2012-06-28 | CGE: Rename variable | Strangerke | |
2012-06-27 | CGE: Fix bug 3538039 - level buttons not pressed | Strangerke | |
2012-06-18 | CGE: Remove dead code originally used to load a savegame when starting the game | Strangerke | |
2012-03-28 | CGE: Close memory leak in savegame loading. | D G Turner | |
2012-03-28 | CGE: Close memory leak in savegame thumbnail loading. | D G Turner | |
2011-12-07 | CGE: Fix issue with music not stopping when reloading game | Thierry Crozat | |
If you turn off the music and then save a game, then turn on the music again and then load the saved game, the music from the scene continue to play despite the _music flag being false. So the first time you click on the music on/off button the music restart and only the second time does it stop. This fixes the bug by stoping the music before reloading a game. | |||
2011-12-03 | CGE: Fix an assert in intro | Strangerke | |
2011-12-03 | CGE: Soltys - Fix initialization of a couple of bool variables | Strangerke | |
2011-12-03 | CGE: Soltys - Fix for bug #3448836 (losing scene number display after ↵ | Strangerke | |
loading and changing scene) | |||
2011-11-30 | CGE: Only skips animations when pressing ESC. | Strangerke | |
This should allow tsoliman to see the end of the intro | |||
2011-11-30 | CGE: Simplify keyboard handling | Strangerke | |
2011-11-29 | CGE: Remove key sound in System::touch(). | Strangerke | |
ALTering dice no longer is no longer noisy | |||
2011-11-27 | CGE: Better fix for restoring savegames when a cut-scene is active | Paul Gilbert | |
2011-11-16 | CGE: Add RTL, hook Main Menu to right click on audio button | Strangerke | |
2011-11-14 | CGE: Rename a structure member using double-underscore (reserved) | Strangerke | |
Also removed a useless comment | |||
2011-11-13 | CGE: Remove some useless constants | Strangerke | |
2011-11-09 | CGE: Properly stop player moving when saving or restoring | Paul Gilbert | |
2011-11-03 | CGE: Fix warning | Eugene Sandulenko | |
2011-10-22 | CGE: Add some doxygen comments | Strangerke | |
2011-09-18 | CGE: Rename Snail into CommandHandler, plus some associated renamings | Strangerke | |
2011-09-17 | CGE: Fix a potential bug in insertCommand(), some renaming | Strangerke | |
2011-09-17 | CGE: Remove a use reference to g_engine | Strangerke | |
Thanks fuzzie for mentioning it | |||
2011-09-17 | CGE: Move _talk and _text to CGEEngine | Strangerke | |
2011-09-17 | CGE: Move some more globals to CGEEngine | Strangerke | |
2011-09-17 | CGE: some more cleanup | Strangerke | |
2011-09-17 | CGE: Move some more globals to CGEEngine | Strangerke | |
2011-09-17 | CGE: Move 4 global to CGEEngine | Strangerke | |
2011-09-16 | CGE: Move _vga to CGEEngine | Strangerke | |
2011-09-16 | CGE: Get rid of some more global functions and static members | Strangerke | |
2011-09-16 | CGE: move two global functions to Vga | Strangerke | |
2011-09-16 | CGE: Move two globals functions to CGEEngine | Strangerke | |
2011-09-15 | CGE: Transform some static and globals into class members | Strangerke | |
2011-09-14 | CGE: Rename cave into scene | Strangerke | |
2011-09-14 | CGE: Remove useless function | Strangerke | |
2011-09-14 | CGE: Rewrite fileIO | Strangerke | |