Age | Commit message (Collapse) | Author | |
---|---|---|---|
2018-08-03 | LAB: By default skip thumbnail loading for readSaveGameHeader | David Fioramonti | |
This changes the convention back to skipping the thumbnail loading for readSaveGameHeader. querySaveMetaInfos is the only place it shouldn't be skipped. | |||
2018-07-25 | LAB: Fix thumbnail issues | David Fioramonti | |
Fixes Trac#10619. The thumbnail loading for the saved games was defaulting to disabled so no thumbnail was being loaded and this caused trying to show the thumbnail to crash scummvm. So I have set the thumbnail pointer to be null if the thumbnail doesn't get loaded and I've set the thumnail to not be skipped so that thumbnails get shown when using the gui. | |||
2018-04-07 | ALL: Load savegame thumbnail only when necessary | Adrian Frühwirth | |
This commit introduces the following changes: 1. Graphics::loadThumbnail() Now returns a boolean and takes a new argument skipThumbnail which defaults to false. In case of true, loadThumbnail() reads past the thumbnail data in the input stream instead of actually loading the thumbnail. This simplifies savegame handling where, up until now, many engines always read the whole savegame metadata (including the thumbnail) and then threw away the thumbnail when not needed (which is in almost all cases, the most common exception being MetaEngine::querySaveMetaInfos() which is responsible for loading savegame metadata for displaying it in the GUI launcher. 2. readSavegameHeader() Engines which already implement such a method (name varies) now take a new argument skipThumbnail (default: true) which is passed through to loadThumbnail(). This means that the default case for readSavegameHeader() is now _not_ loading the thumbnail from a savegame and just reading past it. In those cases, e.g. querySaveMetaInfos(), where we actually are interested in loading the thumbnail readSavegameHeader() needs to explicitely be called with skipThumbnail == false. Engines whose readSavegameHeader() (name varies) already takes an argument loadThumbnail have been adapted to have a similar prototype and semantics. I.e. readSaveHeader(in, loadThumbnail, header) now is readSaveHeader(in, header, skipThumbnail). 3. Error handling Engines which previously did not check the return value of readSavegameHeader() (name varies) now do so ensuring that possibly broken savegames (be it a broken thumbnail or something else) don't make it into the GUI launcher list in the first place. | |||
2016-01-15 | LAB: Get rid of _interfaceOff | Filippos Karapetis | |
2016-01-15 | LAB: Separate the interface from the event manager | Filippos Karapetis | |
2016-01-14 | LAB: Clean up the trial warning handling code | Filippos Karapetis | |
2016-01-14 | LAB: Rename doCloseup() to reflect its actual purpose | Filippos Karapetis | |
2016-01-14 | LAB: Get rid of setDirection() | Filippos Karapetis | |
A leftover from code restructuring | |||
2016-01-14 | LAB: Rename the members of the CrumbData struct | Filippos Karapetis | |
This helps to distinguish them from the LabEngine variables | |||
2016-01-14 | LAB: The parameter of doMap() isn't needed | Filippos Karapetis | |
2016-01-05 | LAB: Fix switching between texts in monitor | Willem Jan Palenstijn | |
2015-12-28 | LAB: Fix loading from the GMM and warping to rooms from the console | Filippos Karapetis | |
2015-12-27 | LAB: Add support for saving and loading games from the GMM | Filippos Karapetis | |
2015-12-27 | LAB: Refactor the music code | Filippos Karapetis | |
2015-12-27 | LAB: Rename TilePuzzle to SpecialLocks, to better reflect its purpose | Filippos Karapetis | |
This class handles two different special locks, the tile puzzle and the combination door | |||
2015-12-26 | LAB: Remove type ConstDataPtr, add consts | Willem Jan Palenstijn | |
2015-12-26 | LAB: Reduce passing around of pointers to the near-global _closeDataPtr | Willem Jan Palenstijn | |
2015-12-26 | LAB: Reduce passing around of pointers to the near-global _closeDataPtr | Willem Jan Palenstijn | |
2015-12-26 | LAB: Reduce passing around of pointers to the near-global _closeDataPtr | Willem Jan Palenstijn | |
2015-12-26 | LAB: Reduce passing around of pointers to the near-global _closeDataPtr | Willem Jan Palenstijn | |
2015-12-25 | LAB: Rename fromCrumbs() to processEvent() and simplify it a bit | Filippos Karapetis | |
2015-12-25 | LAB: Use friendlier names for lists | Filippos Karapetis | |
2015-12-24 | Merge branch 'master' of github.com:scummvm/scummvm | Willem Jan Palenstijn | |
2015-12-24 | LAB: Avoid manual memory management of CloseData | Willem Jan Palenstijn | |
2015-12-24 | LAB: Remove the 3rd parameter of drawMap (always false) | Strangerke | |
2015-12-24 | Use Common::Keycode and enums in interface buttons | Filippos Karapetis | |
2015-12-24 | LAB: Avoid manual memory management in Action lists | Willem Jan Palenstijn | |
2015-12-24 | LAB: Get rid of _screenImage | Filippos Karapetis | |
Thanks to wjp for finding this | |||
2015-12-23 | LAB: Change the direction and map door defines into enums | Filippos Karapetis | |
2015-12-23 | LAB: Fix warnings by adding consts | Willem Jan Palenstijn | |
2015-12-23 | LAB: Add a console, with two new commands (scene and scene_resources) | Filippos Karapetis | |
2015-12-23 | LAB: Move event update functions out of updateMusic | Strangerke | |
2015-12-23 | LAB: Change RuleList to a Common::List<Rule> as suggested by wjp | Strangerke | |
2015-12-23 | LAB: Delete some more variables in LabEngine destructor | Strangerke | |
2015-12-23 | LAB: Move some more comments to header files | Strangerke | |
2015-12-23 | LAB: Constify some parameters | Strangerke | |
2015-12-23 | LAB: More work on the comments | Strangerke | |
2015-12-23 | LAB: Remove some leftover MSVC memory leak tester code | Filippos Karapetis | |
2015-12-23 | LAB: Use Common::String for strings, removing a ton of memory leaks | Filippos Karapetis | |
Also, add a method to properly free room views | |||
2015-12-23 | LAB: Remove parameters from processMainButton and performAction | Strangerke | |
2015-12-23 | LAB: Simplify decIncInv() and move action handling out of fromCrumbs() | Filippos Karapetis | |
2015-12-23 | LAB: Use Common::Rect in functions related to flowText (WIP) | Strangerke | |
2015-12-23 | LAB: Some renames | Filippos Karapetis | |
2015-12-23 | LAB: make takeItem use Common::Point, some refactoring | Strangerke | |
2015-12-23 | LAB: Move some code from fromCrumbs() into separate functions | Filippos Karapetis | |
This makes this huge function a bit easier to read and understand | |||
2015-12-23 | LAB: Fix a regression related to random number generation, some renaming | Strangerke | |
2015-12-23 | LAB: Finally get rid of g_lab | Strangerke | |
2015-12-23 | LAB: Some renaming in LabEngine | Strangerke | |
2015-12-23 | LAB: Add _vm to Image class | Strangerke | |
2015-12-23 | LAB: Merge the different X image maps | Filippos Karapetis | |