aboutsummaryrefslogtreecommitdiff
path: root/engines/sci/graphics/picture.cpp
AgeCommit message (Collapse)Author
2014-02-18SCI: Make GPL headers consistent in themselves.Johannes Schickel
2014-01-15ALL: Remove optimization unstable code on checking for null after new.D G Turner
These issues were identified by the STACK tool. By default, the C++ new operator will throw an exception on allocation failure, rather than returning a null pointer. The result is that testing the returned pointer for null is redundant and _may_ be removed by the compiler. This is thus optimization unstable and may result in incorrect behaviour at runtime. However, we do not use exceptions as they are not supported by all compilers and may be disabled. To make this stable without removing the null check, you could qualify the new operator call with std::nothrow to indicate that this should return a null, rather than throwing an exception. However, using (std::nothrow) was not desirable due to the Symbian toolchain lacking a <new> header. A global solution to this was also not easy by redefining "new" as "new (std::nothrow)" due to custom constructors in NDS toolchain and various common classes. Also, this would then need explicit checks for OOM adding to all new usages as per C malloc which is untidy. For now to remove this optimisation unstable code is best as it is likely to not be present anyway, and OOM will cause a system library exception instead, even without exceptions enabled in the application code.
2013-12-26SCI: fix sci1early+ ega picture issuesMartin Kiewitz
also remove hacks for kq5ega + sq4ega
2013-12-26SCI: floodfill reverted, was sci1early differenceMartin Kiewitz
fixes sq4 floppy properly
2013-12-24SCI: change floodfill fix for sq4Martin Kiewitz
behaviour wasn't changed in SCI1, instead it seems that SSCI draws overlays to separate memory and then copies them over. Previous commit caused regression in qfg1vga (funny room)
2013-12-23SCI: change floodfill to fix sq4 ship taking offMartin Kiewitz
fixes bug #6446
2013-10-02SCI: Make a note about pic 390 in the blacklisted SQ4CD NRS patch 1.2Filippos Karapetis
2013-08-19SCI: Fix bug #3614914 - "SCI: Castle of Dr Brain Spanish crashes after ↵Filippos Karapetis
Computer Room" Ignore the unused x/y displacement fields of cels embedded in pics. Dr. Brain Spanish, pic 261 contains garbage in these fields (probably left overs)
2013-04-27SCI: Change wording for bug/further info referencesFilippos Karapetis
2011-10-19SCI: The draw_pic console command now works in SCI32Filippos Karapetis
Moreover, the overlay is temporarily hidden to show the picture
2011-10-14SCI: More work on the vertical plane offset for SCI32. Still WIP.Filippos Karapetis
Vertical clipping is still not finished. This fixes the display in the Torin demo (which uses a scene with loads of items with a vertical offset).
2011-09-25SCI: Bugfix for the palette of Longbow Amiga (still not right)Filippos Karapetis
2011-06-20ALL: Remove trailing whitespacesMax Horn
This tries to make our code a bit more compliant with our code formatting conventions. For future use, this is the command I used: git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
2011-06-12SCI: Treat all priorities above 15 as noneWillem Jan Palenstijn
Before only 255 was treated this way. This fixes part of the broken dialog boxes in Jones CD (bug #3297111) which use priority 254, and matches Jones CD disassembly.
2011-05-12GIT: Clean up: Suppress SVN tags, now uselessstrangerke
2011-05-09SCI: Line wrap some commentsMax Horn
2011-05-09SCI: Slight cleanup to undithering codeMax Horn
2011-04-02SCI: Fix Mac SCI32 picture transparencyMatthew Hoops
2011-03-10SCI: Some renaming related to the undithering codemd5
Renamed some variables, functions and comments related to the undithering code, to make them a bit easier to understand
2011-03-07SCI: Initial handling of the views in Longbow Amiga. Still not rightmd5
2011-03-06SCI: Silence GCC warningeriktorbjorn
2011-03-06SCI: Merged the cel data unpacking code for views and picturesmd5
2011-03-06SCI: Some changes to picture drawingmd5
- Fixed picture drawing for Longbow Amiga (view drawing is still wrong, though) - Added debug output for picture drawing
2011-03-04SCI: Cleaned up some view type checksmd5
2011-03-04SCI: Fix flood fill matching in EGA modeWillem Jan Palenstijn
In EGA games a pixel in the framebuffer is only 4 bits. We store a full byte per pixel to allow undithering, but when comparing pixels for flood-fill purposes, we should only compare the visible color of a pixel. This fixes bug #3078365 in Iceman.
2011-02-05SCI: Fix SCI32 Mac picture palettesMatthew Hoops
The palette offset should be 32-bit, not 16. The GK1 Mac intro now plays properly. svn-id: r55784
2011-02-02SCI: Fix SCI32 Mac picturesMatthew Hoops
svn-id: r55724
2010-12-01SCI: Fixed bugs #3041044, #3046543 and #3046513Filippos Karapetis
svn-id: r54690
2010-11-05SCI: Add a default case to a switch statement to silence some compiler warnings.Johannes Schickel
svn-id: r54078
2010-11-04SCI: adding force to memorial area for SQ3/introMartin Kiewitz
makes the view getting fully undithered svn-id: r54068
2010-09-07SCI: Slight change in GfxPicture::vectorFloodFill()Filippos Karapetis
Changed bitwise XOR operations to bitwise NOT AND, to make the code a bit easier to understand svn-id: r52614
2010-08-16SCI: sci1.1 pictures w/o cel don't set paletteMartin Kiewitz
even if one is present in the picture, fixes some transitions looking weird in eq2 - bug #3037126 svn-id: r52125
2010-07-28SCI: adding header comments about sci1.1 picturesMartin Kiewitz
also fixing some of the offsets (those are DWORD instead of just WORDs) svn-id: r51415
2010-07-28SCI: priority handling for sci1.1 add-picturesMartin Kiewitz
fixes battle cruiser mini game in sq5 (at least we get something displayed now) svn-id: r51414
2010-07-27SCI: sci1.1 priority bands now changing in kDrawPicMartin Kiewitz
fixes qfg3: right guard on top of the palace having wrong priority fixes sq5 and all sorts of sci1.1 games: when loading wrong priority for some actors that fixed itself after one frame svn-id: r51397
2010-07-26SCI: adding scrollcapability to sci32Martin Kiewitz
svn-id: r51313
2010-07-26SCI: some scrolling support for sci32Martin Kiewitz
not fully done yet svn-id: r51308
2010-07-24SCI: locking picture resourceMartin Kiewitz
fixes sq6 crashing with resource data NULL pointer svn-id: r51240
2010-07-22SCI: fixing mirrored sci32 picturesMartin Kiewitz
fixes lsl6, also slight cleanup and adding comments about sci32 picture resources svn-id: r51162
2010-07-22SCI: some more work on priority sci32Martin Kiewitz
svn-id: r51139
2010-07-22SCI: some work on priority in sci32Martin Kiewitz
svn-id: r51134
2010-07-21SCI: terminating at another resource of sq4cdMartin Kiewitz
contains broken data as well, room 35 svn-id: r51103
2010-07-21SCI: fixing hires background pictures sci2.1Martin Kiewitz
svn-id: r51086
2010-07-13SCI: adding comment about GfxPicture::draw() and picture resource formatsMartin Kiewitz
svn-id: r50846
2010-07-13SCI: change handling of priority in combination with embedded cels inside ↵Martin Kiewitz
picture resources, change in r49029 was wrong - fixes pq1 (map not changing when driving car) svn-id: r50845
2010-06-25SCI: Introduce SciGameId enumMax Horn
svn-id: r50273
2010-06-23SCI: implementing boundary checking for GfxPalette::createFromData(), sq5 ↵Martin Kiewitz
has a broken picture 0 resource, which would result in either crash or at least bad read from memory depending on whats read there svn-id: r50178
2010-06-17SCI: Change SciEngine's 'char *getGameID()' to 'Common::String getGameId()'Max Horn
svn-id: r49968
2010-05-26SCI: adding another workaround for picture 376 in sq4/cd (same issue like ↵Martin Kiewitz
originally found in r49216) svn-id: r49247
2010-05-26SCI: adding another hack to sci32 picture drawing, fixes crash in sci32 ↵Martin Kiewitz
games introduced by r49216 svn-id: r49238
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-02 02:29:39 +0000