Age | Commit message (Collapse) | Author |
|
Fixes CAMELOT bug #11024
|
|
|
|
|
|
Fixes Trac#9660.
|
|
|
|
This may come back in the future to deduplicate some gfx code,
but SCI32 had two different inlined ways of doing coordinate
conversions with different rounding methods, so CoordAdjuster32
didn't get used when the graphics system was rewritten.
At the moment, SCI32 code uses the mulru/mulinc methods from
helper.h for scaling up/down coordinates.
|
|
|
|
|
|
|
|
|
|
These issues were identified by the STACK tool.
By default, the C++ new operator will throw an exception on allocation
failure, rather than returning a null pointer.
The result is that testing the returned pointer for null is redundant
and _may_ be removed by the compiler. This is thus optimization
unstable and may result in incorrect behaviour at runtime.
However, we do not use exceptions as they are not supported by all
compilers and may be disabled.
To make this stable without removing the null check, you could qualify
the new operator call with std::nothrow to indicate that this should
return a null, rather than throwing an exception.
However, using (std::nothrow) was not desirable due to the Symbian
toolchain lacking a <new> header.
A global solution to this was also not easy by redefining "new" as "new
(std::nothrow)" due to custom constructors in NDS toolchain and various
common classes.
Also, this would then need explicit checks for OOM adding to all new
usages as per C malloc which is untidy.
For now to remove this optimisation unstable code is best as it is
likely to not be present anyway, and OOM will cause a system library
exception instead, even without exceptions enabled in the application
code.
|
|
also remove hacks for kq5ega + sq4ega
|
|
fixes sq4 floppy properly
|
|
behaviour wasn't changed in SCI1, instead it seems that SSCI draws overlays to separate memory and then copies them over. Previous commit caused regression in qfg1vga (funny room)
|
|
fixes bug #6446
|
|
|
|
Computer Room"
Ignore the unused x/y displacement fields of cels embedded in pics.
Dr. Brain Spanish, pic 261 contains garbage in these fields (probably
left overs)
|
|
|
|
Moreover, the overlay is temporarily hidden to show the picture
|
|
Vertical clipping is still not finished. This fixes the display in the
Torin demo (which uses a scene with loads of items with a vertical
offset).
|
|
|
|
This tries to make our code a bit more compliant with our code formatting
conventions. For future use, this is the command I used:
git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
|
|
Before only 255 was treated this way. This fixes part of the broken
dialog boxes in Jones CD (bug #3297111) which use priority 254,
and matches Jones CD disassembly.
|
|
|
|
|
|
|
|
|
|
Renamed some variables, functions and comments related to the
undithering code, to make them a bit easier to understand
|
|
|
|
|
|
|
|
- Fixed picture drawing for Longbow Amiga (view drawing is still wrong,
though)
- Added debug output for picture drawing
|
|
|
|
In EGA games a pixel in the framebuffer is only 4 bits. We store a full
byte per pixel to allow undithering, but when comparing pixels for
flood-fill purposes, we should only compare the visible color of a
pixel.
This fixes bug #3078365 in Iceman.
|
|
The palette offset should be 32-bit, not 16. The GK1 Mac intro now plays properly.
svn-id: r55784
|
|
svn-id: r55724
|
|
svn-id: r54690
|
|
svn-id: r54078
|
|
makes the view getting fully undithered
svn-id: r54068
|
|
Changed bitwise XOR operations to bitwise NOT AND, to make the code a bit easier
to understand
svn-id: r52614
|
|
even if one is present in the picture, fixes some transitions looking weird in eq2 - bug #3037126
svn-id: r52125
|
|
also fixing some of the offsets (those are DWORD instead of just WORDs)
svn-id: r51415
|
|
fixes battle cruiser mini game in sq5 (at least we get something displayed now)
svn-id: r51414
|
|
fixes qfg3: right guard on top of the palace having wrong priority
fixes sq5 and all sorts of sci1.1 games: when loading wrong priority for some actors that fixed itself after one frame
svn-id: r51397
|
|
svn-id: r51313
|
|
not fully done yet
svn-id: r51308
|
|
fixes sq6 crashing with resource data NULL pointer
svn-id: r51240
|
|
fixes lsl6, also slight cleanup and adding comments about sci32 picture resources
svn-id: r51162
|
|
svn-id: r51139
|
|
svn-id: r51134
|