aboutsummaryrefslogtreecommitdiff
path: root/engines/sci/graphics
AgeCommit message (Collapse)Author
2011-07-01GRAPHICS: Remove default values from FontSJIS::drawChar.Johannes Schickel
drawChar is overloaded in FontSJIS. One takes a "Surface &" as first parameter another one "void *", they furthermore have the exact same number of required parameters. The one "void *" just had a few extra parameters with default values. This resulted in a bug in SCUMM, where "VirtScreen *" (a subclass of Surface) was passed instead of "VirtScreen &" and thus the method taking "void *" was incorrectly used. To make it easier to spot such bugs in the future I just removed the default values and thus disallow such calls.
2011-06-23ANALYSIS: Add static casts to is* functionsLittleboy
This fixes a potential problem with passing char values that would be sign-extended and yield unexpected results. See http://msdn.microsoft.com/en-us/library/ms245348.aspx
2011-06-20ALL: Remove trailing whitespacesMax Horn
This tries to make our code a bit more compliant with our code formatting conventions. For future use, this is the command I used: git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
2011-06-13SCI: Reverted commit db7dea3Filippos Karapetis
The original check was correct, and the associated MG bug (#3049515) has actually been fixed with another commit. Fixes bug (regression) #3315639 - "Character Glitches in KQ4 SCI". Many thanks to waltervn and wjp for their help on this
2011-06-13SCI: Shrink rectangle updated by DrawControl(Text)Willem Jan Palenstijn
This fixes dialogs in Jones CD (bug #3297111) together with 9e2c7f26d2e6c6081489365cbc07cd6edec362ad. This grow was probably accidentally added in 6fda9a5067ca642ccf569a0845e170a6a74ce442. Assembly of KQ5CD and JonesCD confirms it shouldn't be there.
2011-06-12SCI: Remove workaround that caused graphics corruptionWillem Jan Palenstijn
This fixes coins disappearing in Mother Goose SCI1.1 (bug #3051136). Filippos has confirmed the workaround is no longer necessary for the menubar in LSL6 for which it was added.
2011-06-12SCI: Treat all priorities above 15 as noneWillem Jan Palenstijn
Before only 255 was treated this way. This fixes part of the broken dialog boxes in Jones CD (bug #3297111) which use priority 254, and matches Jones CD disassembly.
2011-06-12SCI: Fixed bug #3295931 - "SCI: JONES: Disabled commands are available using ↵md5
shortcuts"
2011-06-12SCI: Add FIXME for bug #3051136Willem Jan Palenstijn
2011-06-04SCI: Set Mac versions of LSL1 and LSL5 to screen height 190.Walter van Niftrik
This fixes bug #3310782. However, as I was unable to get the games working in a Mac emulator, this is an educated guess at this point.
2011-05-25ALL: behaviour -> behaviorMatthew Hoops
2011-05-12GIT: Clean up: Suppress SVN tags, now uselessstrangerke
2011-05-09SCI: Line wrap some commentsMax Horn
2011-05-09SCI: Fix warning about potential strict-aliasing rules violationMax Horn
2011-05-09SCI: Slight cleanup to undithering codeMax Horn
2011-05-05SCI: Use new MacCursor code instead of convertCrsrCursor()Matthew Hoops
2011-05-01SCI: Round left/right edges in bitsShow to even coordsWillem Jan Palenstijn
This fixes the vertical black line glitch in the QfG3 start menu (#3293351)
2011-04-29SCI: Fixed bug #3289744 - "Hero Quest 1 demo crashes"md5
2011-04-28JANITORIAL: Reduce header dependencies in shared codeOri Avtalion
Some backends may break as I only compiled SDL
2011-04-28JANITORIAL: Format more forward declarations to follow conventionOri Avtalion
2011-04-28JANITORIAL: Format forward declarations to follow conventionOri Avtalion
2011-04-13SCI: Remove left-over fixme commentWillem Jan Palenstijn
It should have been removed in b40b87fdb5b4ee869cce55d852af409896b20c98
2011-04-12COMMON: Replace MKID_BE by MKTAGMax Horn
MKID_BE relied on unspecified behavior of the C++ compiler, and as such was always a bit unsafe. The new MKTAG macro is slightly less elegant, but does no longer depend on the behavior of the compiler. Inspired by FFmpeg, which has an almost identical macro.
2011-04-04SCI: Initialize newPlane fully before adding it to _planesMax Horn
2011-04-02SCI: Fix Mac SCI32 picture transparencyMatthew Hoops
2011-03-30SCI: Minor cleanupMatthew Hoops
2011-03-30SCI32: Support for views with 640x400 native resolutionLars Skovlund
(fixes Wolfgang closeup, room 720)
2011-03-29JANITORIAL: Remove/comment unused varsdhewg
Found by GCC 4.6's -Wunused-but-set-variable
2011-03-29SCI: Limit SCI32 view scaling to when we're actually scalingMatthew Hoops
Fixes bug #3253208
2011-03-25SCI: Make sure that planeOffsetX is always correctly initializedmd5
Fixes several issues with the menu in KQ7. Thanks to vakons for his patch. Fixes bug #3231867 - "KQ7 scrolling bug"
2011-03-25SCI: Add two TODOsdhewg
2011-03-20SCI: Moved the engine hunk pointer processing code inside the GfxPorts classmd5
This allows us make _windowList private again
2011-03-20SCI: Added a new console command "window_list" or "wl"md5
This can be used to see a list of the currently open windows. Also, added a sanity check for the "al" command and performed some minor cleanup
2011-03-20SCI: Removed forward references to obsolete classesmd5
2011-03-20SCI: Added a new console command, "animate_list" or "al"md5
This shows the current animation list, along with object properties, positions and the scripts they belong to
2011-03-14SCI: Fix the screen height of SQ1 MacMatthew Hoops
2011-03-13SCI: Fixed the flashing icon bar in the Mac version of Castle of Dr. Brainmd5
Thanks to waltervn for his work and help on this
2011-03-13SCI: Fixed regression of rev b1055a3c86. Japanese games should work againmd5
2011-03-10SCI: Fix uncompressed SCI1.1 viewsMatthew Hoops
A regression from d2ad7898d93
2011-03-10SCI: Made some checks inside unditherBitmap() more understandablemd5
2011-03-10SCI: Some renaming related to the undithering codemd5
Renamed some variables, functions and comments related to the undithering code, to make them a bit easier to understand
2011-03-09SCI: Implement Mac iconbar event handling.Walter van Niftrik
2011-03-09SCI: Whitespace fixesmd5
2011-03-09SCI: Some cleanup and fixes to the view unpacking codemd5
- Added comments for all the different view unpacking algorithms - Merged the SCI1 VGA and SCI1.1 VGA unpacking code - Fixed views in Longbow Amiga (the palette is still broken, though) - Used memset()/memcpy() instead of looping through - Fixed a regression of rev. d2ad789 (LSL1 Spanish, bug #3135872)
2011-03-09SCI: Save mouse position in SciEvent.Johannes Schickel
Instead of querying the event manager for the current mouse cursor coordinates kGetEvent now uses the saved mouse positions, which will assure every event will be processed with the correct coordinates instead of the current ones. Various other functions using SciEvent directly were adapted too. This fixes cursor click positions for the WinCE backend. Thanks to wjp and waltervn for helping me with this.
2011-03-08SCI: Remove unused argument to saidWillem Jan Palenstijn
2011-03-07Merge branch 'pe_exe' of https://github.com/clone2727/scummvm into ↵Matthew Hoops
clone2727-pe_exe
2011-03-07SCI: Initial handling of the views in Longbow Amiga. Still not rightmd5
2011-03-06SCUMM: Use the new WinCursor code in SCUMM HEMatthew Hoops
Also, updated the MacResManager cursor code to reflect the SCUMM resource extractor code changes
2011-03-06SCI: Fix KQ6 Mac inventory cursorsMatthew Hoops