Age | Commit message (Collapse) | Author |
|
drawChar is overloaded in FontSJIS. One takes a "Surface &" as first
parameter another one "void *", they furthermore have the exact same
number of required parameters. The one "void *" just had a few extra
parameters with default values. This resulted in a bug in SCUMM, where
"VirtScreen *" (a subclass of Surface) was passed instead of "VirtScreen &"
and thus the method taking "void *" was incorrectly used.
To make it easier to spot such bugs in the future I just removed the default
values and thus disallow such calls.
|
|
This fixes a potential problem with passing char values that would be sign-extended and yield unexpected results.
See http://msdn.microsoft.com/en-us/library/ms245348.aspx
|
|
This tries to make our code a bit more compliant with our code formatting
conventions. For future use, this is the command I used:
git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
|
|
The original check was correct, and the associated MG bug (#3049515) has
actually been fixed with another commit.
Fixes bug (regression) #3315639 - "Character Glitches in KQ4 SCI".
Many thanks to waltervn and wjp for their help on this
|
|
This fixes dialogs in Jones CD (bug #3297111) together
with 9e2c7f26d2e6c6081489365cbc07cd6edec362ad.
This grow was probably accidentally added in
6fda9a5067ca642ccf569a0845e170a6a74ce442. Assembly of KQ5CD and JonesCD
confirms it shouldn't be there.
|
|
This fixes coins disappearing in Mother Goose SCI1.1 (bug #3051136).
Filippos has confirmed the workaround is no longer necessary for the
menubar in LSL6 for which it was added.
|
|
Before only 255 was treated this way. This fixes part of the broken
dialog boxes in Jones CD (bug #3297111) which use priority 254,
and matches Jones CD disassembly.
|
|
shortcuts"
|
|
|
|
This fixes bug #3310782. However, as I was unable to get the games working in
a Mac emulator, this is an educated guess at this point.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This fixes the vertical black line glitch in the QfG3 start menu (#3293351)
|
|
|
|
Some backends may break as I only compiled SDL
|
|
|
|
|
|
It should have been removed in b40b87fdb5b4ee869cce55d852af409896b20c98
|
|
MKID_BE relied on unspecified behavior of the C++ compiler,
and as such was always a bit unsafe. The new MKTAG macro
is slightly less elegant, but does no longer depend on the
behavior of the compiler.
Inspired by FFmpeg, which has an almost identical macro.
|
|
|
|
|
|
|
|
(fixes Wolfgang closeup, room 720)
|
|
Found by GCC 4.6's -Wunused-but-set-variable
|
|
Fixes bug #3253208
|
|
Fixes several issues with the menu in KQ7. Thanks to vakons for his patch.
Fixes bug #3231867 - "KQ7 scrolling bug"
|
|
|
|
This allows us make _windowList private again
|
|
This can be used to see a list of the currently open windows. Also, added
a sanity check for the "al" command and performed some minor cleanup
|
|
|
|
This shows the current animation list, along with object properties,
positions and the scripts they belong to
|
|
|
|
Thanks to waltervn for his work and help on this
|
|
|
|
A regression from d2ad7898d93
|
|
|
|
Renamed some variables, functions and comments related to the
undithering code, to make them a bit easier to understand
|
|
|
|
|
|
- Added comments for all the different view unpacking algorithms
- Merged the SCI1 VGA and SCI1.1 VGA unpacking code
- Fixed views in Longbow Amiga (the palette is still broken, though)
- Used memset()/memcpy() instead of looping through
- Fixed a regression of rev. d2ad789 (LSL1 Spanish, bug #3135872)
|
|
Instead of querying the event manager for the current mouse cursor coordinates
kGetEvent now uses the saved mouse positions, which will assure every event
will be processed with the correct coordinates instead of the current ones.
Various other functions using SciEvent directly were adapted too.
This fixes cursor click positions for the WinCE backend.
Thanks to wjp and waltervn for helping me with this.
|
|
|
|
clone2727-pe_exe
|
|
|
|
Also, updated the MacResManager cursor code to reflect the SCUMM resource extractor code changes
|
|
|