| Age | Commit message (Collapse) | Author |
|---|
|
This reverts commit 9f74a6eda2355bb09b9b963be41509ed67016a6c.
|
|
This reverts commit 8524ebd699254a6786033f0e41b9a45c563feb11.
|
|
This reverts commit 17ca8d14b1e0d1960485029878c728ef4d6d6132,
except for a minor unrelated change to the workaround for bug #3605269
Conflicts:
engines/sci/sound/soundcmd.cpp
|
|
This reverts commit f019d5a4881c8ee42fa36ef0613d9e82b3b36297.
|
|
This reverts commit c6320a28e483e52b489cae8e86774008e030492b.
SSCI does not interpret signals on other channels than 15.
Conflicts:
engines/sci/sound/soundcmd.cpp
|
|
Game scripts are waiting indefinitely for a song, thus we change its dataInc
selector to prevent that from happening
|
|
SCI: Only stop after fading, if the song to be faded is faded down. Also,
reset the song signal when fading starts. It was set to -1 when fading
started in bug #3267956, thus it stopped immediately.
|
|
We now accept signals from all channels if channel 15 is missing. This
is a very rare edge case, but our behavior is now somewhat closer to what
the original interpreter seems to be doing. Mordack's appearance animation
is now synced properly. The more generic workaround works for songs 1840
and 1843, but not for 1849, which is still problematic and we still resort
to manually changing its dataInc selector
|
|
SSCI does
Previously, we set the signal of the sound objects themselves to -1, but set the
sound queue's signal to 0. This now matches the original behavior.
|
|
This is caused because songs 1840, 1843 and 1849 are all missing their special
SCI signaling channel (channel 15), so the game scripts wait indefinitely for
signals which are never set
|
|
Thanks to waltervn and clone2727 for the original patch. Tested LSL5
with this change, and the problematic sound in the mud wrestling scene
is handled correctly
|
|
|
|
It was using 'pri' instead of 'priority', apparently due to a
selector number->name translation error from 544daa5c31.
Thanks to waltervn for spotting this.
|
|
choosing kid"
In several SCI0 games, the parameter to kDoSoundFade can be null.
We handle that case, instead of adding individual workarounds per game
|
|
Powered by:
git ls-files "*.cpp" "*.h" "*.m" "*.mm" | xargs sed -i -e 's/[ \t]*$//'
|
|
|
|
|
|
This demo doesn't have any music, and the original doesn't work with any sound
driver, so don't error out when the sound driver can't be initialized properly
|
|
Now, sound effects in SCI1.1 games will no longer be incorrectly using the speech
sound volume. This avoids them being silenced in floppy games that are flagged
as not having speech. Fixes bug #3554709 - "SCI: Digital SFX don't play when
Override Global Audio set"
|
|
|
|
|
|
No functionality change has been made with this commit. This avoids
setting and getting the reg_t members directly, and is the basis of any
future work on large SCI3 scripts (larger than 64KB)
|
|
Fall back to the DOS soundtracks in Windows CD versions if the user picks
a non-General MIDI music device, as the Windows tracks only contain MIDI
music
|
|
|
|
This is used to set default settings for all custom game options when an
engine starts
|
|
The relevant code wasn't added in the newer commits - this was an
oversight from my part
|
|
This is a regression from 9fd66deb43a8ba1bd7b423cb6fe2b7177af74166 and, despite the commit message, was *not* fixed by 1736345906af095c863a62ded2638ce92c2a0704
|
|
find -name '*.h' -or -name '*.cpp' | xargs sed -r -i 's@\(([A-Za-z0-9]+)\*\)@(\1 *)@g'
This seems to have caught some params as well which is not undesirable IMO.
It also caught some strings containing this which is undesirable so I
excluded them manually. (engines/sci/engine/kernel_tables.h)
|
|
This toggle will be enabled again when a more user-friendly GUI option
is possible
|
|
SoundCommandParser
|
|
As used by KQ1 and MUMG. Sound still seems a bit off, but it's close.
|
|
|
|
|
|
|
|
|
|
A regression from commit 9654068
|
|
|
|
Mixed up mother goose is reported not to use that driver and even crash when trying to use it.
Play Id and instrument patch id seem to be different.
|
|
(Driver channels would get reserved via the 0x4b control, but they would never get released)
|
|
|
|
This fixes the sound effect heard in the "Day 1" screen
|
|
|
|
The sound handle should not be set in kDoSound(init), but in
kDoSound(play). This is verified against several SCI versions,
plus game scripts check if a sound slot is playing primarily
by checking its handle. Fixes the sound in Shivers and probably
an assortment of other sound related bugs
|
|
|
|
A regression from commit 9fd66de
|
|
|
|
- Unified the sound resource initialization code in
processInitSound() and reconstructPlayList()
- Now checking the "Mixed Adlib/MIDI" mode checkbox for SCI1.1 digital
audio sound effects, like it's done for SCI0 - SCI1 sound effects. If
it's unchecked, their MIDI counterparts will play instead, if
available
|
|
KQ6CD: Game stops responding in the catacombs"
kDoSoundSetHold is always called after kDoSoundPlay. A regression from
commit 4f3b85f4efc05affb7b4a7080e349360a3352048
|
|
|
|
|
