| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
Fixes bug #9770
|
|
|
|
Silences a false positive in MSVC
|
|
reg32_t was a transitive solution, before reg_t's were
adapted to use 32-bit addresses internally, and before
support for SCI3 was added. It was introduced as another
way to handle large script offsets in SCI3, and was only
used for the program counter (PC). It's no longer
needed, as we now support SCI3 script offsets using
reg_t's, so we can use make_reg32 in all cases where
we need to access offsets over 64KB
|
|
|
|
Fixes bug #10419
|
|
These are mostly used to silence known cases, for now. Some workarounds of this type have already been addded
|
|
Fixes bug #10420
|
|
Fixes entry into the Gypsy camp - bug #10418
|
|
|
|
|
|
|
|
|
|
The game works correctly now
|
|
|
|
|
|
|
|
|
|
I am not actually sure there is any scaling involved
in the demo, but it plays perfectly with this option
enabled, and this makes it consistent with the full
game options.
|
|
This is the solution discussed in bug #10568 ("SCI: PHANT1: Crash
on startup"). I believe that it's the correct solution, and that
ScummVM will do the right thing, but I'm not 100% sure.
|
|
|
|
Fixes Trac#10568.
|
|
SCI: High-quality "LarryScale" cel scaler for LSL7
|
|
ENGINES: Return unknown game variants with the list of detected games
|
|
|
|
|
|
The new approach is to delay kAnimate briefly (with an 68ms timeout)
while there is a zero-tick PalVary running, so that it has time to
trigger.
The previous workaround would immediately process a zero-tick
PalVaryInit/PalVaryReverse. This caused problems in QfG3 (bug #10304)
where it interfered with PalVaryPause.
The previous workaround could also be modified to handle pause/resume,
but this new approach should be closer to SSCI's behaviour, which used a
timer for a zero-tick PalVary too.
This fixes bug #10304, and keeps #5298 fixed too.
|
|
|
|
This commit introduces the following changes:
1. Graphics::loadThumbnail()
Now returns a boolean and takes a new argument skipThumbnail which
defaults to false. In case of true, loadThumbnail() reads past the
thumbnail data in the input stream instead of actually loading the
thumbnail. This simplifies savegame handling where, up until now,
many engines always read the whole savegame metadata (including
the thumbnail) and then threw away the thumbnail when not needed
(which is in almost all cases, the most common exception being
MetaEngine::querySaveMetaInfos() which is responsible for loading
savegame metadata for displaying it in the GUI launcher.
2. readSavegameHeader()
Engines which already implement such a method (name varies) now take
a new argument skipThumbnail (default: true) which is passed
through to loadThumbnail(). This means that the default case for
readSavegameHeader() is now _not_ loading the thumbnail from a
savegame and just reading past it. In those cases, e.g.
querySaveMetaInfos(), where we actually are interested in loading
the thumbnail readSavegameHeader() needs to explicitely be called
with skipThumbnail == false.
Engines whose readSavegameHeader() (name varies) already takes an
argument loadThumbnail have been adapted to have a similar
prototype and semantics.
I.e. readSaveHeader(in, loadThumbnail, header) now is
readSaveHeader(in, header, skipThumbnail).
3. Error handling
Engines which previously did not check the return value of
readSavegameHeader() (name varies) now do so ensuring that possibly
broken savegames (be it a broken thumbnail or something else) don't
make it into the GUI launcher list in the first place.
|
|
|
|
|
|
This wasn't explicitly marked as intentional but it very much looks it.
Committing separately in the unlikely case this needs to be reverted.
|
|
All other SCI games continue using the default scaler.
|
|
|
|
|
|
This ensures the detected speed will end up at the highest level. This
improves the detail in Yorick's room (96), and slightly changes the
timing in other rooms.
Fixes bug #10296.
|
|
|
|
Fixes Trac#10416.
|
|
The original script patch had the correct literal value but the
wrong selector name in the comment for the literal value, so when
it was converted to use a selector lookup in
c5dce17b1f1392feb8825aba5addbc3999eeaa51, the patch broke because
the wrong selector name was used.
Fixes Trac#10392. Closes gh-1107.
|
|
Seen when attempting to detect and/or run the Shivers 2 demo.
Closes gh-1106.
|
|
|
|
|
|
|
|
Fixes Trac#10361.
|
|
By default, frac_t is interpreted as signed. The resulting range isn't
large enough to store offsets, so we interpret it as unsigned here
instead. Fixes a crash in QfG1/Mac where instrument->loop_size is 49457.
|
|
|
|
Fixes Trac#10343.
|
