aboutsummaryrefslogtreecommitdiff
path: root/engines/sci
AgeCommit message (Collapse)Author
2017-02-27SCI: Fix up readString writing into too small bufferWillem Jan Palenstijn
This fixes QfG4 character import, which specifies a size of 52 for a buffer of size 40.
2017-02-26SCI: Clean up unnecessary castsWillem Jan Palenstijn
2017-02-26SIC32: Add RAMA French checksumsBastien Bouclet
2017-02-26SCI32: Add Phantasmagoria 2 French checksumsBastien Bouclet
2017-02-26SCI32: Add Lighthouse French checksumsBastien Bouclet
2017-02-26SCI: Clean up kRandom + allow 0 parameters via signaturesMartin Kiewitz
Also added in depth comments about the currently known variations Returning the RNG seed is now implemented (although it seems no games actually use this functionality, it seems to be just script bugs). Also remove Torin kRandom workarounds.
2017-02-18SCI: Remove check that is never triggeredWillem Jan Palenstijn
Since blockSize is asserted to be positive, buf can never be equal to _buf.
2017-02-18SCI: Fix unaligned readWillem Jan Palenstijn
2017-02-07SCI: Fix warningsWillem Jan Palenstijn
2017-02-05SCI: Fix more unsafe C-string usageColin Snover
2017-02-05SCI: Use strnlen instead of strlen to avoid buffer overflowsColin Snover
2017-01-31SCI: Add more comments to SQ4-floppy workaroundTarek Soliman
I did a full-score playthrough of the game with a warning() on the workaround condition as m_kiewitz suggested. The following room numbers were logged: * room#1: intro logo * room#21: time rip (intro and ending) * room#531: time pod time travel * room#290: astro chicken star background * room#376: right after astro chicken game over (called only once)
2017-01-31SCI: Expand workaround for script bug #3537232Tarek Soliman
More details in PR#889
2017-01-17SCI: Add more version info to SQ4 detection entryTarek Soliman
2017-01-16SCI32: Script patch priority drawing bug in MGDXColin Snover
This fixes the horse at the fountain drawing on top of the fountain instead of behind it.
2017-01-16SCI32: Add workarounds for MGDXColin Snover
2017-01-16SCI32: Add pic cel to CelInfo32 debugging outputColin Snover
2017-01-16SCI32: Fix handling of negative z-indexesColin Snover
Fixes the ego disappearing behind the castle doors in MGDX.
2017-01-16SCI32: Add workaround for Hoyle5Colin Snover
2017-01-16SCI32: Disable compression on Hoyle5 options filesColin Snover
Compression overhead takes up more space than uncompressed files, plus the uncompressed files it creates are marginally quicker and easier to debug with external tools.
2017-01-16SCI32: Add workarounds for KQ7 2.00bColin Snover
2017-01-16SCI32: Clarify comment about empty code path in cursor codeColin Snover
2017-01-16SCI32: Fix loading save games in KQ7 1.51Colin Snover
2017-01-16SCI: Remove unused SciEngine::speechAndSubtitlesEnabled methodColin Snover
2017-01-16SCI32: Fix spinloop in Hoyle5Colin Snover
Hoyle5 will spin on kGetTime between 15 and 300 ticks in multiple game scripts in order to delay execution (for example, after choosing opponents and clicking "okay"). This causes ScummVM to be unresponsive and wastes CPU time. This commit patches the spin subroutines to instead call a kernel function (kWait) that waits without a spin loop. This kernel function was removed in SCI2, and has been added back in ScummVM specifically for Hoyle5, so this patch will not work with the original interpreter.
2017-01-16SCI: Fix Possible Uninitialized Variable Usages.D G Turner
2017-01-14SCI: Fix Warnings about Copy Constructor Failing to Call Base Class.D G Turner
2017-01-12SCI32: Fix bad scroll delta in GK2 inventoryColin Snover
Fixes Trac#9648.
2017-01-12SCI32: Fix crash trying to clip invalid rects generated by transitionsColin Snover
In PQ4CD, when leaving the shooting range through the front door, some transition screen items will be generated that have invalid dimensions. SSCI simply clips these rectangles to zero.
2017-01-12SCI32: Add Hoyle5 to the list of game versionsColin Snover
2017-01-12SCI32: "Fix" renderer for PQ4CDColin Snover
PQ4CD and several other games contain a hack in two renderer methods to avoid rendering invalid screen items with zero or negative-dimension target rects. This prevents PQ4CD from crashing during the fifth phase of target practice.
2017-01-12SCI32: Add workarounds, transitions, fixes for PQ4CDColin Snover
2017-01-11SCI32: Fix uninitialised read of cursor background at start of gameColin Snover
2017-01-11SCI32: Add workarounds for PQ:SWATColin Snover
2017-01-11SCI32: Fix null references in Robot decoderColin Snover
Failing to reduce the size of the ScreenItem arrays causes other parts of the decoder (like RobotDecoder::getFrameSize) to try reading ScreenItems that were already destroyed and nulled out in the list. (In SSCI, the screen item count was held in a separate property instead of being part of the screen item list.)
2017-01-11SCI32: Remove backslashes from PQ:SWAT extra save game filesColin Snover
The original interpreter created subdirectories for each in-game profile, but copying this behaviour would add a lot of superfluous complexity to the save game system in ScummVM, and may not be portable to all supported platforms. Instead, when the game tries to save its files to a subdirectory, the backslash in the file name is replaced with an underscore so it can be created successfully on filesystems where backslash is an illegal file name character. This has a side-effect of causing all save games to be displayed under all profiles, instead of just the ones "belonging" to a particular profile, but this seems like a reasonable trade-off given that there is no reason to play this game with more than one profile.
2017-01-11SCI32: Remove unnecessary call to unallocColin Snover
When the Resource is deleted, it will deallocate the memory, so it is not necessary to do that manually.
2017-01-11SCI32: Improve mouse responsivenessColin Snover
This is most noticeable at the beginning of the game during benchmarking, where the benchmarking loop used to cause the mouse to get stuck for the duration of the benchmark.
2017-01-11SCI32: Add a workaround for the demo version of LSL7Filippos Karapetis
2017-01-10SCI: Fix Unused Variable Compiler Warning when SCI32 is not enabled.D G Turner
The bytesWritten variable is not used if SCI32 is not enabled. Fixed by adding this and success flag to the debug console print.
2017-01-09SCI32: Fix kSetLanguageColin Snover
2017-01-09SCI32: Fix bad rendering of Sierra logo in MGDXColin Snover
2017-01-09SCI32: Disable compression for Phantasmagoria save filesColin Snover
2017-01-09SCI32: Fix bad coordinates in PQ:SWAT demoColin Snover
2017-01-09SCI32: Fix Torin demo crashColin Snover
2017-01-09SCI32: Fix SQ6 demo crashColin Snover
2017-01-09SCI32: Fix GUIOs for all SCI2-2.1late gamesColin Snover
2017-01-09SCI32: Mark non-interactive Lighthouse demo as non-interactiveColin Snover
2017-01-09SCI32: Fix invalid bitmap deletion in AVIPlayerColin Snover
2017-01-09SCI32: Fix crashes and bad cel positioning in GK2 demoColin Snover