Age | Commit message (Collapse) | Author | |
---|---|---|---|
2017-02-27 | SCI: Fix up readString writing into too small buffer | Willem Jan Palenstijn | |
This fixes QfG4 character import, which specifies a size of 52 for a buffer of size 40. | |||
2017-02-26 | SCI: Clean up unnecessary casts | Willem Jan Palenstijn | |
2017-02-26 | SIC32: Add RAMA French checksums | Bastien Bouclet | |
2017-02-26 | SCI32: Add Phantasmagoria 2 French checksums | Bastien Bouclet | |
2017-02-26 | SCI32: Add Lighthouse French checksums | Bastien Bouclet | |
2017-02-26 | SCI: Clean up kRandom + allow 0 parameters via signatures | Martin Kiewitz | |
Also added in depth comments about the currently known variations Returning the RNG seed is now implemented (although it seems no games actually use this functionality, it seems to be just script bugs). Also remove Torin kRandom workarounds. | |||
2017-02-18 | SCI: Remove check that is never triggered | Willem Jan Palenstijn | |
Since blockSize is asserted to be positive, buf can never be equal to _buf. | |||
2017-02-18 | SCI: Fix unaligned read | Willem Jan Palenstijn | |
2017-02-07 | SCI: Fix warnings | Willem Jan Palenstijn | |
2017-02-05 | SCI: Fix more unsafe C-string usage | Colin Snover | |
2017-02-05 | SCI: Use strnlen instead of strlen to avoid buffer overflows | Colin Snover | |
2017-01-31 | SCI: Add more comments to SQ4-floppy workaround | Tarek Soliman | |
I did a full-score playthrough of the game with a warning() on the workaround condition as m_kiewitz suggested. The following room numbers were logged: * room#1: intro logo * room#21: time rip (intro and ending) * room#531: time pod time travel * room#290: astro chicken star background * room#376: right after astro chicken game over (called only once) | |||
2017-01-31 | SCI: Expand workaround for script bug #3537232 | Tarek Soliman | |
More details in PR#889 | |||
2017-01-17 | SCI: Add more version info to SQ4 detection entry | Tarek Soliman | |
2017-01-16 | SCI32: Script patch priority drawing bug in MGDX | Colin Snover | |
This fixes the horse at the fountain drawing on top of the fountain instead of behind it. | |||
2017-01-16 | SCI32: Add workarounds for MGDX | Colin Snover | |
2017-01-16 | SCI32: Add pic cel to CelInfo32 debugging output | Colin Snover | |
2017-01-16 | SCI32: Fix handling of negative z-indexes | Colin Snover | |
Fixes the ego disappearing behind the castle doors in MGDX. | |||
2017-01-16 | SCI32: Add workaround for Hoyle5 | Colin Snover | |
2017-01-16 | SCI32: Disable compression on Hoyle5 options files | Colin Snover | |
Compression overhead takes up more space than uncompressed files, plus the uncompressed files it creates are marginally quicker and easier to debug with external tools. | |||
2017-01-16 | SCI32: Add workarounds for KQ7 2.00b | Colin Snover | |
2017-01-16 | SCI32: Clarify comment about empty code path in cursor code | Colin Snover | |
2017-01-16 | SCI32: Fix loading save games in KQ7 1.51 | Colin Snover | |
2017-01-16 | SCI: Remove unused SciEngine::speechAndSubtitlesEnabled method | Colin Snover | |
2017-01-16 | SCI32: Fix spinloop in Hoyle5 | Colin Snover | |
Hoyle5 will spin on kGetTime between 15 and 300 ticks in multiple game scripts in order to delay execution (for example, after choosing opponents and clicking "okay"). This causes ScummVM to be unresponsive and wastes CPU time. This commit patches the spin subroutines to instead call a kernel function (kWait) that waits without a spin loop. This kernel function was removed in SCI2, and has been added back in ScummVM specifically for Hoyle5, so this patch will not work with the original interpreter. | |||
2017-01-16 | SCI: Fix Possible Uninitialized Variable Usages. | D G Turner | |
2017-01-14 | SCI: Fix Warnings about Copy Constructor Failing to Call Base Class. | D G Turner | |
2017-01-12 | SCI32: Fix bad scroll delta in GK2 inventory | Colin Snover | |
Fixes Trac#9648. | |||
2017-01-12 | SCI32: Fix crash trying to clip invalid rects generated by transitions | Colin Snover | |
In PQ4CD, when leaving the shooting range through the front door, some transition screen items will be generated that have invalid dimensions. SSCI simply clips these rectangles to zero. | |||
2017-01-12 | SCI32: Add Hoyle5 to the list of game versions | Colin Snover | |
2017-01-12 | SCI32: "Fix" renderer for PQ4CD | Colin Snover | |
PQ4CD and several other games contain a hack in two renderer methods to avoid rendering invalid screen items with zero or negative-dimension target rects. This prevents PQ4CD from crashing during the fifth phase of target practice. | |||
2017-01-12 | SCI32: Add workarounds, transitions, fixes for PQ4CD | Colin Snover | |
2017-01-11 | SCI32: Fix uninitialised read of cursor background at start of game | Colin Snover | |
2017-01-11 | SCI32: Add workarounds for PQ:SWAT | Colin Snover | |
2017-01-11 | SCI32: Fix null references in Robot decoder | Colin Snover | |
Failing to reduce the size of the ScreenItem arrays causes other parts of the decoder (like RobotDecoder::getFrameSize) to try reading ScreenItems that were already destroyed and nulled out in the list. (In SSCI, the screen item count was held in a separate property instead of being part of the screen item list.) | |||
2017-01-11 | SCI32: Remove backslashes from PQ:SWAT extra save game files | Colin Snover | |
The original interpreter created subdirectories for each in-game profile, but copying this behaviour would add a lot of superfluous complexity to the save game system in ScummVM, and may not be portable to all supported platforms. Instead, when the game tries to save its files to a subdirectory, the backslash in the file name is replaced with an underscore so it can be created successfully on filesystems where backslash is an illegal file name character. This has a side-effect of causing all save games to be displayed under all profiles, instead of just the ones "belonging" to a particular profile, but this seems like a reasonable trade-off given that there is no reason to play this game with more than one profile. | |||
2017-01-11 | SCI32: Remove unnecessary call to unalloc | Colin Snover | |
When the Resource is deleted, it will deallocate the memory, so it is not necessary to do that manually. | |||
2017-01-11 | SCI32: Improve mouse responsiveness | Colin Snover | |
This is most noticeable at the beginning of the game during benchmarking, where the benchmarking loop used to cause the mouse to get stuck for the duration of the benchmark. | |||
2017-01-11 | SCI32: Add a workaround for the demo version of LSL7 | Filippos Karapetis | |
2017-01-10 | SCI: Fix Unused Variable Compiler Warning when SCI32 is not enabled. | D G Turner | |
The bytesWritten variable is not used if SCI32 is not enabled. Fixed by adding this and success flag to the debug console print. | |||
2017-01-09 | SCI32: Fix kSetLanguage | Colin Snover | |
2017-01-09 | SCI32: Fix bad rendering of Sierra logo in MGDX | Colin Snover | |
2017-01-09 | SCI32: Disable compression for Phantasmagoria save files | Colin Snover | |
2017-01-09 | SCI32: Fix bad coordinates in PQ:SWAT demo | Colin Snover | |
2017-01-09 | SCI32: Fix Torin demo crash | Colin Snover | |
2017-01-09 | SCI32: Fix SQ6 demo crash | Colin Snover | |
2017-01-09 | SCI32: Fix GUIOs for all SCI2-2.1late games | Colin Snover | |
2017-01-09 | SCI32: Mark non-interactive Lighthouse demo as non-interactive | Colin Snover | |
2017-01-09 | SCI32: Fix invalid bitmap deletion in AVIPlayer | Colin Snover | |
2017-01-09 | SCI32: Fix crashes and bad cel positioning in GK2 demo | Colin Snover | |