aboutsummaryrefslogtreecommitdiff
path: root/engines/scumm
AgeCommit message (Collapse)Author
2018-01-31SCUMM: Replace UB-triggering serialization code with Common::SerializerColin Snover
Fixes Trac#10342.
2018-01-31SCUMM: Fix stack overflow initializing localsColin Snover
This happens when clicking on the triangular button in room 27 in The Dig. There are probably several other places where this overflow happens, since there are several different `int args[16]` in the code (and many more `int args[` of various sizes, not all of which are at least NUM_SCRIPT_LOCAL).
2018-01-31SCUMM: Fix stack overflow initializing localsColin Snover
This happens at least when trying to right click on the motorcycle at the start of Full Throttle.
2018-01-31SCUMM: implement lipsync for v7 gamesAdrian Frühwirth
2018-01-31SCUMM: really implement lipsyncGiovanni Bajo
It looks like the code was there, but it was never fully implemented because _curSoundPos was never being incremented. Experimentally, it looks like it works if it is a 60FPS counter.
2018-01-27GUI: Remove Dialog::markAsDirty to expose full GUI redrawsBastien Bouclet
2017-12-22SCUMM HE: Add early version of Let's Explore the Farm with Buzzy.Kirben
2017-12-01SCUMM: Fix array overflow writing var when no current script is setColin Snover
This situation is triggered normally when _currentScript is 0xFF, but it could potentially also happen if _currentScript is some other number >= NUM_SCRIPT_SLOT, so the check is a bit more conservative than it might appear to need to be.
2017-12-01SCUMM: Fix signed integer overflow reading default v70HE cursorColin Snover
2017-12-01SCUMM: Fix buffer overflow reading default v70HE cursorColin Snover
2017-12-01SCUMM: Fix possible return of garbage valuesColin Snover
2017-12-01SCUMM: Fix UB shifting negative integers in ActorColin Snover
2017-12-01SCUMM HE: Fix UB shifting negative integersColin Snover
2017-11-27SCUMM: Revert skipping of MM C64 demo original save screen display attemptEugene Sandulenko
As per discussion in bug #10116.
2017-11-26SCUMM: Do not do anything for real with original save screen in MM C64 demoEugene Sandulenko
2017-11-25SCUMM: Do not try to show original save/load screen in C64 demoEugene Sandulenko
Fixes bug #10116
2017-11-12SCUMM: Fix race condition in MOD playerColin Snover
Fixes Trac#6272.
2017-11-10ALL: Fix misuse of comma operatorColin Snover
2017-10-31SCUMM: Prevent false detection of Steam gamesBen Castricum
2017-10-07SCUMM: Fix compilation on systems without USE_RGB_COLORColin Snover
2017-10-07ENGINES: Remove default1x scaler flagColin Snover
This flag is removed for a few reasons: * Engines universally set this flag to true for widths > 320, which made it redundant everywhere; * This flag functioned primarily as a "force 1x scaler" flag, since its behaviour was almost completely undocumented and users would need to figure out that they'd need an explicit non-default scaler set to get a scaler to operate at widths > 320; * (Most importantly) engines should not be in the business of deciding how the backend may choose to render its virtual screen. The choice of rendering behaviour belongs to the user, and the backend, in that order. A nearby future commit restores the default1x scaler behaviour in the SDL backend code for the moment, but in the future it is my hope that there will be a better configuration UI to allow users to specify how they want scaling to work for high resolutions.
2017-09-22ALL: Specify the DisposeAfterUse constructor argument for dynamic memory ↵Bastien Bouclet
write streams
2017-08-21SCUMM: Update MD5 include fileBen Castricum
2017-08-21SCUMM: Add detection for German version of Spy Fox 1, fixes bug #9732Ben Castricum
2017-08-17SCUMM: Prevent darkenPallete() in Room 0 in FT, fixes bug #9871Ben Castricum
2017-08-11SCUMM: Moonbase: Mark original bug as fall through to silence GCC 7 warningEugene Sandulenko
2017-08-11SCUMM: Add missing return statementEugene Sandulenko
2017-08-11SCUMM: Add missing break to INSANE code. Thanks to eriktorbjorn and GCC7Eugene Sandulenko
2017-08-10SCUMM: Don't list Amiga version of The Secret of Monkey Island as VGA, as it ↵Kirben
leads to confusion.
2017-08-06JANITORIAL: Silence some more GCC 7 fall through warningsTorbjörn Andersson
2017-08-06JANITORIAL: Increase buffer size to fix potential overflowTorbjörn Andersson
Caught by GCC 7 (though the warning seemed misleading to me). Since SoundDesc->name can potentially be 14 characters "%s_reg%03d.fla" can be 25 characters, plus the terminating \0.
2017-08-06JANITORIAL: Silence GCC warningTorbjörn Andersson
Since case 64 was added for "MM C64 Costume Animation", and considering the way it's written to only affect game version 0, it is clearly an intentional fall through.
2017-08-04SCUMM: Fix Typo in Detection Table Comment.D G Turner
No functional change.
2017-07-30SCUMM: MI2 kill tune 113 on start of next, Fixes bug #1410 / Booty IslandBen Castricum
Fix the "MI2: Two soundtracks playing at once" bug from the bug tracker. It's triggered when the player enters the kiosk for the second time and leaves before tune 113 is started.
2017-07-30SCUMM: MI2 kill tune 107 on start of next, Fixes bug #1410 / Scabb IslandBen Castricum
Fix the "MI2: Two soundtracks playing at once" bug from the forum. It's triggered when the player is moving faster then the scripts expect causing the "stop tune 117" command be executed before the start of the tune. Effectily creating a hanging tune 107. This patch kills the tune when this sitation is detected.
2017-02-21Merge pull request #902 from segrax/Fix_4556Eugene Sandulenko
SCUMM: Fix bug #4556 (Maniac: Purple Tentacle appears in Lab after being chased out)
2017-02-21Merge pull request #903 from segrax/Fix_4112Eugene Sandulenko
SCUMM: Fix bug #4112 (MANIAC: Power never returns)
2017-02-21SCUMM: MM V0: Fix actors skipping between certain walk-boxesRobert Crossfield
2017-02-15SCUMM: MM V0: Fix an issue with Sandy appearing to slide across a walkboxRobert Crossfield
2017-02-14SCUMM: Cleanup Maniac Mansion workaroundsRobert Crossfield
2017-02-14SCUMM: Fix bug #4112. If you enter the lab while Dr. Fred has the power off, ↵Robert Crossfield
the power won't be turned back on as the script is killed
2017-02-13SCUMM: Fix bug #4556 (Maniac C64/V1/V2: Purple Tentacle appears in Lab Entry ↵Robert Crossfield
after being chased out)
2017-01-13Merge pull request #877 from segrax/Fix_2285Eugene Sandulenko
SCUMM: Fix bug #2285 (ZAK C64/V1/V2 Caponians dont disguise after using crystal)
2016-12-28SCUMM: Fix bug #2285 (ZAK C64/V1/V2 Caponians don't disguise after using ↵Robert Crossfield
blue crystal)
2016-12-27SCUMM: Fix bug #6817 (V1 Actors drawn 1 line too high)Robert Crossfield
2016-12-27SCUMM: Fix bug #4515 (Dr. Fred facing wrong way in lab cutscene)Robert Crossfield
2016-12-06SCUMM HE: Silence GCC indentation warningTorbjörn Andersson
2016-11-29ALL: game state => saved gameBen Castricum
2016-11-29ALL: Fix usage of 'etc.'Ben Castricum
2016-11-27SCUMM HE: Fix crash in Moonbase distrotionEugene Sandulenko