aboutsummaryrefslogtreecommitdiff
path: root/engines/scumm
AgeCommit message (Collapse)Author
2013-11-03SCUMM: Fix potential memory leak. CID 1003586Eugene Sandulenko
2013-11-01SCUMM: More renaming for playersFilippos Karapetis
Rename "player" directory to "players", and reintroduce the "player_" file prefix. This has been done after sev's request. "players/player_foo.*" is more descriptive, and avoids potential name clashes in libraries
2013-11-01SCUMM: Move all players to a separate "player" directoryFilippos Karapetis
There are 34 player .cpp/.h player files, so they have been placed in their own directory, to logically separate them from the rest of the engine
2013-10-05SCUMM: Make all HE saves prepend the target nameMatthew Hoops
This makes HE follow the ScummVM convention of using the target name everywhere. It also fixes having more than one team in both soccer and football. Loading old saves will still work and they will be tried if the newer save names are not found.
2013-10-03SCUMM: Fix unused variable warningsRodrigo Rebello
2013-09-27SCUMM: Add US Windows preview of Humongous Catalog.Kirben
2013-09-12Merge pull request #378 from lordhoto/pluggable-engines-translationsJohannes Schickel
RFC: Pluggable Engines: I18N: Move specification of engine specific files to enginedir/POTFILES
2013-09-12Merge pull request #360 from lordhoto/scumm-adEugene Sandulenko
SCUMM: Implement original AD AdLib output.
2013-08-26SCUMM: Fix COMI regression, after commit ↵Kirben
84d1d28373d782464bd46b10abd6b092f7eb6367.
2013-08-18INSANE: Mark fall through case statement. CID 1003733Eugene Sandulenko
2013-08-18SCUMM: Read the SMAP size, not the SMAP tag itselfTorbjörn Andersson
This will obviously make 'smapLen' a lot smaller in most cases, so there may be regressions. But I hope this is correct, though I don't know why the size is big-endian while the offset is little- endian.
2013-08-18SCUMM: Remove unnecessary NULL check, CID 1003629Torbjörn Andersson
Since _actors[i]->_sound is an array, it can't ever be NULL.
2013-08-18SCUMM: Remove unnecessary NULL check, CID 1003628Torbjörn Andersson
Since ah->data is an array, it can't ever be NULL.
2013-08-18SCUMM: Remove unnecessary NULL check, CID 1003627Torbjörn Andersson
Since ah->data is an array, it can't ever be NULL.
2013-08-16SCUMM: Always confirm quit when required in HE games.Kirben
2013-08-16SCUMM: Add new variables in Nimbus Games version of Putt-Putt Saves the Zoo.Kirben
2013-08-15SCUMM: Add Remastered version of Putt-Putt Saves the Zoo from Nimbus Games.Kirben
2013-08-12I18N: Move specification of engine specific files to enginedir/POTFILES.Johannes Schickel
This allows to keep the engines to specfiy the files for translation close to the engine sources itself. Thanks to criezy for his suggestion on this approach.
2013-08-08COMMON: Rename ConfigFile to INIFile.Johannes Schickel
This clears up that 'ConfigFile' is actually a class handling only INI-files.
2013-08-07Merge pull request #365 from lordhoto/protected-pixelsJohannes Schickel
Make Graphics::Surface::pixels protected.
2013-08-04SCUMM: Fix backwards-in-same-array case of v72he::copyArray.Alyssa Milburn
2013-08-04SCUMM: Add detection/version for Moonbase Commander v1.1.Alyssa Milburn
2013-08-04SCUMM: Add comment about getPixels uses in BaseCostumeRenderer.Johannes Schickel
2013-08-04SCUMM: Fix Loom (and some other graphics regressions).Johannes Schickel
These are regressions from c05cb7f3bbcf4d64d4a938e0eb42065d8f3d3038. They were caused by VirtualScreen::getPixels differing from Surface::getBasePtr and I accidently used the former in some cases in the conversion. I also fixed a bug in debugger.cpp which exchanged x and y.
2013-08-03SCUMM: Do not set Surface::pixels directly anymore.Johannes Schickel
2013-08-03SCUMM: Take advantage of Surface::getPixels.Johannes Schickel
2013-08-03SCUMM: Prefer getBasePtr over direct Surface::pixels access.Johannes Schickel
2013-07-24SCUMM: Implement original AD AdLib output.Johannes Schickel
This implements the original AD output and enables it for Indy3 and Loom DOS. It is not enabled for Monkey Island DOS because it would break multi MIDI support. However, there are also drawbacks for Indy3. In the catacombs we were able to play sfx (Indy walking around) and the background music at once. This was not supported in the original player and thus also does not work with this reimplementation. This fixes bug #2027877 "INDY3: Non-Looping Sound Effects". This fixes bug #1159581 "ADLIB: Adlib Emulation doesn't Respect Volume Settings" for Indy3 and Loom.
2013-07-21SCUMM: Fix test before running VAR_SAVELOAD_SCRIPT2 (CID 1004135)Torbjörn Andersson
This doesn't really make any difference because either both VAR_SAVELOAD_SCRIPT and VAR_SAVELOAD_SCRIPT2 exist, or neither does. But it feels more correct this way.
2013-07-18Merge pull request #345 from countingpine/patch-1Johannes Schickel
SCUMM: More precise Player_Mac::durationToSamples
2013-07-16SCUMM: Better Player_Mac::durationToSamplescountingpine
Uses the fact that 4*480*480 == 225 << 12, and the identity (a*b)>>n == (a>>n)*b + ((a%(1<<n))*b)>>n (assuming non-overflowing math), except the rhs uses smaller intermediate values and does not overflow(*). Compared to the original code, this uses 1 fewer division and eliminates the rounding error. (*) Technical note: In some cases the right hand side of the above identity still has possibilities of intermediate overflow, but only if b > (1 << n), or if (b << n) overflows, neither of which are true here.
2013-07-15INSANE: Fix CID 1003734. Missing break in switchEugene Sandulenko
2013-07-15INSANE: Fix CID 1003733. Missing break in switch.Eugene Sandulenko
In fact the code was wrong there due to copy-paste error
2013-07-14JANITORIAL: Remove trailing whitespaceSven Hesse
2013-07-09SCUMM: Add another French Windows version of Pajama Sam 2.Kirben
2013-07-06SCUMM: Fix initGM() buffer overflow (CID 1032513)Torbjörn Andersson
We're clearly using 12 bytes, not 11.
2013-06-23SCUMM: Corrected Russian Full Throttle variant namesEugene Sandulenko
2013-06-22SCUMM: Added another Russian variant of Full ThrottleEugene Sandulenko
2013-06-04SCUMM: Verify sample width in Digital iMUSE callback. CID 1002112Torbjörn Andersson
Verify that 'bits' really is one of 8, 12 or 16 before decoding the data. It's probably always the case (unless the data files are damaged) but if it isn't we'll either try to queue NULL to the audio stream, or queue the same buffer more than once, or free the buffer more than once. All of which are bad, though Coverity only noticed the last of these cases.
2013-06-02SCUMM: Remove unused variable _quitTorbjörn Andersson
CID 1003018
2013-05-11SCUMM: Clean-up of Roland GS codetcarey
1. Remove _sc55 bool. All Roland GS-capable devices have MT-32 sound/drum maps, so they should always be used when _enable_gs is set. 2. Always enable _native_mt32 if Roland GS mode is selected. I don't know why I never did this originally, since _enable_gs is automatically disabled for SCUMM v6+ games that use General MIDI tracks instead of MT-32 music. 3. Set master tune for GS devices to 442.0kHz. This is the master tune setting for the MT-32.
2013-05-02COMMON: Change kPlatformPC to kPlatformDOSMatthew Hoops
"PC" was very ambiguous and now it matches what we show in the GUI. This also corrects sword2's platform to Windows.
2013-05-01SCUMM: Change NUM_SCRIPT_LOCALS to NUM_SCRIPT_LOCALTorbjörn Andersson
For consistency with NUM_SCRIPT_SLOT.
2013-05-01SCUMM: Fix out-of-bounds access in runScript() debug messagesTorbjörn Andersson
I believe this fixes CID 1003954, 1003957, 1003958, 1003962 and 1003966.
2013-04-30SCUMM: CleanupTorbjörn Andersson
We only need to initialize 'args' in runInventoryScript() when we are actually using them.
2013-04-30SCUMM: Use correct array size when calling initializeLocals()Torbjörn Andersson
The initializeLocals() function assumes that it can copy 25 elements when being provided an array of values. But this array was frequently a lot smaller than that. I've introduced a constant for the number of locals (though VirtualMachineState has one more for some reason), and fixed the array sizes in a number of places. CID 1003951, 1003952, 1003953, 1003955, 1003956, 1003959, 1003960, 1003961, 1003963, 100394, 1003965
2013-04-29SCUMM HE: fix crash introduced in a10ad272a84Eugene Sandulenko
2013-04-29SCUMM: Fix o100_videoOps subOp 0Matthew Hoops
football2002 endzone videos now display
2013-04-28SCUMM HE: Plug memory leak. CID 1003582Eugene Sandulenko
2013-04-24SCUMM: Fix non-terminated string. CID 1003867Eugene Sandulenko