| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Also-By: Matthew Hoops <clone2727@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This fixes an original game glitch where the main options menu background
image is drawn one pixel too high.
Fixes Trac#10496.
|
|
|
|
|
|
This commit introduces the following changes:
1. Graphics::loadThumbnail()
Now returns a boolean and takes a new argument skipThumbnail which
defaults to false. In case of true, loadThumbnail() reads past the
thumbnail data in the input stream instead of actually loading the
thumbnail. This simplifies savegame handling where, up until now,
many engines always read the whole savegame metadata (including
the thumbnail) and then threw away the thumbnail when not needed
(which is in almost all cases, the most common exception being
MetaEngine::querySaveMetaInfos() which is responsible for loading
savegame metadata for displaying it in the GUI launcher.
2. readSavegameHeader()
Engines which already implement such a method (name varies) now take
a new argument skipThumbnail (default: true) which is passed
through to loadThumbnail(). This means that the default case for
readSavegameHeader() is now _not_ loading the thumbnail from a
savegame and just reading past it. In those cases, e.g.
querySaveMetaInfos(), where we actually are interested in loading
the thumbnail readSavegameHeader() needs to explicitely be called
with skipThumbnail == false.
Engines whose readSavegameHeader() (name varies) already takes an
argument loadThumbnail have been adapted to have a similar
prototype and semantics.
I.e. readSaveHeader(in, loadThumbnail, header) now is
readSaveHeader(in, header, skipThumbnail).
3. Error handling
Engines which previously did not check the return value of
readSavegameHeader() (name varies) now do so ensuring that possibly
broken savegames (be it a broken thumbnail or something else) don't
make it into the GUI launcher list in the first place.
|
|
|
|
See commit 7cbf5a9289 for more information.
|
|
|
|
|
|
|
|
Code matches disassembly and works like in the original. I can't spot
anything out of the ordinary with regards to audio playback either.
|
|
|
|
Despite what the comment says this does not seem to be in the original
game and I cannot replicate this in either the original or a current
ScummVM build. It is highly likely that this was one of several sprite
offset bugs which were present in our implementation earlier but which
have since been fixed.
|
|
three
If you don't have the appointment card yet and use the map to go to
Seedy Street Bud ends up being teleported back to the mall.
Because of the destination coordinates which warp Bud past x==583
Violet's logic, which makes him refuse Bud entrance to the dentist,
triggers. On top of that the graphics end up all garbled which
indicates that even worse things happen under the hood.
To work around this we only trigger Violet if Bud actually _walked_
past the trigger coordinates (as opposed to using the map).
This fixes Trac#10452.
|
|
23fd97c99a
|
|
When the 'mof' opcode was added in commit 1946dead77 it was implemented
as a NOOP, but what it actually should do is disable the mouse (set
_cursorState to kCursorStateDisabledHidden).
This is used in at least the Spanish and Polish versions of the game to
work around an earlier script bug which allowed the player to use the
mouse while freeing the professor in part two.
This commit fixes the 'mof' instruction so that the original script works
as intended in those versions that ship with the fix.
TODO: Add a workaround for those game versions which don't do the 'mof'
themselves.
|
|
This commit adds the 'buv' and 'c0v' opcodes which are used to set speech
volume. Because these only seem to be used once in the English demo and
we right now playback all speech at kMaxSoundVolume anyway we can treat
them as NOOPs.
This fixes a bug in said demo which resulted in Bud being unable to talk
to Del.
|
|
|
|
|
|
The original game unconditionally reads into _sprC02Table[] in
updateSprite() which results in out-of-bounds reads when a sprite's
_state is -1. To make sure that sprites update correctly under all
circumstances we always reset a sprite's animation data when it is
disabled (_state == -1). This most prominently fixes a bug where
Lola's transition from dancing -> sitting happens too late.
Fixes Trac#6644.
|
|
|
|
|
|
|
|
|
|
Setting _mousePosY is only necessary if we actually set the cursor
position which we currently don't do. I don't plan on enabling it
but for the sake of matching disassembly let's add the required
warpMouse() call and disable the whole code block for now.
|
|
|
|
|
|
|
|
Fixes Trac#6376, Trac#6377 and probably many more unreported instances
of wrong audio samples being played.
|
|
Fixes Trac#6645.
|
|
infobar.txt contains all text used for the sentence bar and, among
other things, the prepositions to use for the "Use" and "Give" verbs.
In the English and Spanish versions of the game the preposition for
"Use" ("With" and "Con", respectively) is incorrectly stored in
capitalized form which this commit fixes.
Fixes Trac#10445.
|
|
|
|
|
|
The new _panelState tells if the panel is currently in the process
of being toggled between icon-style and text-style verbs and thus
animated.
The new _panelStyle tells wich verb-style the panel currently uses.
The new _panelType tells which mode the panel currently is in:
- verbs + inventory (normal)
- empty (used for dialogs)
- save, load, play, quit buttons
- save/load savegame
Also, switchPanelType() has been renamed to togglePanelStyle() and
kInputKeyToggleInventory to kInputKeyTogglePanelStyle to better
match the above changes.
_switchPanelFlag has been dropped in favor of using the new _panelState.
TODO: Store _panelStyle in savegames.
|
|
|
|
|
|
Escape, period or right mouse click skips one sentence at a time.
|
|
When Bud is walked to specific coordinates using the 'buw' opcode the
walkable area is not enforced (_locationMaskIgnore == true).
This is usually not a problem because the player is not allowed to click,
however, when entering the club, this allows the player to move Bud to
coordinates from which he can never return, leaving him stuck there.
As a workaround, do not ignore the location mask during this specific
action when entering the club.
Fixes Trac#5838.
|
|
|
|
Some backgrounds use colors in the reserved range [0xE0-0xF8] in a
walkable area which results in a number of pixels being falsely drawn
in the foreground (on top of Bud).
This fixes Trac#10423 to work around these original game bugs and
also removes the workaround for location 14 which does not seem to be
needed anymore.
|
