Age | Commit message (Collapse) | Author | |
---|---|---|---|
2017-11-21 | XEEN: Add a new iterator class for reading event parameters | Paul Gilbert | |
This make things cleaner for reading in 16 and 32 bit parameters in different opcodes. Also, it solves a crash in the give/take opcode where the third mode/value pair isn't used for all sub-modes, so the code was previously reading beyond the end of the parameters | |||
2017-11-21 | TSAGE: Fix loading savegames with unreferenced dynamic objects | Paul Gilbert | |
2017-11-21 | MADS: Fix crash when Rex is locked in cell | Paul Gilbert | |
2017-11-21 | FULLPIPE: Fix big picture array indexing | Bastien Bouclet | |
Fixes #10322. | |||
2017-11-20 | TSAGE: Fix crash on RTL | Colin Snover | |
2017-11-20 | TSAGE: Fix deadlocks in audio code | Colin Snover | |
Fixes Trac#6618, Trac#6638, Trac#7011. | |||
2017-11-20 | TSAGE: Fix invalid C-style casts to unrelated classes | Colin Snover | |
2017-11-20 | TSAGE: Remove member access of null pointer | Colin Snover | |
2017-11-20 | Merge pull request #1064 from csnover/tinsel-oom | Paul Gilbert | |
TINSEL: Increase maximum number of objects | |||
2017-11-20 | PRINCE: Added detection for alternative Russian version | Eugene Sandulenko | |
2017-11-20 | FULLPIPE: Fix loading inventory items from saves | Bastien Bouclet | |
In C++ the function parameter evaluation order is undefined. The count property was being read first from the stream, instead of the itemId. Fixes #10324. | |||
2017-11-19 | TINSEL: Increase maximum number of objects | Colin Snover | |
This needs to be at least 374 to avoid crashes in the in-game save/load dialogues with save games using the maximum 40 letters per save game, so just round up to the next power of two (which increases memory usage by a whopping ~20KiB) to give more than enough space for long save game names. Fixes Trac#6748. | |||
2017-11-19 | SCI32: Add Phantasmagoria IT detection entry | Colin Snover | |
Fixes Trac#10157. | |||
2017-11-19 | SCI32: Add KQ7 1.51 FR detection entry | Colin Snover | |
Fixes Trac#10301. | |||
2017-11-19 | XEEN: Fix display of multi-page town messages | Paul Gilbert | |
2017-11-19 | XEEN: Cleaner implementation of changing script line number | Paul Gilbert | |
2017-11-19 | XEEN: Extra comments for script methods | Paul Gilbert | |
2017-11-19 | DRASCULA: Clean up logic in enterRoom() | Filippos Karapetis | |
2017-11-19 | DRASCULA: Document several updateVisible() calls | Filippos Karapetis | |
2017-11-19 | SCI: Fix UB shifting negative integers | Colin Snover | |
2017-11-19 | XEEN: Clean up script execution line changes | Paul Gilbert | |
2017-11-18 | XEEN: Implement do nothing opcode | Paul Gilbert | |
2017-11-18 | XEEN: Fixes for cmdTakeOrGive script opcode | Paul Gilbert | |
2017-11-18 | XEEN: Fix number of spells per class array & constant | Paul Gilbert | |
2017-11-18 | XEEN: Fix size of quest flags, rename for clarity | Paul Gilbert | |
2017-11-18 | XEEN: Fixes for Character class | Paul Gilbert | |
2017-11-18 | DRASCULA: Fix ego manipulation for translated versions | Eugene Sandulenko | |
2017-11-18 | FULLPIPE: Fix memory leaks restoring save games | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks of arcade keys | Colin Snover | |
Fixes Trac#9657. | |||
2017-11-18 | FULLPIPE: Remove manual memory management and fix in-game save/load | Colin Snover | |
2017-11-18 | FULLPIPE: Fix use-after-free in ModalMainMenu | Colin Snover | |
Pointers to objects which are invalidated when the scene gets unloaded may continue to be accessed if a mouse hover event is dispatched to the ModalMainMenu. | |||
2017-11-18 | FULLPIPE: Fix memory leaks of MessageQueues when clearing GlobalMessageQueueList | Colin Snover | |
2017-11-18 | FULLPIPE: Make list item ownership comments more consistent | Colin Snover | |
2017-11-18 | FULLPIPE: Fix leaks of ExCommands loaded from an archive | Colin Snover | |
Nearly every construction of an ExCommand in the engine sets flag 2 of _excFlags. It may even be that the remaining ones that don't are themselves bugs. This flag is needed in order for an ExCommand to be cleaned up when its parent MessageQueue is deleted. | |||
2017-11-18 | FULLPIPE: Remove unnecessary member array clear in destructor | Colin Snover | |
2017-11-18 | FULLPIPE: Fix leaks of MessageQueues | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks of Interactions | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks of PreloadItems | Colin Snover | |
2017-11-18 | FULLPIPE: Remove manual memory management of use list | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks of InventoryPoolItem | Colin Snover | |
2017-11-18 | FULLPIPE: Fix leaks of DynamicPhases | Colin Snover | |
I am not entirely sure this is a correct fix for these leaks; there is still the issue of the last member of _dynamicPhases being invalidated and not removed sometime before the destruction of Movement. Also, some of the items in this array are not actually owned by Movement so deleting them will cause double-frees or use-after-frees. It may be the case that a second list should be maintained instead containing only the objects that are created internally within Movement. Further testing will tell for sure. | |||
2017-11-18 | FULLPIPE: Fix memory leaks of MctlItems in MctlCompound | Colin Snover | |
2017-11-18 | FULLPIPE: Clarify ownership of DynamicPhase::_exCommand | Colin Snover | |
2017-11-18 | FULLPIPE: Clarify ownership of pointer arrays in StaticANIObject | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leaks in PictureObject, Background | Colin Snover | |
2017-11-18 | FULLPIPE: Use flag enum | Colin Snover | |
2017-11-18 | FULLPIPE: Fix memory leak of graph nodes and lists | Colin Snover | |
2017-11-18 | FULLPIPE: Remove unnecessary constructors | Colin Snover | |
These appear to be default member-wise copy constructors or POD constructors that zero all members. I suspect that quite a few pointer-taking constructors are actually supposed to be copy-constructors but since they don't all just do default member-wise copies I do not feel confident in changing them without verifying that there are not separate copy constructors in the disassembly, and I don't have the database for this game. | |||
2017-11-18 | FULLPIPE: Fix memory leaks, ownership issues with various point lists | Colin Snover | |
2017-11-18 | FULLPIPE: Disable some unused code paths | Colin Snover | |