diff options
| author | Max Horn | 2009-09-01 13:03:12 +0000 |
|---|---|---|
| committer | Max Horn | 2009-09-01 13:03:12 +0000 |
| commit | 11a16fa30e8ea8dd5559d694cb9be660668d7842 (patch) | |
| tree | 4af45de5a78ec03b19f9ea1ea42bde2b3d461354 /engines/sci | |
| parent | 8e28469f1f8aa1c3b7ade6bcba9bef1d6dec3b8c (diff) | |
| download | scummvm-rg350-11a16fa30e8ea8dd5559d694cb9be660668d7842.tar.gz scummvm-rg350-11a16fa30e8ea8dd5559d694cb9be660668d7842.tar.bz2 scummvm-rg350-11a16fa30e8ea8dd5559d694cb9be660668d7842.zip | |
Coding best practice: Whenever possible, pass objects by reference instead of by value. Also make variables or data table which are only used locally "static".
svn-id: r43882
Diffstat (limited to 'engines/sci')
| -rw-r--r-- | engines/sci/detection.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/engines/sci/detection.cpp b/engines/sci/detection.cpp index 6f25d1cdc1..d0ae45a31f 100644 --- a/engines/sci/detection.cpp +++ b/engines/sci/detection.cpp @@ -163,7 +163,7 @@ public: const ADGameDescription *fallbackDetect(const Common::FSList &fslist) const; }; -Common::String convertSierraGameId(Common::String sierraId, uint32 *gameFlags) { +static Common::String convertSierraGameId(const Common::String &sierraId, uint32 *gameFlags) { // TODO: SCI32 IDs if (sierraId == "demo") |