aboutsummaryrefslogtreecommitdiff
path: root/engines/lure
AgeCommit message (Collapse)Author
2012-06-30LURE: Fix engine crash in copy protection screen with AZERTY keyboardThierry Crozat
Fixes bug #3539031 - "LURE: Crash at Copy Protection Screen". This reverts the previous fix which only worked for QWERTY keyboards and made the issue worse for AZERTY keyboards. It now uses the ASCII code instead of the keycode for the sanity check.
2012-06-29LURE: Fix engine crash in copy protection screen.D G Turner
Fixes bug #3539031 - "LURE: Crash at Copy Protection Screen". Previously, the code didn't prevent keyboard events with modifiers being used. Since the ascii values for these were outside the 0-9 numeric range, this resulted in an invalid frame number being used and thus the engine aborted at an asertion.
2012-03-13JANITORIAL: Simply use *x instead of *x.get() on smart pointers.Christoph Mallon
2012-03-13JANITORIAL: Remove dead code.Christoph Mallon
2012-03-13JANITORIAL: Make getters const.Christoph Mallon
2012-03-13JANITORIAL: Avoid the ugly operator invocation syntax.Christoph Mallon
2012-02-15JANITORIAL: Fix missing whitespace in pointer castTarek Soliman
find -name '*.h' -or -name '*.cpp' | xargs sed -r -i 's@\(([A-Za-z0-9]+)\*\)@(\1 *)@g' This seems to have caught some params as well which is not undesirable IMO. It also caught some strings containing this which is undesirable so I excluded them manually. (engines/sci/engine/kernel_tables.h)
2012-01-14LURE: Move readByte() call out of assert()Torbjörn Andersson
2011-12-18Merge pull request #131 from digitall/goto_considered_harmfulDavid Turner
Goto Considered Harmful... The following commits should improve the ScummVM code structure by reducing the number of gotos used in various engine code. They should implement identical functionality, but without using goto and without the result being less readable/maintainable than the version with goto.
2011-12-09LURE: Converted the AnimationDecoder::decode_data routine to remove GOTO usagePaul Gilbert
2011-12-09LURE: Converted the vgaDecode routine to remove GOTO usagePaul Gilbert
2011-12-08LURE: Reduce usage of 'goto'.D G Turner
Have refrained from changing the usage of 'goto' in the PictureDecoder class (decode.cpp) for the time being, as this class is using these in pseudo-x86 code which is complex and should be replaced anyway.
2011-11-16LAUNCHER: Introduce GUIO0() in order to replace GUIO1(GUIO_NONE)Strangerke
2011-11-16COMMON: Rename Common::set_to to Common::fill.Johannes Schickel
This makes the name match with the name of the STL function with the same behavior.
2011-11-03LURE: Fix warningsEugene Sandulenko
2011-10-23AD: Switched rest of the engines to new GUIOEugene Sandulenko
2011-09-09LURE: Fix crash caused by trying to talk to a character when an ask action ↵Paul Gilbert
is in progress
2011-08-07JANITORIAL: Remove trailing empty lines.Christoph Mallon
2011-08-06ALL: Reduce audio/ header dependencyEugene Sandulenko
2011-06-30JANITORIAL: Silence a couple of "variable set but not used" warnings.eriktorbjorn
2011-06-30ALL: Require DECLARE_SINGLETON to be used in the Common namepsaceOri Avtalion
Silences the clang warning: static data member specialization of '_singleton' must originally be declared in namespace 'Common'; accepted as a C++0x extension [-Wc++0x-extensions] Wrapping "namespace Common {}" around the macro assignment causes clang to complain about a spurious semicolon, and removing the semicolon at the end of the macro causes some editors to misbehave. Changing the requirement of using the macro in one namespace (the global) to another (Common) seems a small price to pay to silence a warning.
2011-06-23LURE: Allocate debug strings buffer on the heapJulien
2011-06-23ANALYSIS: Fix potential memory leak when using reallocJulien
When reallocation is unsuccessful, the passed buffer is not freed. In this case, assigning the result (NULL) will result in a leak of the original memory buffer. See http://msdn.microsoft.com/en-us/library/kkedhy7c.aspx
2011-06-20ALL: Remove trailing whitespacesMax Horn
This tries to make our code a bit more compliant with our code formatting conventions. For future use, this is the command I used: git ls-files "*.cpp" "*.h" | xargs sed -i -e 's/[ \t]*$//'
2011-06-14LURE: Add a comment explaining why kADFlagUseExtraAsHint is usedMax Horn
For the records, this was introduced by Eugene in SVN revision 30106, corresponding to git commit b87b0f21
2011-06-14DETECTOR: Merge ADParams into AdvancedMetaEngineMax Horn
2011-06-10LURE: Switch to alternate AdvancedMetaEngine, avoid ADParamsMax Horn
2011-06-10ENGINES: Change incorrect use of 'target' to 'gameid'Max Horn
2011-06-02LURE: Replace snprintf() usage with Common::String::format()D G Turner
Safer and less portability issues.
2011-06-02ENGINES: Change 2nd param of Engine::saveGameState to Common::StringMax Horn
2011-05-25ALL: initialise -> initializeMatthew Hoops
2011-05-25ALL: favour/favourite -> favor/favoriteMatthew Hoops
2011-05-25ALL: behaviour -> behaviorMatthew Hoops
2011-05-22ENGINES: Further unify engine namesThierry Crozat
2011-05-17LURE: Rename method random() -> getRandom()Max Horn
Also get rid of a slight bias for 0 in the random numbers (it was selected twice as often as any other number).
2011-05-17COMMON: Registers RandomSources in constructor with the event recorderMax Horn
This also removes the dependency of engines on the event recorder header and API, and will make it easier to RandomSources that are not properly registered.
2011-05-16ENGINES: Unify engine namesThierry Crozat
This unifies the engine names in MetaEngine::getName() and the credits. In particular drop "Engine" or "engine" from the names when it was present and use expanded names in credits when the MetaEngine uses it (e.g. "Beneath a Steel Sky" instead of "BASS").
2011-05-12GIT: Clean up: Suppress SVN tags, now uselessstrangerke
2011-04-28JANITORIAL: Reduce header dependencies in shared codeOri Avtalion
Some backends may break as I only compiled SDL
2011-04-28JANITORIAL: Format forward declarations to follow conventionOri Avtalion
2011-04-19LURE: Enabled clickable menus for WebOS.Klaus Reimer
2011-04-18COMMON: Rename Error to ErrorCode, introduce new Error classMax Horn
2011-04-14ALL: colour -> colorMax Horn
2011-03-23ENGINES: Remove unused MIDI pass-through codeMax Horn
2011-03-23ENGINES: Further simplify pseudo MidiDrivers; fix some regressionsMax Horn
The regression affected AGOS and maybe some others; specifically, the real MidiDriver would have been deleted twice -- I previously missed that the Engine instances takes care of freeing the real MidiDriver, not the MidiPlayer wrapping it. This commit should clarify the ownership of the real MidiDriver for most pseudo MidiDrivers.
2011-03-23AUDIO: Change several fake MidiDrivers to MidiDriver_BASE subclassesMax Horn
Many engines follow the advice in audio/midiparser.h and create a "pseudo-MidiDriver" subclass. But MidiParser really only needs a tiny subset of the MidiDriver capabilities, namely those found in MidiDriver_BASE. So we try to subclass from that whenever possible; this allows us to remove many stub methods, and enables further future simplifications.
2011-03-22AUDIO: Add pure virtual MidiDriver::isOpen() methodMax Horn
This in turn enables modifying MidiDriver_MPU401::close() to allow it to be called on a midi driver that has not yet been opened. The specific issue that triggered me to make these changes was a crash-upon-quit in HUGO, caused by it instantiating a midi driver, then encountering an error (missing hugo.dat) *before* having opened the new midi driver; the general cleanup code then tries to close the (not yet opened) midi driver -> kaboom Also fixed some engines which were leaking MidiDriver instances.
2011-03-19LURE: Init volume levels on startupdhewg
And set global volume levels
2011-02-14LURE: Adapt to setPalette RGBA->RGB change.Johannes Schickel
This is currently done by converting the internal palette from RGBA(?) to RGB when setPalette is called.
2011-02-09AUDIO: Rename sound/ dir to audio/Max Horn
svn-id: r55850