aboutsummaryrefslogtreecommitdiff
path: root/engines/sci
AgeCommit message (Collapse)Author
2017-01-14SCI: Fix Warnings about Copy Constructor Failing to Call Base Class.D G Turner
2017-01-12SCI32: Fix bad scroll delta in GK2 inventoryColin Snover
Fixes Trac#9648.
2017-01-12SCI32: Fix crash trying to clip invalid rects generated by transitionsColin Snover
In PQ4CD, when leaving the shooting range through the front door, some transition screen items will be generated that have invalid dimensions. SSCI simply clips these rectangles to zero.
2017-01-12SCI32: Add Hoyle5 to the list of game versionsColin Snover
2017-01-12SCI32: "Fix" renderer for PQ4CDColin Snover
PQ4CD and several other games contain a hack in two renderer methods to avoid rendering invalid screen items with zero or negative-dimension target rects. This prevents PQ4CD from crashing during the fifth phase of target practice.
2017-01-12SCI32: Add workarounds, transitions, fixes for PQ4CDColin Snover
2017-01-11SCI32: Fix uninitialised read of cursor background at start of gameColin Snover
2017-01-11SCI32: Add workarounds for PQ:SWATColin Snover
2017-01-11SCI32: Fix null references in Robot decoderColin Snover
Failing to reduce the size of the ScreenItem arrays causes other parts of the decoder (like RobotDecoder::getFrameSize) to try reading ScreenItems that were already destroyed and nulled out in the list. (In SSCI, the screen item count was held in a separate property instead of being part of the screen item list.)
2017-01-11SCI32: Remove backslashes from PQ:SWAT extra save game filesColin Snover
The original interpreter created subdirectories for each in-game profile, but copying this behaviour would add a lot of superfluous complexity to the save game system in ScummVM, and may not be portable to all supported platforms. Instead, when the game tries to save its files to a subdirectory, the backslash in the file name is replaced with an underscore so it can be created successfully on filesystems where backslash is an illegal file name character. This has a side-effect of causing all save games to be displayed under all profiles, instead of just the ones "belonging" to a particular profile, but this seems like a reasonable trade-off given that there is no reason to play this game with more than one profile.
2017-01-11SCI32: Remove unnecessary call to unallocColin Snover
When the Resource is deleted, it will deallocate the memory, so it is not necessary to do that manually.
2017-01-11SCI32: Improve mouse responsivenessColin Snover
This is most noticeable at the beginning of the game during benchmarking, where the benchmarking loop used to cause the mouse to get stuck for the duration of the benchmark.
2017-01-11SCI32: Add a workaround for the demo version of LSL7Filippos Karapetis
2017-01-10SCI: Fix Unused Variable Compiler Warning when SCI32 is not enabled.D G Turner
The bytesWritten variable is not used if SCI32 is not enabled. Fixed by adding this and success flag to the debug console print.
2017-01-09SCI32: Fix kSetLanguageColin Snover
2017-01-09SCI32: Fix bad rendering of Sierra logo in MGDXColin Snover
2017-01-09SCI32: Disable compression for Phantasmagoria save filesColin Snover
2017-01-09SCI32: Fix bad coordinates in PQ:SWAT demoColin Snover
2017-01-09SCI32: Fix Torin demo crashColin Snover
2017-01-09SCI32: Fix SQ6 demo crashColin Snover
2017-01-09SCI32: Fix GUIOs for all SCI2-2.1late gamesColin Snover
2017-01-09SCI32: Mark non-interactive Lighthouse demo as non-interactiveColin Snover
2017-01-09SCI32: Fix invalid bitmap deletion in AVIPlayerColin Snover
2017-01-09SCI32: Fix crashes and bad cel positioning in GK2 demoColin Snover
2017-01-09SCI32: Ignore .OLD extension when searching Audio36 patchesColin Snover
KQ7 2.00b includes a SIERRINF.OLD file which should not be matched.
2017-01-09SCI32: Generalise uninitialised read workarounds for RAMAColin Snover
2017-01-09SCI32: Ignore attempts to free null array reg_tsColin Snover
2017-01-09SCI32: Clean up SCI3-only opcodesColin Snover
SCI3 includes four new opcodes: * op_info[0x26][0] puts -info- flag in accumulator * op_infoSP[0x26][1] pushes -info- flag to stack * op_superP[0x27][0] puts -super- reference in accumulator * op_superPSP[0x27][1] pushes -super- reference to stack The implementation of these opcodes was correct already, but the opcode names given were a bit misleading (the value is not always stored to accumulator), and magic numbers were used for these opcodes in places. A review of the opcode table in Phant2 indicates that there are no other new opcodes for SCI3.
2017-01-09SCI32: Clean up comment on kSetHotRectanglesColin Snover
Since this feature is now implemented, it is not necessary to describe its intended functionality here.
2017-01-09SCI32: Split kCelInfo into subopsColin Snover
Different subops have different call signature requirements.
2017-01-09SCI32: Enable playback of stereo audioColin Snover
2017-01-09SCI32: Remove SCI3 workarounds hackColin Snover
2017-01-09SCI32: Fix kSetShowStyle signature for SCI3Colin Snover
2017-01-06SCI32: Fix overlapped memory copies in SciStringColin Snover
2017-01-06SCI32: Fix a subtle bug in SciArray::trim()Filippos Karapetis
With this bug, whenever a string was trimmed from the right, the last character was always cut off, even if it wasn't whitespace. This was apparent in the RAMA demo, which parses a text file for its scenes, and each line is trimmed
2017-01-06SCI: Add FIXME for (very unlikely) race condition in _palVarySignalWillem Jan Palenstijn
2017-01-06SCI: Unconditionally save palvary stateWillem Jan Palenstijn
Additionally, add workaround to fix up old QfG3 saves with broken _palVaryPaused state. Fixes bug #9674.
2017-01-05SCI32: Fix off-by-one error in array resizingColin Snover
This bug existed in SSCI and was pulled in carelessly during initial implementation of SciArray. Closer examination of SCI3 reveals that this only happened to work in SSCI because it would always allocate on the first resize, and would always allocate 25 extra elements per allocation.
2017-01-05SCI32: Add validity checks to kList iteration methodsColin Snover
In GK2, restoring a save game causes the segment manager to reset in the middle of a kListFirstTrue call, which invalidates all pointers and reg_ts to stored data. This means that when kListFirstTrue tries to decrement the list recursion counter at the end of iteration, it is writing to freed memory, potentially resulting in heap corruption. SCI3 added checks to prevent this from happening, but these checks seem like they should have also been applied to some SCI2.1 games as well (like GK2). Since there should be no negative side-effect to this check, it is applied universally to all SCI32 games.
2017-01-02SCI32: Load VMDs from resource bundlesColin Snover
GK2 includes some VMDs in the RESSCI.00n volume bundles for the chase scene at the end of Chapter 6.
2017-01-02SCI32: Remove invalid GUIO options from GK2Colin Snover
2017-01-01SCI: Fix PQ2 crash reading second page of files in jailColin Snover
This fixes the crash in PQ2 1.002.011. There is another workaround for the same problem from ticket Trac#5223, but it uses a different method name that does not match in this version of PQ2. Fixes Trac#9670.
2016-12-21SCI: Fix kq6 CD audio+subtitle script patchMartin Kiewitz
Original patch caused a text window to be shown at the cliffs (copy protection), even when audio-only mode was active.
2016-12-19SCI32: Improve ScreenItem missing resource errorColin Snover
2016-12-19SCI32: Add support for alternate graphics selectorsColin Snover
Used by at least Phantasmagoria 2.
2016-12-19SCI32: Undefine macro for SciBitmap when it is done being usedColin Snover
2016-12-19SCI32: Generalize Phant1 kArraySetElements workaroundColin Snover
This bug exists in a system script that is called from many, many rooms, so it is simpler to just make the workaround apply to all rooms.
2016-12-19SCI32: Change plane and screen item sorting algorithmColin Snover
SSCI's last resort comparison here was to compare the object IDs of planes & screen items, but this randomly breaks (at least) the "you have died" dialog at the end of Phant1, and text & buttons in Hoyle5, even in SSCI itself. This commit changes last resort comparison to use a monotonically increasing ID instead, which keeps objects with identical priority & z-index in creation order when compared. Fixes Trac#9585.
2016-12-19SCI32: Fix incorrect parsing of empty |f| text escape codeColin Snover
This sequence is used in Hoyle5 when viewing the rules for a game.
2016-12-19SCI32: Fix nitpicky output errors in SCI32 bitmap debuggingColin Snover