Age | Commit message (Collapse) | Author |
|
svn-id: r21348
|
|
svn-id: r21347
|
|
catacombs")
- Fixes some sprite redraw bugs introduced with my last commits
- Fixes wsa drawing bug in the cave too
svn-id: r21346
|
|
flute sound, and probably other regressions as well.)
svn-id: r21345
|
|
directly. If they want a new data pointer, they have to use the dataptr
parameter. This fixes a subtle bug that would cause the wrong music to play
when getting the quill in Kyra 1.
svn-id: r21344
|
|
svn-id: r21343
|
|
svn-id: r21342
|
|
svn-id: r21341
|
|
Added some comments on the strange but probably harmless things going on in
playSoundEffect()
svn-id: r21340
|
|
disassembly. I think they're correct now, and a bit easier to read. My old
comments were wrong, too.
I think they are for manipulating the Adlib rhythm section volumes. I'm not
sure the Kyra music ever uses the Adlib rhythm section.
svn-id: r21339
|
|
- revised the way NUM_MAX_PARTDATA and NUM_MAX_ANIMDATA are used
- renamed some variables
- constify'ed function arguments
- minor cleanup
svn-id: r21338
|
|
instrument. These are found using the lookup tables in _soundData on offsets 0
and 500 respectively. Added helper functions for that, which makes the code a
lot tidier. Particularly in update_setupRhythmSection(), where it's now much
clearer where it's getting all those "unk" values from.
Use the checkValue() function (which limits the "total level" to its valid
range) for the calculateOpLevel1() and 2() functions as well.
Renamed updateCallback16() to update_waitForEndOfProgram().
svn-id: r21337
|
|
callbackOutput() -> setupPrograms()
callbackProcess() -> executePrograms()
updateCallback3() -> update_setupProgram()
_unk4 -> _rhythmSection
updateCallback48() -> update_setupRhythmSection()
updateCallback49() -> update_playRhythmSection()
updateCallback50() -> update_removeRhythmSection()
svn-id: r21336
|
|
updateCallback3() would call unkOutput2(9) in at least one case. This is
obviously wrong because it a) reads outside _regOffsets[], and b) writes to
invalid Adlib registers.
Now unkOutput2() has the same safeguards as noteOff() already had, making
callbackOutput() and updateCallback3() even more similar.
svn-id: r21335
|
|
svn-id: r21334
|
|
just how similar callbackOutput() and updateCallback3() are.
svn-id: r21333
|
|
correct restored background)
- Fixes brandon width value after loading (removes gfx glitch while talking with the tree)
svn-id: r21332
|
|
svn-id: r21331
|
|
svn-id: r21330
|
|
svn-id: r21329
|
|
svn-id: r21328
|
|
svn-id: r21327
|
|
svn-id: r21326
|
|
svn-id: r21325
|
|
svn-id: r21324
|
|
svn-id: r21323
|
|
svn-id: r21322
|
|
svn-id: r21321
|
|
- implements cmd_brandonToStoneSequence and cmd_pauseMusicSeconds
svn-id: r21320
|
|
svn-id: r21319
|
|
svn-id: r21317
|
|
pending events so that the it won't have to do a little dance, catching up,
every time you enter a room.
svn-id: r21316
|
|
svn-id: r21315
|
|
svn-id: r21314
|
|
automatically, for some reason.
svn-id: r21312
|
|
svn-id: r21311
|
|
svn-id: r21310
|
|
called redundantly.
svn-id: r21309
|
|
* Common::File will now look inside the application bundle on MacOS X for a file if
it can't find it anywhere else (so it'll find default-theme.ini and .zip)
* Cleaned up some #ifs.
svn-id: r21308
|
|
svn-id: r21307
|
|
svn-id: r21306
|
|
svn-id: r21304
|
|
noisy.)
svn-id: r21303
|
|
while still at the very beginning of the "attack" phase. This is the very
lowest point on the attack curve, yet it would continue from the beginning of
the release curve, i.e. its very highest point. This is what caused Kyra to
often play low-frequency notes at the very beginning of a new song. (That, and
a truly bizarre function for initialising the channels.)
The proper fix would be to locate the correct point on the release curve and
continue from there. For now, though, only handle the trivial case.
svn-id: r21302
|
|
(Unfortunately, this does not fix the Kyra bug I'm looking for.)
In the most extreme case:
* DR and RR will point to &DR_TABLE[60], and AR will point to &AR_TABLE[60]
* SLOT->KSR will be 0
* CH->kcode will be 15
In that case, it will attempt to access AR[15], RR[15] and DR[15], i.e.
AR_TABLE[75] and DR_TABLE[75]. So these arrays need to be 76 elements, not 75.
We used to initialise element 75, but this was changed to 74 to match the size
of the arrays. Buf if my reasoning is correct, it was the arrays that were too
small.
svn-id: r21301
|
|
- Adds support for amiga .pak files (and a filelist)
svn-id: r21299
|
|
svn-id: r21298
|
|
svn-id: r21296
|
|
svn-id: r21295
|
|
brandons home is fixed with this)
- Changes _tempo, tempo, position, unk41, unk32, unk18, unk19, _unkValue3 to unsigned (should be correct this time)
svn-id: r21293
|