| Age | Commit message (Collapse) | Author |
|---|
|
The result of using memcpy when source and destination overlap is
not clearly defined, so use memmove instead which avoids this problem.
|
|
|
|
Also-By: Matthew Hoops <clone2727@gmail.com>
|
|
This changes the convention back to skipping the thumbnail loading
for readSaveGameHeader. querySaveMetaInfos is the only place it
shouldn't be skipped.
|
|
Fixes Trac#10619.
The thumbnail loading for the saved games was defaulting to
disabled so no thumbnail was being loaded and this caused trying
to show the thumbnail to crash scummvm.
So I have set the thumbnail pointer to be null if the thumbnail
doesn't get loaded and I've set the thumnail to not be skipped
so that thumbnails get shown when using the gui.
|
|
|
|
This commit introduces the following changes:
1. Graphics::loadThumbnail()
Now returns a boolean and takes a new argument skipThumbnail which
defaults to false. In case of true, loadThumbnail() reads past the
thumbnail data in the input stream instead of actually loading the
thumbnail. This simplifies savegame handling where, up until now,
many engines always read the whole savegame metadata (including
the thumbnail) and then threw away the thumbnail when not needed
(which is in almost all cases, the most common exception being
MetaEngine::querySaveMetaInfos() which is responsible for loading
savegame metadata for displaying it in the GUI launcher.
2. readSavegameHeader()
Engines which already implement such a method (name varies) now take
a new argument skipThumbnail (default: true) which is passed
through to loadThumbnail(). This means that the default case for
readSavegameHeader() is now _not_ loading the thumbnail from a
savegame and just reading past it. In those cases, e.g.
querySaveMetaInfos(), where we actually are interested in loading
the thumbnail readSavegameHeader() needs to explicitely be called
with skipThumbnail == false.
Engines whose readSavegameHeader() (name varies) already takes an
argument loadThumbnail have been adapted to have a similar
prototype and semantics.
I.e. readSaveHeader(in, loadThumbnail, header) now is
readSaveHeader(in, header, skipThumbnail).
3. Error handling
Engines which previously did not check the return value of
readSavegameHeader() (name varies) now do so ensuring that possibly
broken savegames (be it a broken thumbnail or something else) don't
make it into the GUI launcher list in the first place.
|
|
This flag is removed for a few reasons:
* Engines universally set this flag to true for widths > 320,
which made it redundant everywhere;
* This flag functioned primarily as a "force 1x scaler" flag,
since its behaviour was almost completely undocumented and users
would need to figure out that they'd need an explicit non-default
scaler set to get a scaler to operate at widths > 320;
* (Most importantly) engines should not be in the business of
deciding how the backend may choose to render its virtual screen.
The choice of rendering behaviour belongs to the user, and the
backend, in that order.
A nearby future commit restores the default1x scaler behaviour in
the SDL backend code for the moment, but in the future it is my
hope that there will be a better configuration UI to allow users
to specify how they want scaling to work for high resolutions.
|
|
I've not fixed this one, maybe it's on purpose:
RELASE -> RELEASE
engines/mads/staticres.cpp:const char *const kGameReleaseTitleStr =
"GAME RELASE VERSION INFO";
|
|
|
|
Added it into hasFeature() of all engines which returned `true` in
simpleSaveNames() before.
As mentioned in #788, SCI is not always using simple names, so it
doesn't have such feature now.
|
|
Engines with "simple" savenames would support "Run in background" in
save/load dialog and gradual save slots unlocking. Other engines
save/load feature would be locked until save sync is over.
|
|
|
|
A regression of 75d1385c8d1ba61b5740a0b43966d3c2f111440d
|
|
|
|
This removes the annoying behavior that removing a save state causes your
physical files to be renamed.
|
|
_singleid -> _singleId
_gameids -> _gameIds
_guioptions -> _guiOptions
|
|
LAB: Fix bug #7022 - Events not processed during ending sequence
|
|
|
|
|
|
Thanks to tsoliman for noticing.
|
|
|
|
|
|
A regression from 4fb53ad170f483bbce2e27643cd3ee1fa604cebd
|
|
Regression from cd3ebf687c0e783147723095056d72684eddd347.
This fixes bug #6997.
|
|
|
|
|
|
Fixes toilet noises.
|
|
Windows)
|
|
known to be missing in the original
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
These are leftovers, as updateEvents() was called to fill in the music
buffer
|
|
|
|
|
|
The FONTS folder is pretty much useless, so if a user points ScummVM
to the GAME folder, handle the game files properly
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
